2015-05-30, 21:52
I'm experimenting with changes necessary to support ATSC <m>.<n> channel numbering. Started by comparing with Confluence skin. I currently seem to have them working. Here are the changes I have made:
Change all occurrences of "ChannelNumber" to "ChannelNumberLabe"l. This affects files DialogFullScreenInfo.xml, DialogPVRChannelManager.xml, DialogPVRChannelsOSD.xml, DialogPVRGroupManager.xml, DialogSeekBar.xml, MyPVRChannels.xml, VideoFullScreen.xml, and View_PVR.xml.
The resulting wider channel number overlaps the VideoPlayer.ChannelName and Player.Title elements of the OSD. Changed the <posx> element from 400 to 430 on these two labels in file VideoFullScreen.xml. Reduced <width> element from 720 to 690 for VideoPlayer.ChannelName and added <width> element of 690 to Player.Title.
The OSD changes work fine for 99.9 channel numbering, and should probably work better for 9999 numbering as well. However, I can't test that and I'm not sure about the correctness of the width settings in relation to the progress bar. It doesn't seem like those values were explicitly measured anyway.
I hope these changes are suitable for adding to the official addon. I like the skin quite well and hope to continue using it permanently. Thanks for all the hard work.
Change all occurrences of "ChannelNumber" to "ChannelNumberLabe"l. This affects files DialogFullScreenInfo.xml, DialogPVRChannelManager.xml, DialogPVRChannelsOSD.xml, DialogPVRGroupManager.xml, DialogSeekBar.xml, MyPVRChannels.xml, VideoFullScreen.xml, and View_PVR.xml.
The resulting wider channel number overlaps the VideoPlayer.ChannelName and Player.Title elements of the OSD. Changed the <posx> element from 400 to 430 on these two labels in file VideoFullScreen.xml. Reduced <width> element from 720 to 690 for VideoPlayer.ChannelName and added <width> element of 690 to Player.Title.
The OSD changes work fine for 99.9 channel numbering, and should probably work better for 9999 numbering as well. However, I can't test that and I'm not sure about the correctness of the width settings in relation to the progress bar. It doesn't seem like those values were explicitly measured anyway.
I hope these changes are suitable for adding to the official addon. I like the skin quite well and hope to continue using it permanently. Thanks for all the hard work.