Kodi Community Forum
script favourites - new features - Printable Version

+- Kodi Community Forum (http://forum.kodi.tv)
+-- Forum: Development (/forumdisplay.php?fid=32)
+--- Forum: Skin Development (/forumdisplay.php?fid=12)
+--- Thread: script favourites - new features (/showthread.php?tid=114671)

Pages: 1 2 3 4 5 6 7 8 9 10 11 12 13


- ronie - 2011-11-19 00:31

i think logo-downloader uses list 6


- `Black - 2011-11-19 01:10

Seems like a custom dialog which uses the select dialog xml... that would be a way to do it.


- pecinko - 2011-11-19 13:40

`Black Wrote:Seems like a custom dialog which uses the select dialog xml... that would be a way to do it.

Little nitpicking - it would be nice to include read.me file. It is sufficient to copy-paste your first post, just that you don't have to look in forums for info.


- Hitcher - 2011-11-19 14:56

ronie Wrote:i think logo-downloader uses list 6

`Black Wrote:Seems like a custom dialog which uses the select dialog xml... that would be a way to do it.

So is this something the script can do?


- `Black - 2011-11-19 15:27

Yes.. only downside is that you have to use e.g. Window.IsActive(DialogSelect.xml) instead of Window.IsActive(selectdialog).

script.favourites-3.2.0.zip (you might have to unzip an replace manually instead of install via zip).


- pecinko - 2011-11-19 15:42

Thanks.

I have strange graphic glitches with this version, not sure why.

Click on button, dialogselect pups-up. Now hit ESC

Is there a way to hide default label2 (shows skin version) ?

[Image: screenshot20111119at143.png]
[Image: screenshot20111119at143.png]


- `Black - 2011-11-19 15:59

What glitches? I don't see any in my skin... I've set the path to label2 since I didn't know any skin which uses it... you can get the skin/addon version with ListItem.Property(Addon.Version) so I would recommend to use that. But I'll change it to a property, just in case. Smile


- Hitcher - 2011-11-19 16:18

I did use Label2 but have just changed it to ListItem.Property(Addon.Version).

Works perfectly, thanks.


- pecinko - 2011-11-19 17:08

`Black Wrote:What glitches? I don't see any in my skin... I've set the path to label2 since I didn't know any skin which uses it... you can get the skin/addon version with ListItem.Property(Addon.Version) so I would recommend to use that. But I'll change it to a property, just in case. Smile

Just thought it might be a good practice not to use system labels in scripts if you necessary don't have to. IFAICT, it is used when setting add ons for first item - clear current setting.

As for the glitch - I have posted screenshot above if that helps somehow. Not sure how you call it as debug shows full path instead of window name. Don't know if this is causing the issue.


- pecinko - 2011-11-19 17:17

Yep it definitely looks like dialogselect does not get cleared properly here if ESC is hit.


- `Black - 2011-11-19 19:09

Unlikely... as I said it's not really the select dialog and that's why the full path is shown. It's now a custom dialog, I could also use script-favourites-dialog.xml or something else but every skin has DialogSelect.xml so it makes sense to use it. Smile

Edit: Seems like deinit is not called, I'll look into it.


- pecinko - 2011-11-19 19:27

`Black Wrote:Unlikely... as I said it's not really the select dialog and that's why the full path is shown. It's now a custom dialog, I could also use script-favourites-dialog.xml or something else but every skin has DialogSelect.xml so it makes sense to use it. Smile

Edit: Seems like deinit is not called, I'll look into it.

Danke.

What ID is it using (so I don't get in a collision)?

Just a thought - would it be easier to use ID 3 as in a previous version and set icons? We would just add those to a dialog. They won't be shown with system things but they would be visible with favorites script.


- Rififi77 - 2011-11-19 20:27

hi,
attached french translation for your script


Code:
<?xml version="1.0" encoding="utf-8" standalone="yes"?>
<strings>
    <string id="450">Voulez-vous jouer la playliste au lieu d'entrer dedans?</string>
    <string id="451">Aucun (Efface le param├Ętre actuel)</string>
</strings>

@+


- `Black - 2011-11-21 14:16

Thanks, will be added in the next update.

@pecinko
DeInit problem seems to be a bug with python, I already created a trac ticket... same problem with logo downloader.


- pecinko - 2011-11-22 08:58

Ok. So we can use last version and, in time, dialog will start behaving himself I suppose.