Kodi Community Forum
[Windows] Some small patches for PVR Build Windows based on Margo branch - Printable Version

+- Kodi Community Forum (http://forum.kodi.tv)
+-- Forum: Development (/forumdisplay.php?fid=32)
+--- Forum: PVR Development (/forumdisplay.php?fid=136)
+--- Thread: [Windows] Some small patches for PVR Build Windows based on Margo branch (/showthread.php?tid=128908)



Some small patches for PVR Build Windows based on Margo branch - DAMGO - 2012-04-14 23:49

Dear all,

i have here some small (experimental) modifications written for following issues:

Patch 1: Recording via Remote (HAMA remote (red recording button) and keyboard)
in Fullscreen mode there was missing simply the Action "Record" Command

Patch 2: Timestamp for Instant Recording corrected, no more
1970 dates as start date....

Patch 3: simple concurrency recording checker for instant recording, so
that double recording on same time is blocked or the start end/time set to
the next free timeslot. very experimental and not all errorcases catched, but
working!

If somebody interested at the modification, i can forward to them.for checking in GIT.

If the time there I will continue on EPG recording issues and direct
recording support for the other menues in LiveTV.

Kind regards


RE: Some small patches for PVR Build Windows based on Margo branch - Dam0 - 2012-04-15 08:29

cheers Damgo, great job.

thanks for the hard work:-)

i look forward to inclusing in upcoming magro release

Dam0


RE: Some small patches for PVR Build Windows based on Margo branch - margro - 2012-04-15 15:02

(2012-04-14 23:49)DAMGO Wrote:  If somebody interested at the modification, i can forward to them.for checking in GIT.

Patches and fixes are always welcome. Just send me or Opdenkamp a pull request on Github (I saw that you already created a fork).
I will backport bugfixes to my Eden-pvr branch for inclusion in a next Eden-pvr 11.0 r2 build.


RE: Some small patches for PVR Build Windows based on Margo branch - DAMGO - 2012-04-15 17:56

Dear Dam0, Dear Margro,

yes the fork it just my playground not to disturb the other repositories.

Adresse:
git@github.com:DAMGO/xbmc.git

The changes are committed to the forked part. I tried to send you the pulls
from my cloned repository, but somehow i am not familiar with the GIT,
tortoise system and the pulls are not shown.

Please let me know how to send the pulls again if there something goes wrong.

For patch 3: it will be improved, it just a start. Am actually not really happy
with the handling of start end detection and setting.

@Margro: just asked does the Mediaportal Plugin send/receive the information if a
recording running on one TimerTag ?
I mentioned the funtion:
PVR_ERROR cPVRClientMediaPortal::GetTimers(PVR_HANDLE handle)
if yes then i would like to set the state of the channels so that the ...isrecording function works.

Kind regards