+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: Add-on Support (https://forum.kodi.tv/forumdisplay.php?fid=27)
+---- Forum: Program Add-ons (https://forum.kodi.tv/forumdisplay.php?fid=151)
+---- Thread: Release TvTunes Addon - Retrieve & Play Soundtracks Whilst Browsing Your Library (/showthread.php?tid=173799)
RE: TvTunes Addon - TV Show Theme Music while browsing - robwebset - 2013-12-06
I have added the automatic delay for list views, diff available for self patching:
http://code.google.com/p/robwebset/source/detail?r=134
Please let me know how you get on. (The delay is about 0.4 seconds)
Rob
@capfuturo - I'm a bit concerned about the number of config options at the moment.
In addition, the time() operation that the script is using to work out the delay MAY not support fractions of seconds on some platforms:
http://docs.python.org/2/library/time.html
So I thought better to be safe - and assume it never does
Rob
RE: TvTunes Addon - TV Show Theme Music while browsing - robwebset - 2013-12-07
(2013-12-06, 15:04)rob_webset Wrote:(2013-12-05, 22:02)meridius Wrote: Hi there tried the new version 4.0.1 with xbmc 12.2 and I have noticed a bug still with the fade out option selected
In the older version it used to mute the system but now it keeps the volume at 25% and it happens all the time when I reload xbmc. I have to disabled fade out to stop it from doing that. I was wondering if this option will be fixed as it seems to be a sticking point when using this option
AAAAAHHHH!!! I thought we fixed all of those!! Please can you give me click by click instructions, and I will see if I can reproduce it - then fix it
OK, I think I have reproduced what you MAY have been seeing. If you exit quickly from XBMC while a theme is playing then sometimes the volume does not get reset. I have done a fix under r141:
http://code.google.com/p/robwebset/source/detail?r=141
However I have seen cases where xbmc does not seem to apply the setting of the volume during a shutdown - I can see the log entry saying we are resetting it - but sometimes it just gets ignored. (I think if you always went to the home screen before exiting, then things get reset OK)
If you can try this out and let me know how you get on, and if there is still a problem - once I have confirmation that the sound issues are resolved I may look at another publish to the official repo.
Thanks, Rob
RE: TvTunes Addon - TV Show Theme Music while browsing - meridius - 2013-12-07
Hi rob
Thanks for the help, I always wait for the sound to stop being played when I shutdown my xbmc as I always have to go to the home screen and select shutdown and by that time the tune has stopped playing.
I do have all the option set to off and only have fade tunes out option on and audio level reduced to 12 in the options menu.
Do u want me to try r141
Thanks once again.
Oh also about the audio delay you could always have an option under the first 1s so maybe
0.3 sec, 0.5sec. 0.7, 1s, 2s and so on
It would be a great feature, the only reason for this is because when you have it set to 0sec the menus when you scroll all stutter so it's not very smooth or nice to use but at 1sec the menus are very smooth but the music plays back that little bit to late for me and would like it to kick in a little faster this is where them 0.3 sec, 0.5sec. 0.7, 1s, 2s and so on options would come in handy
Cheers for the response and help.
RE: TvTunes Addon - TV Show Theme Music while browsing - capfuturo - 2013-12-07
In my system TvTunes stops the theme play immediately when the 'S' key is struck (I don't have to wait) and the window menu with options to shut down, go to settings, etc... pops up. I initially thought this was something wrong but actually I realised it's like this by design, so it makes sure that when you shut XBMC down this way or go to any other menu, the theme has stopped and all volume levels are back to normal. Am I right in thinking this?
RE: TvTunes Addon - TV Show Theme Music while browsing - robwebset - 2013-12-07
(2013-12-07, 19:00)meridius Wrote: Oh also about the audio delay you could always have an option under the first 1s so maybe
0.3 sec, 0.5sec. 0.7, 1s, 2s and so on
I have put in a feature that will auto delay about 0.4s on the list screen - see what you think in the latest patch.
If you can test the sound issue to see how it behaves - and generate me a log to highlight the problem if it still exists. (Which skin are you using?)
(2013-12-07, 19:16)capfuturo Wrote: In my system TvTunes stops the theme play immediately when the 'S' key is struck (I don't have to wait) and the window menu with options to shut down, go to settings, etc... pops up. I initially thought this was something wrong but actually I realised it's like this by design, so it makes sure that when you shut XBMC down this way or go to any other menu, the theme has stopped and all volume levels are back to normal. Am I right in thinking this?
Yes - TvTunes detects when the shutdown screen is displayed and stops the theme playing - I've tried to do everything to stop the audio level not being reset.
Rob
RE: TvTunes Addon - TV Show Theme Music while browsing - robwebset - 2013-12-07
Hi All,
New option as requested that enables the use of a sub-directory to store themes in under the TV Show or Movie directory. If you wanted to try it out it's in r144:
http://code.google.com/p/robwebset/source/detail?r=144
You will need to enable it in the addon settings.
Please let me know how you get on.
Rob
RE: TvTunes Addon - TV Show Theme Music while browsing - meridius - 2013-12-07
Hi rob I use aeon nox skin.
RE: TvTunes Addon - TV Show Theme Music while browsing - robwebset - 2013-12-07
(2013-12-07, 23:35)meridius Wrote: Hi rob I use aeon nox skin.
Please can you quickly try it on confluence and see if you see the problem.
Thanks, Rob
RE: TvTunes Addon - TV Show Theme Music while browsing - capfuturo - 2013-12-08
Hi Rob,
Just reporting back regarding r144 (if I am missing something in the tests please let me know):
- TVTunes allows for the use of a custom themes folder (default subdirectory name is 'Themes'). [Checked]
- Upon selecting option to support 'Themes' folder, every new theme will be downloaded to that folder only. [Checked]
- TVTunes creates the 'Themes' folder automatically when downloading a theme. [Checked]
- TVTunes will only play themes located within the 'Themes' folder. If no theme is found in there, TVTunes will fallback to the parent folder and play any theme found in there.[Checked]
Obs: If during playback of a theme located in the parent folder, one drops a theme in the 'Themes' folder, TVTunes will switch on-the-wing (literally) to play the latter. That is pretty impressive, uh? I am wondering how many checks TvTunes does to achieve such responsiveness.
My gratitude and support as always.
Obs.: Tested on XBMC 12.2, Confluence (Frodo), OS X 10.8.4
RE: TvTunes Addon - TV Show Theme Music while browsing - robwebset - 2013-12-08
(2013-12-08, 02:44)capfuturo Wrote: Obs: If during playback of a theme located in the parent folder, one drops a theme in the 'Themes' folder, TVTunes will switch on-the-wing (literally) to play the latter. That is pretty impressive, uh? I am wondering how many checks TvTunes does to achieve such responsiveness.
Thanks Jav for verifying that.
Yes, the way that TvTunes works is that it is started when certain pages are loaded - then loops (a few times a second) to see if the location or available themes has changed - if it has, then it will start playing the new theme.
It's this mechanism that means it would be a bit risky to change the behaviour on "playing a Sample download themes" and not replacing the theme (where it doesn't start the old theme again). This is because the looping code is looking for "changes" - and in this case nothing has changed. There could have been many reasons the theme stopped (other than the download scenario) like the playing reaching the time limit, the screensaver starting, the user pressing the stop button to end the theme playing - so it can't just start the theme up again if it is not playing.
Thanks, Rob
RE: TvTunes Addon - TV Show Theme Music while browsing - tinybutstrong - 2013-12-10
Using auto download, the add-on saved the theme for Homeland in follow path:
Code:
x:\myCustomThemesFolder\Homeland\Seguranca Nacional\theme.mp3This is wrong, no? The theme isn't playing.
In TVDB, the PT title is "Homeland / Segurança Nacional". How I should rename the folder to work in xbmc? " / " isn't a valid char to be used in folder name.
Thanks.
RE: TvTunes Addon - TV Show Theme Music while browsing - robwebset - 2013-12-10
Hi tinybutstrong,
Please can you try the following patch and see if it solves it:
http://code.google.com/p/robwebset/source/detail?r=146
Unfortunately I haven't managed to test it - so fingers crossed!
Rob
RE: TvTunes Addon - TV Show Theme Music while browsing - tinybutstrong - 2013-12-10
Tested the patch, now the folder name is good: "Homeland - Seguranca Nacional".
The theme isn't playing on XBMC though, but I'll not consider it a bug yet, cuz I still using the Nightly build. Anyway here is a debug log if you are interested:
http://xbmclogs.com/show.php?id=95611 I have found nothing relevant there.
After to focus Homeland in library list all series themes stop to work.
RE: TvTunes Addon - TV Show Theme Music while browsing - robwebset - 2013-12-10
Thanks, it is actually a bug! - I'm out tonight - but will look at it again when I get a minute.
Rob
RE: TvTunes Addon - TV Show Theme Music while browsing - robwebset - 2013-12-10
Noticed I blatted previous changes in the last patch, new change:
http://code.google.com/p/robwebset/source/detail?r=147
Again - sorry - but not tested - don't think it will fix the playing issue (only a very slim chance) - will look at it closer tomorrow if I get any time.
Rob