Kodi DSPlayer – DirectShow Player for Windows - Printable Version +- Kodi Community Forum (https://forum.kodi.tv) +-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33) +--- Forum: General Support (https://forum.kodi.tv/forumdisplay.php?fid=111) +---- Forum: Windows (https://forum.kodi.tv/forumdisplay.php?fid=59) +---- Thread: Kodi DSPlayer – DirectShow Player for Windows (/showthread.php?tid=223175) Pages:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
|
RE: Kodi DSPlayer – DirectShow Player for Windows - fandangos - 2019-11-12 Well, it was successfully merged: https://github.com/fandangos2/xbmc Compiling is a whole other story. RE: Kodi DSPlayer – DirectShow Player for Windows - oldpainless - 2019-11-12 I know people will appreciate the effort. RE: Kodi DSPlayer – DirectShow Player for Windows - fandangos - 2019-11-12 Tried to compile and of course it needs a lot of work. The good part is that now it's on github anyone can download, try to compile and work on it. I've started with small fixes and I encourage anyone to do so. RE: Kodi DSPlayer – DirectShow Player for Windows - mclingo - 2019-11-12 i'd love to help but i have zero knowedge in the area, happy to make a donation if you can get this working. RE: Kodi DSPlayer – DirectShow Player for Windows - Warner306 - 2019-11-12 (2019-11-12, 16:22)fandangos Wrote: Tried to compile and of course it needs a lot of work. What isn't working after merging? Do you think you made a mistake when correcting some of the merge conflicts or are there new bugs that weren't there previously? Or it wouldn't compile after merging? Even if you can't get it working, you small effort is appreciated. RE: Kodi DSPlayer – DirectShow Player for Windows - fandangos - 2019-11-12 (2019-11-12, 20:39)Warner306 Wrote:It's giving tons of errors to compile.(2019-11-12, 16:22)fandangos Wrote: Tried to compile and of course it needs a lot of work. After you solve 600 merge conflicts (which I wouldn't say is small but to each their own) by hand there are still a lot of work to do. Merging without any problems just means part of the code, or previews github commits are not conflicting with each other. All changelogs where having merge conflicts because they would have a lot of code on top of the existing in DSPlayer file and could have something like "delete first line", which would result in a conflict. Hard to explain but easy to understand in pratice. I'll give one example of a error that prevents it to compile: This commit I made today solved one error: https://github.com/fandangos2/xbmc/commit/0f462add093296ffa376c870f703868d20c3585d add_platform_override does not exist in CMake anymore. That means it merged sucessfuly but the code doesn't exist and are not used by kodi anymore. Fixing unneded stuff is quite easy, you just look at the error and follow the line and just understand that this isn't necessary anymore based on the code used by team kodi today. The hardest part is translation. Many and I mean many ways to call a function changed or became part of something else. When working on the code I've see something like gWindowing becoming Windowing:omething. So everytime DSPlayer calls this kind of function or some left over from Krypton is present you need to delete it (in case of old Krypton stuff) or translate to what is used today hopefully the function would still exist but with a different name. And finally DSPlayer have several files of it's own, that means that if Krypton code is updated by the merge, those are not, so all old function names and classes and such need to be updated or translated. By the way, as I've stated several times I'm no experient dev so maybe I'm using wrong terms and such but this is how I understand the work that still needs to be done. RE: Kodi DSPlayer – DirectShow Player for Windows - ashlar - 2019-11-12 fandangos, thank you so much. Seeing some movement on this is making me happy. Crossing all fingers here (which made typing this quite hard ) . RE: Kodi DSPlayer – DirectShow Player for Windows - Warner306 - 2019-11-13 Sounds promising. It should be interesting to see if the player will play anything if it compiles. RE: Kodi DSPlayer – DirectShow Player for Windows - ausvette - 2019-11-13 (2019-11-12, 10:43)oldpainless Wrote:(2019-11-11, 22:47)ashlar Wrote: I will send you $100 through PayPal. It's a promise. I will also match that. RE: Kodi DSPlayer – DirectShow Player for Windows - sp90378 - 2019-11-13 This would be amazing! If only I knew how to do this stuff, but unlike some of my family, coding is not my forte at all. Will try to match the others as well. If only Kodi put official resources into it for proper native HDR support (passthrough). RE: Kodi DSPlayer – DirectShow Player for Windows - fandangos - 2019-11-13 (2019-11-13, 17:15)sp90378 Wrote: This would be amazing! If only I knew how to do this stuff, but unlike some of my family, coding is not my forte at all. Will try to match the others as well. If only Kodi put official resources into it for proper native HDR support (passthrough).You can get HDR passthrough with my build here: https://forum.kodi.tv/showthread.php?tid=345566 Works for Nvidia and AMD. RE: Kodi DSPlayer – DirectShow Player for Windows - sp90378 - 2019-11-13 (2019-11-13, 17:19)fandangos Wrote:(2019-11-13, 17:15)sp90378 Wrote: This would be amazing! If only I knew how to do this stuff, but unlike some of my family, coding is not my forte at all. Will try to match the others as well. If only Kodi put official resources into it for proper native HDR support (passthrough).You can get HDR passthrough with my build here: How would you say it compares to this build with DSPlayer/MadVR? So running DSPlayer with Plex app through Kodi seems to check all the boxes off for me, and it looks fantastic. Set it to much better settings to upscale older movies to use my GTX1080 to a more full capacity. Just wish it was on a newer version is all. RE: Kodi DSPlayer – DirectShow Player for Windows - fandangos - 2019-11-13 (2019-11-13, 20:38)sp90378 Wrote:(2019-11-13, 17:19)fandangos Wrote:(2019-11-13, 17:15)sp90378 Wrote: This would be amazing! If only I knew how to do this stuff, but unlike some of my family, coding is not my forte at all. Will try to match the others as well. If only Kodi put official resources into it for proper native HDR support (passthrough).You can get HDR passthrough with my build here: Madvr is a much more capable renderer. I would say one of the best if not the best one. So if DSPlayer is working for you, just stick with it. My fork just adds hdr passthrough to a normal kodi. To others, I'll soon delete the github fork that was merged, it did not work as I hopped. So I'm changing the strategy to port DSPlayer to Kodi 19. Luckly Aracnoz was very organized with his code making my life easier RE: Kodi DSPlayer – DirectShow Player for Windows - lightsout - 2019-11-13 (2019-11-13, 20:56)fandangos Wrote:That would be pretty sweet, thankful for the work you have been doing lately.(2019-11-13, 20:38)sp90378 Wrote:(2019-11-13, 17:19)fandangos Wrote: You can get HDR passthrough with my build here: RE: Kodi DSPlayer – DirectShow Player for Windows - ashlar - 2019-11-13 (2019-11-13, 03:54)ausvette Wrote:And it would be a sweet $300 (and counting, hopefully).(2019-11-12, 10:43)oldpainless Wrote:(2019-11-11, 22:47)ashlar Wrote: I will send you $100 through PayPal. It's a promise. fandangos, may the force be with you! |