+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: General Support (https://forum.kodi.tv/forumdisplay.php?fid=111)
+---- Forum: Windows (https://forum.kodi.tv/forumdisplay.php?fid=59)
+---- Thread: Kodi DSPlayer – DirectShow Player for Windows (/showthread.php?tid=223175)
Pages:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
RE: Kodi DSPlayer – DirectShow Player for Windows - Warner306 - 2019-11-14
(2019-11-13, 20:56)fandangos Wrote:(2019-11-13, 20:38)sp90378 Wrote:(2019-11-13, 17:19)fandangos Wrote: You can get HDR passthrough with my build here:
https://forum.kodi.tv/showthread.php?tid=345566
Works for Nvidia and AMD.
How would you say it compares to this build with DSPlayer/MadVR? So running DSPlayer with Plex app through Kodi seems to check all the boxes off for me, and it looks fantastic. Set it to much better settings to upscale older movies to use my GTX1080 to a more full capacity. Just wish it was on a newer version is all.
Madvr is a much more capable renderer. I would say one of the best if not the best one.
So if DSPlayer is working for you, just stick with it.
My fork just adds hdr passthrough to a normal kodi.
To others, I'll soon delete the github fork that was merged, it did not work as I hopped.
So I'm changing the strategy to port DSPlayer to Kodi 19.
Luckly Aracnoz was very organized with his code making my life easier
That sucks. Don't kill yourself over this. The carrot of being paid for this is intriguing, but there must be some underlying reason aracnoz gave up on doing annual merges of DSPlayer when he only had 600 commits to worry about.
RE: Kodi DSPlayer – DirectShow Player for Windows - fandangos - 2019-11-14
(2019-11-14, 02:32)Warner306 Wrote:(2019-11-13, 20:56)fandangos Wrote:(2019-11-13, 20:38)sp90378 Wrote: How would you say it compares to this build with DSPlayer/MadVR? So running DSPlayer with Plex app through Kodi seems to check all the boxes off for me, and it looks fantastic. Set it to much better settings to upscale older movies to use my GTX1080 to a more full capacity. Just wish it was on a newer version is all.
Madvr is a much more capable renderer. I would say one of the best if not the best one.
So if DSPlayer is working for you, just stick with it.
My fork just adds hdr passthrough to a normal kodi.
To others, I'll soon delete the github fork that was merged, it did not work as I hopped.
So I'm changing the strategy to port DSPlayer to Kodi 19.
Luckly Aracnoz was very organized with his code making my life easier
That sucks. Don't kill yourself over this. The carrot of being paid for this is intriguing, but there must be some underlying reason aracnoz gave up on doing annual merges of DSPlayer when he only had 600 commits to worry about.
You are getting this wrong.
600 commits or more or less doesn't mean more or less work. That's not how this works.
And I'm not doing for the money. I haven't open donations till recently for kodi hdr and I'm working on it since the beggining of the year.
I'm doing this because I want everyone with a pc to have the best player that can play everything in the best possible way. Hope I can accomplish this.
Having a player with the best GUI, that have the best renderer and if it could also support libbluray too would great enough to retire players like the oppo
RE: Kodi DSPlayer – DirectShow Player for Windows - Warner306 - 2019-11-14
Alright, sounds noble to me. I will be of course hopeful like many here that you can figure out a way to make DSPlayer work with new versions of Kodi.
RE: Kodi DSPlayer – DirectShow Player for Windows - ashlar - 2019-11-15
(2019-11-14, 03:28)fandangos Wrote: You are getting this wrong.@fandangos let me just say that the reason I bolded, above, convinces me even more of the opportunity of doing the right thing in pledging some money towards this. I've never thought you were doing it for the money, I've never thought my position being "we're hiring fandangos to do this". I simply would wish to recognize such a noble endeavour and I guess the others who have pledged feel the same way.
600 commits or more or less doesn't mean more or less work. That's not how this works.
And I'm not doing for the money. I haven't open donations till recently for kodi hdr and I'm working on it since the beggining of the year.
I'm doing this because I want everyone with a pc to have the best player that can play everything in the best possible way. Hope I can accomplish this.
Having a player with the best GUI, that have the best renderer and if it could also support libbluray too would great enough to retire players like the oppo
I feel too old to start learning because every fibre of my being would love, absolutely love, to help you out, spending hours working on this and testing it until it works. Since I am unable to do that, money is the only way I feel I can contribute.
An heartfelt thank you for at least trying.
RE: Kodi DSPlayer – DirectShow Player for Windows - ausvette - 2019-11-16
(2019-11-15, 19:55)ashlar Wrote:Yes for sure I felt the same way making my pledge.(2019-11-14, 03:28)fandangos Wrote: YYou are getting this wrong.@fandangos let me just say that the reason I bolded, above, convinces me even more of the opportunity of doing the right thing in pledging some money towards this. I've never thought you were doing it for the money, I've never thought my position being "we're hiring fandangos to do this". I simply would wish to recognize such a noble endeavour and I guess the others who have pledged feel the same way.
600 commits or more or less doesn't mean more or less work. That's not how this works.
And I'm not doing for the money. I haven't open donations till recently for kodi hdr and I'm working on it since the beggining of the year.
I'm doing this because I want everyone with a pc to have the best player that can play everything in the best possible way. Hope I can accomplish this.
Having a player with the best GUI, that have the best renderer and if it could also support libbluray too would great enough to retire players like the oppo
I feel too old to start learning because every fibre of my being would love, absolutely love, to help you out, spending hours working on this and testing it until it works. Since I am unable to do that, money is the only way I feel I can contribute.
An heartfelt thank you for at least trying.
RE: Kodi DSPlayer – DirectShow Player for Windows - oldpainless - 2019-11-16
Same here.
RE: Kodi DSPlayer – DirectShow Player for Windows - IT007 - 2019-11-16
Yeah, regardless of the end result, all the work going in to this is much appreciated.
RE: Kodi DSPlayer – DirectShow Player for Windows - Runakanta - 2019-11-18
Hello can someone help me to get
This
To work in Kodi? I'm using the DSPlayer version 17.6
RE: Kodi DSPlayer – DirectShow Player for Windows - spencerjford - 2019-11-18
(2019-11-18, 08:08)Runakanta Wrote: Hello can someone help me to get
This
To work in Kodi? I'm using the DSPlayer version 17.6
Madvr, I believe, bypasses that on purpose.
RE: Kodi DSPlayer – DirectShow Player for Windows - Warner306 - 2019-11-18
(2019-11-18, 08:08)Runakanta Wrote: Hello can someone help me to getThose video shaders should only work if you choose DXVA2 for image upscaling. The AMD video shader settings are only intended for video rendering carried out by the GPU video rendering pipeline and not the GPU shaders used by madVR. madVR might even bypass them when DXVA2 is selected. I don't know.
This
To work in Kodi? I'm using the DSPlayer version 17.6
RE: Kodi DSPlayer – DirectShow Player for Windows - Runakanta - 2019-11-18
(2019-11-18, 08:24)spencerjford Wrote:Yay thankyou, changing to Enhanced Video Rendering solved the problem ovo(2019-11-18, 08:08)Runakanta Wrote: Hello can someone help me to get
This
To work in Kodi? I'm using the DSPlayer version 17.6
Madvr, I believe, bypasses that on purpose.
RE: Kodi DSPlayer – DirectShow Player for Windows - namtih - 2019-11-19
(2019-11-13, 20:56)fandangos Wrote: To others, I'll soon delete the github fork that was merged, it did not work as I hopped.Is it perhaps easier to implement mpv or it's library?
So I'm changing the strategy to port DSPlayer to Kodi 19.
https://mpv.io/
https://github.com/haasn/libplacebo
RE: Kodi DSPlayer – DirectShow Player for Windows - ashlar - 2019-11-20
(2019-11-19, 17:40)namtih Wrote:The idea has been, for a long time, to be able to use madVR, due to it being the most advanced renderer available currently for HTPCs. I'm not sure that having mpv would warrant the effort needed. mpv might probably be a good choice for Kodi, overall, if there was interest in playback engine (as it offers multiplatform support for Windows, Mac, Linux, Android). But I think, at that point, an "easier" solution might be to implement some more advanced resizers in the existing engine.(2019-11-13, 20:56)fandangos Wrote: To others, I'll soon delete the github fork that was merged, it did not work as I hopped.Is it perhaps easier to implement mpv or it's library?
So I'm changing the strategy to port DSPlayer to Kodi 19.
https://mpv.io/
https://github.com/haasn/libplacebo
Let's give fandangos the time he needs to evaluate the different possibilities and approaches.
RE: Kodi DSPlayer – DirectShow Player for Windows - fandangos - 2019-11-20
Just an update, I'm halting the DSPlayer project for now for a few reasons:
1. I have my final graduation presentation this week so I'm working on Kodi on my spare time and after this presentation I'll need to finalize the papers to conclude my graduation.
2. DSPlayer doesn't support Libbluray at all, this is really a bummer to me, as I've said several times I would like to give people a choice to use iso or bdmv for uhd content that would not require expensive software (actually there's today no satisfactory player that can do this).
So it would require porting DSPlayer and later adding the VideoPlayer portion of interaction with libbluray to it. We are talking about a lot of work and not sure if I can do it. Again not sure if I can do the DSplayer project.
3. A L O T of the code where DSPlayer hooks to changed, moved it's place and such. So the strategy I'm doing is, I've found every single DSPlayer code portion outside the DSPlayer folder, that was easy because Aracnoz stated everything with "#ifdef HAS_DS_PLAYER", and taking this code and pasting into the correct place.
This is a manual job (that's why merging solves nothing and I've deleted the git) and not just parts of the code change it's place within the same file it sometimes change to another file so I have to look into it, search for some string that might be similar and such..
As you can see this is very boring and I'm doing a few files per day.
4. I decided to try to fix the libbluray problems with my own fork. Blurays work flawlessly with libbluray 1.1.2 with my fork but UHD does not.
There are a few bugs like the chapters not working, skipping chapters using the arrow keys, seeking in the timeline and green background menus.
I REALLY would like to fix this and that's actually what I'm looking into right now.
If I end up not being able to fix those, I'll dedicate my full attention to DSPlayer but right now, I'm working on it because if those bugs are solved we are looking at a fully compatible UHD BD player and that is a really awesome thing, at least, for me.
RE: Kodi DSPlayer – DirectShow Player for Windows - mclingo - 2019-11-20
No worries, thanks for all the work you're already put in and good luck with your Graduation presentation !