Kodi Community Forum
[Closed] TvTunes Addon - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Support (https://forum.kodi.tv/forumdisplay.php?fid=33)
+--- Forum: Add-on Support (https://forum.kodi.tv/forumdisplay.php?fid=27)
+---- Forum: Program Add-ons (https://forum.kodi.tv/forumdisplay.php?fid=151)
+---- Thread: [Closed] TvTunes Addon (/showthread.php?tid=83925)



RE: [RELEASE] TvTunes Addon - TV Show Theme Music while browsing - nickr - 2013-09-13

(2013-09-13, 05:36)rob_webset Wrote:
(2013-09-13, 02:36)Legion455 Wrote: I couldn't find any errors to my changes in the py file,... so I turned on debug logging,.. and got a "exceptions.indentationerror", "unindent does not match any outer indentation level"

if anyone has any ideas about this,...
thanks
Legion

Hi Legion, White space is important in python - so you will need to make sure that it all the indentation is correct.

I did originally create a patch file, but thought that it was hard to read for posting what I had done - infortunately when I posted the section from the file, it removed all whitespace

Patch file/diff:
Post it for download somewhere, not inline here!


RE: [RELEASE] TvTunes Addon - TV Show Theme Music while browsing - robwebset - 2013-09-13

(2013-09-13, 07:20)nickr Wrote: Post it for download somewhere, not inline here!

Some instructions:

1) Open text editor
2) Select all text in diff
3) Paste in text editor

Sorry! - couldn't resist it! :-)


RE: [RELEASE] TvTunes Addon - TV Show Theme Music while browsing - nickr - 2013-09-13

We all appreciate your efforts, but the forum is not a software repository.


RE: [RELEASE] TvTunes Addon - TV Show Theme Music while browsing - Martijn - 2013-09-13

(2013-09-13, 08:12)nickr Wrote: We all appreciate your efforts, but the forum is not a software repository.

agreed. use pastebin.com or whatever. keep the forum clean and readable

(2013-09-13, 07:23)rob_webset Wrote:
(2013-09-13, 07:20)nickr Wrote: Post it for download somewhere, not inline here!

Some instructions:

1) Open text editor
2) Select all text in diff
3) Paste in text editor

Sorry! - couldn't resist it! :-)

Some instructions
1) open pastebin.com
2) put all the code there
3) paste the link to the forum.


Sorry! - couldn't resist it! :-)


RE: [RELEASE] TvTunes Addon - TV Show Theme Music while browsing - Wanilton - 2013-09-13

@rob_webset, work perfect, amazing job.


RE: [RELEASE] TvTunes Addon - TV Show Theme Music while browsing - robwebset - 2013-09-13

(2013-09-12, 21:12)ronie Wrote: i've probably mentioned it before (a long time ago), but the offer still stands...
if anyone is willing to maintain the addon from now on, i'm all for it.
i'm sure it'll be in better hands with someone who's interested, unlike me, in adding new features.

Doesn't sound like people are rushing forward to maintain this!

I may be able to do a few updates here and there as needed. What exactly would be the expectation for TvTunes. I notice that it is in the main XBMC Add-ons repository.

If some-one can detail the following:
1) How are requests currently made to get additions to existing skins (I notice it is already build into several skins)
2) How are translations done - I don't know many languages!
3) Are there a set of verification testers? (If not do we have any volunteers?)

I now have a public google repo that I could add this to if we were to migrate this.
https://code.google.com/p/robwebset/

Thoughts, comments?

Rob


RE: [RELEASE] TvTunes Addon - TV Show Theme Music while browsing - ronie - 2013-09-13

(2013-09-13, 15:33)rob_webset Wrote:
(2013-09-12, 21:12)ronie Wrote: i've probably mentioned it before (a long time ago), but the offer still stands...
if anyone is willing to maintain the addon from now on, i'm all for it.
i'm sure it'll be in better hands with someone who's interested, unlike me, in adding new features.

Doesn't sound like people are rushing forward to maintain this!

I may be able to do a few updates here and there as needed. What exactly would be the expectation for TvTunes. I notice that it is in the main XBMC Add-ons repository.

If some-one can detail the following:
1) How are requests currently made to get additions to existing skins (I notice it is already build into several skins)
2) How are translations done - I don't know many languages!
3) Are there a set of verification testers? (If not do we have any volunteers?)

I now have a public google repo that I could add this to if we were to migrate this.
https://code.google.com/p/robwebset/

Thoughts, comments?

Rob

1) if you make changes to the tvtunes addon that also requires a change in the skins that are supporting the addon,
you should post a headsup in the skin-dev forum: http://forum.xbmc.org/showthread.php?tid=147285&page=57
2) transifex http://forum.xbmc.org/showthread.php?tid=141158
3) nope, just post a beta version here, and if no bugs are reported, you can submit it to the addon repo.


RE: [RELEASE] TvTunes Addon - TV Show Theme Music while browsing - robwebset - 2013-09-13

(2013-09-13, 15:38)ronie Wrote: 1) if you make changes to the tvtunes addon that also requires a change in the skins that are supporting the addon,
you should post a headsup in the skin-dev forum: http://forum.xbmc.org/showthread.php?tid=147285&page=57
2) transifex http://forum.xbmc.org/showthread.php?tid=141158
3) nope, just post a beta version here, and if no bugs are reported, you can submit it to the addon repo.

Doesn't sound too bad! For item 1, did you mean the following link?
http://forum.xbmc.org/forumdisplay.php?fid=12

Let me know if you did want me to get involved and if so, how you wanted me to go about it.

Thanks

Rob


RE: [RELEASE] TvTunes Addon - TV Show Theme Music while browsing - ronie - 2013-09-13

(2013-09-13, 15:50)rob_webset Wrote: Doesn't sound too bad! For item 1, did you mean the following link?
http://forum.xbmc.org/forumdisplay.php?fid=12
correct :-)

(2013-09-13, 15:50)rob_webset Wrote: Let me know if you did want me to get involved and if so, how you wanted me to go about it.
well sure, if you're interested in developping/maintaining this addon, i'd would welcome it.

first thing you'd need to do is upload your modified version of tvtunes to your google repo.
next, provide a zipfile of the addon here, so users can test it for a while.
meanwhile, submit the addon to transifex, so people can update the traslations:
http://forum.xbmc.org/showthread.php?tid=142736
final step would be to submit the addon to the xbmc addon repo:
http://wiki.xbmc.org/index.php?title=Official_add-on_repository#Submitting_a_Compliant_Add-on_to_the_XBMC.org_Repo


RE: [RELEASE] TvTunes Addon - TV Show Theme Music while browsing - Legion455 - 2013-09-13

I finally figured out to use patch.exe and apply the changes, thank man. Although I did get an error "patch unexpectedly ends in middle of line",... I checked the py file, and everything looked good,...
so I copied over the new file,... uninstalled dvdExtras, .. changed the DialogVideo file,...
and now ... I'm getting theme music being played both in the TV details screens, and the Movie Details screens. Whoot! Smile

thanks again, ... +1s all around!!! Wink

Legion


RE: TvTunes Addon - TV Show Theme Music while browsing - ronie - 2013-09-18

thread closed, please continue here:
http://forum.xbmc.org/showthread.php?tid=173799