Changes to skinning engine for Eden (and beyond)

  Thread Rating:
  • 1 Votes - 5 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
Hitcher Offline
Skilled Skinner
Posts: 11,027
Joined: Aug 2007
Reputation: 103
Location: Eastleigh, UK
Post: #76
I missed that one as well.

Cheers.
find quote
pecinko Offline
Donor
Posts: 3,835
Joined: Dec 2008
Reputation: 52
Location: Prague / Belgrade
Post: #77
Jeroen Wrote:Rollback button added to DialogAddonInfo.xml
Not sure when it was added, just noticed it today. ID=11, string=24048


@all
If you happen to think that label "Versions" would be more suitable for non technical users I made a ticket here.

My skins:

Amber
Quartz

find quote
ronie Offline
Team-Kodi Member
Posts: 9,402
Joined: Jan 2009
Reputation: 165
Post: #78
i think we need to start a heads-up thread after eden, where we collect all changes to the skinning engine.

i usually check git commits daily and update the skinning pages on the wiki as needed, might as well post the info in a thread here as well.

Always read the Kodi online-manual, FAQ and search the forum before posting.
Do not PM or e-mail Team-Kodi members directly asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting please make sure you read this first.
find quote
pecinko Offline
Donor
Posts: 3,835
Joined: Dec 2008
Reputation: 52
Location: Prague / Belgrade
Post: #79
ronie Wrote:...might as well post the info in a thread here as well.

I would be grateful. I'm out of town occasionally and it is easy to overlook change so I'm thankful for one_place_reminder to help me add missing things.

My skins:

Amber
Quartz

find quote
pecinko Offline
Donor
Posts: 3,835
Joined: Dec 2008
Reputation: 52
Location: Prague / Belgrade
Post: #80
Skin.String(string) Returns whether the skin string (set via Skin.SetString, Skin.SetPath, or Skin.SetImage) is non-empty.

was changed to IsEmpty(Skin.String(string)). Don't know if it applies to paths and images.

My skins:

Amber
Quartz

find quote
Balinus Offline
Skilled Skinner
Posts: 1,121
Joined: Jul 2011
Reputation: 19
Location: Montréal
Post: #81
Hello! Real noob in skinning right now, but I have this little project of updating to Eden the skin made by igotdvds "Shade".

To make the skin Eden "certified", do I need to do all the things listed in the 1st post and "that's it"?
find quote
ronie Offline
Team-Kodi Member
Posts: 9,402
Joined: Jan 2009
Reputation: 165
Post: #82
(2012-03-14 19:47)Balinus Wrote:  Hello! Real noob in skinning right now, but I have this little project of updating to Eden the skin made by igotdvds "Shade".

To make the skin Eden "certified", do I need to do all the things listed in the 1st post and "that's it"?

heh, no you don't need to do all of that and maybe you need to do some things that aren't listed.
basically, identify the parts that are currently broken and fix those.

point 1.1 (ignore the music bit, that hasn't been implemented yet) and 1.3 you should look into though.

Always read the Kodi online-manual, FAQ and search the forum before posting.
Do not PM or e-mail Team-Kodi members directly asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting please make sure you read this first.
find quote
Balinus Offline
Skilled Skinner
Posts: 1,121
Joined: Jul 2011
Reputation: 19
Location: Montréal
Post: #83
(2012-03-14 19:52)ronie Wrote:  
(2012-03-14 19:47)Balinus Wrote:  Hello! Real noob in skinning right now, but I have this little project of updating to Eden the skin made by igotdvds "Shade".

To make the skin Eden "certified", do I need to do all the things listed in the 1st post and "that's it"?

heh, no you don't need to do all of that and maybe you need to do some things that aren't listed.
basically, identify the parts that are currently broken and fix those.

point 1.1 (ignore the music bit, that hasn't been implemented yet) and 1.3 you should look into though.

ah! Thanks! This reduce a lot of the upcoming work... Smile

i'll look into point 1.1 and 1.3 then! Thanks again.
find quote
JohnWPB Offline
Senior Member
Posts: 215
Joined: Dec 2008
Reputation: 3
Location: West Palm Beach, Florida
Post: #84
Not sure if this was intended as a request thread, but I see a lot of em... so here goes Smile

Is there a way to add a "hook" into the XBMC core, so a single command could be used to play a trailer? This would allow a button mapped on a remote control to play a trailer for the selected title with just a simple press. As it stands right now, the only way to do it is with skin commands, then a button on the screen is pressed.

I had been doing this a really dirty way, by using event Ghost to press i (Info) then a [cursor down] then then [enter]. Like I said, dirty code to say the least. I have moved away from using Event Ghost, with the new MCE remote commands built right in.

------------------------------------------
Atom Dual core 2.8 Ghz / Windows 7 Pro / 4 gigs ram 6.5 Tb storage / Nvidia 9400M Gfx chipset / Output 1920 x 1080p via HDMI to a 52" LED TV / just over 3,400 movies

Have you entered your 5 Movies? - Support themoviedb.org as THE best open source movie information site.
find quote
phil65 Offline
Skilled Skinner
Posts: 4,875
Joined: Mar 2009
Reputation: 67
Location: Cologne, Germany
Post: #85
(2012-07-07 09:25)JohnWPB Wrote:  Not sure if this was intended as a request thread, but I see a lot of em... so here goes Smile

Is there a way to add a "hook" into the XBMC core, so a single command could be used to play a trailer? This would allow a button mapped on a remote control to play a trailer for the selected title with just a simple press. As it stands right now, the only way to do it is with skin commands, then a button on the screen is pressed.

I had been doing this a really dirty way, by using event Ghost to press i (Info) then a [cursor down] then then [enter]. Like I said, dirty code to say the least. I have moved away from using Event Ghost, with the new MCE remote commands built right in.

yes, put PlayMedia($ESCINFO[ListItem.Trailer]) into your keymap. wrong thread though..
(This post was last modified: 2012-07-07 09:48 by phil65.)
find quote
JohnWPB Offline
Senior Member
Posts: 215
Joined: Dec 2008
Reputation: 3
Location: West Palm Beach, Florida
Post: #86
(2012-07-07 09:43)phil65 Wrote:  yes, put PlayMedia($ESCINFO[ListItem.Trailer]) into your keymap. wrong thread though..

@phil65: First, thanks for the help, second, sorry for the wrong thread, but may as well try to finish it up here and keep it in one place at least.

I tried the line you provided above, and something in the syntax or something is not working. I am using my debugging .xml for testing:

Code:
<keymap>
    <global>
        <keyboard>
            <F5>XBMC.ReloadSkin()</F5>
            <F6>Skin.ToggleSetting(DebugGrid)</F6>
            <F7>Skin.ToggleSetting(HideDebugInfo)</F7>
            <F8>Notification(Test Message:,Dialog Box Test)</F8>
       [b]<F3>PlayMedia($ESCINFO[ListItem.Trailer])</F3>[/b]
        </keyboard>
    </global>
</keymap>

When I press F8, I get my test message. When I go into "Movies", and hi-lite a movie in the list with a trailer, and press F3, nothing happens.

I also tried a couple variations on syntax, and code in the skins:

<F3>PlayMedia($INFO[ListItem.Trailer])</F3>
<F3>PlayMedia(&quot;$INFO[ListItem.Trailer]&quot;,1)</F3>

Still nothing..... Any other suggestions?

------------------------------------------
Atom Dual core 2.8 Ghz / Windows 7 Pro / 4 gigs ram 6.5 Tb storage / Nvidia 9400M Gfx chipset / Output 1920 x 1080p via HDMI to a 52" LED TV / just over 3,400 movies

Have you entered your 5 Movies? - Support themoviedb.org as THE best open source movie information site.
(This post was last modified: 2012-07-08 06:49 by JohnWPB.)
find quote
Post Reply