2016-09-20, 21:59
Just came across this and it's great! I just wish this would've been around a while ago! Any chance you could add custom path support to clean already downloaded subtitles??
(2016-09-20, 22:06)DaLanik Wrote: Hmm, shouldn't be too hard, just have to think of a way to open file selector window....
(2016-09-27, 01:31)Fail$tyle420 Wrote: Awesome! The new version works great! What would be the best method to update the database/definitions? Also, what file holds the definitions?
*EDIT* NVM, I found cleanupstrings.txt I will be creating 2 files, one that removes ads, the other one will remove ads and credits. Some people will like either or. Should I just post it here or upload the txt file somewhere?
(2016-09-27, 01:31)Fail$tyle420 Wrote: Here is my take and a problem:
1. Can you update the first post with some kind of disclaimer about it asking for the entire video library and custom path. No big deal to me since I reverted all changes, but answering the first question I assumed it was going to process my custom path only (Yes, even though it did say VIDEOS LIBRARY lol). Maybe I'll be the only dense person here to not figure it out who knows.
(2016-09-27, 01:31)Fail$tyle420 Wrote: 2. Now, I'm assuming that when I said yes originally to the first question that everything went fine. It appeared to process all of my files. After changing the settings to definition only and choosing my custom path only, the scan aborts EVERY time at this movie:
Alien³ (Director's Cut) (1992) (Bluray)
(2016-09-27, 01:31)Fail$tyle420 Wrote: Am I correct in assuming that whether it deletes lines or not, it will still rename the original and create a new .srt file? That would explain why I thought it had originally cleaned my already vetted files! If this is the case, could you implement a seperate log from the kodi log with only the processed subtitles?
(2016-09-27, 14:58)DaLanik Wrote: OK, I have found a way to display multiple choices (i.e. to ask whether to clean library or custom folder)... should be out tomorrow....
(2016-09-27, 22:55)DaLanik Wrote: I took a look at the code and it DOES re-create all subtitle files, no matter if it found something to clean or not. The original and resulting file(s) should be the same +/- some extra CR/LF could be stripped etc.
I could pretty easily prevent script from saving the titles which have no lines cleaned. I'd prefer that to creating the log? Is the log better solution for you than not creating files that were not cleaned?