2011-04-30, 20:01
Hello all,
when I started a few months ago using xbmc, I was wondering, that fanarts and cover in my mixed movie nfos are not recognized (fanarts) or not used as the default cover.
Having a deeper look in the sources I found a bug in NFO handling and a design mistake in mixed movie nfos.
Bug in fanart handling:
in CVideoInfoTag:arseNative(..)
m_fanart.m_xml << *fanart;
This is not working, as for mixed mode nfos m_xml is always filled from scrapers. In that case a further <fanart> block is added to a string (m_xml ) which already contains a <fanart> block. This does not work.
In addition: The fanart definition is added to the end, which means, that scraper fanarts will be used and nfo fanarts will not be used as the default fanart
For cover (thumbs) this is similar: nfo thumbs will be added to the end, therefor nfo thumbs will not be used as the default cover.
I will submit a patch later, which will remove the bug and will add nfo fanart/cover to the top of the fanart/cover list , so they are used as default.
when I started a few months ago using xbmc, I was wondering, that fanarts and cover in my mixed movie nfos are not recognized (fanarts) or not used as the default cover.
Having a deeper look in the sources I found a bug in NFO handling and a design mistake in mixed movie nfos.
Bug in fanart handling:
in CVideoInfoTag:arseNative(..)
m_fanart.m_xml << *fanart;
This is not working, as for mixed mode nfos m_xml is always filled from scrapers. In that case a further <fanart> block is added to a string (m_xml ) which already contains a <fanart> block. This does not work.
In addition: The fanart definition is added to the end, which means, that scraper fanarts will be used and nfo fanarts will not be used as the default fanart
For cover (thumbs) this is similar: nfo thumbs will be added to the end, therefor nfo thumbs will not be used as the default cover.
I will submit a patch later, which will remove the bug and will add nfo fanart/cover to the top of the fanart/cover list , so they are used as default.