2011-06-21, 09:54
As covered in topic Movie scraping not working, my end or are they broken? and in ticket #11649.
Since a few weeks back, there's no way for CVideoInfoDownloader to differentiate whether a scraper fails or if just no results could be found. It simply always indicates an error when the scraper returns with an empty movielist, which would trigger a confusing error for the user "Unable to connect to remote server, continue scanning?" when scanning for changes in the library.
I've made some changes so that CVideoInfoDownloader only indicates an error if Scraper actually throws an error. The video scanner can then correctly handle both the cases when an error in the scraper occurred and when no results were found.
Since that solution involves some sizable changes, I've opened this topic to discuss if my suggested solution is a good approach. I've attached the suggested changes as a patch to ticket #11649: http://trac.xbmc.org/attachment/ticket/1...rror.patch
Since a few weeks back, there's no way for CVideoInfoDownloader to differentiate whether a scraper fails or if just no results could be found. It simply always indicates an error when the scraper returns with an empty movielist, which would trigger a confusing error for the user "Unable to connect to remote server, continue scanning?" when scanning for changes in the library.
I've made some changes so that CVideoInfoDownloader only indicates an error if Scraper actually throws an error. The video scanner can then correctly handle both the cases when an error in the scraper occurred and when no results were found.
Since that solution involves some sizable changes, I've opened this topic to discuss if my suggested solution is a good approach. I've attached the suggested changes as a patch to ticket #11649: http://trac.xbmc.org/attachment/ticket/1...rror.patch