Login at Kodi Home

**Jeroen** · 2011-07-30, 15:56

I have a button in my OSD to switch subtitles on or off. However I would like to turn this into a togglebutton and display the currently selected state.

I tried using System.GetBool(defaultvideosettings.showsubtitles) as a condition, but that doesn't seem to work. Is there a way to do this?

**Hitcher** · 2011-07-30, 16:01

I guess that doesn't work because it's also saved per video.

pieh · 2011-07-30, 16:18

So You need Boolean condition "VideoPlayer.SubtitlesEnabled" to check if currently played video has subtitles ?

**Jeroen** · (This post was last modified: 2011-07-30, 16:33 by Jeroen.)

Yes, to be more precise checking whether or not subtitles are enabled for the currently playing video. It would also be useful for positioning the OSD based on whether or not subtitles are enabled.

Maybe formatting it like VideoPlayer.HasSubtitles would be more consistent with other conditions?

pieh · 2011-07-30, 16:43

sure, that's what I meant - HasSubtitles may indicate that there are subtitles for video available (not that subtitles are actually enabled/disabled) I think, but If You will come up with better name for it, I'll use it

**Hitcher** · 2011-07-30, 16:50

Both.

HasSubtitles to hide the button

SubtitlesEnabled when they're on

pieh · 2011-07-30, 19:40

added to master - see commit description https://github.com/xbmc/xbmc/commit/79a6...9e18fc6fef

**Hitcher** · 2011-07-30, 19:43

Thanks for this and all the skin features you've added pieh.

**Jeroen** · 2011-07-31, 11:42

Great

Thanks a lot pieh, it's appreciated

**BigNoid** · 2011-07-31, 13:03

Wiki is updated.

pieh · 2011-07-31, 13:26

Thanks Big_Noid, please just mark that these aren't available in dharma so there won't be confussion and bug reports about it.