[RELEASE] INADYN Service Add-on - Simple Dynamic DNS client.

  Thread Rating:
  • 1 Vote(s) - 5 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
queeup Offline
Posting Freak
Posts: 805
Joined: Feb 2009
Reputation: 16
Post: #31
I will fix that. I will also try not to break your fix.
find quote
tatowaki Offline
Junior Member
Posts: 5
Joined: Feb 2015
Reputation: 0
Post: #32
Hi. The addon suddenly stopped working, even after several machine restarts.
I checked the kodi log and all I could find was "Service already started" when cold booted. Checked addon log and no trace since several days ago.

I saw a file named "inadyn.pid" having more or less the same date (16 Feb) than the last succesful date inadyn addon last succesfully worked.
And that was it... The machine had an expected reboot that day and the addon wrongly thought service was already running...

You should delete inadyn.pid on boot or just ignore it on boot, or the addon won't work unless you manually delete the inady.pid file if the machine hangs/reboots unexpectedly.

Regards
(This post was last modified: 2015-02-19 00:26 by tatowaki.)
find quote
queeup Offline
Posting Freak
Posts: 805
Joined: Feb 2009
Reputation: 16
Post: #33
Yes you are right. Sometimes inadyn.pid hang there and creating problem. I need to check that deeply.

For dirty fix just stop service from kodi add-on settings then erase pid file. Now you can start it again inadyn service.

I had pic cleaner code once but after inadyn developer added pid remover to inadyn I decided to remove from add-on. I think good idea to add it back just in case...
find quote
tatowaki Offline
Junior Member
Posts: 5
Joined: Feb 2015
Reputation: 0
Post: #34
Great addon btw Wink This is a must-have one for anyone having dynamic IPs and accesing remotely to the HTPC.
Thanks to your addon I can add torrents from work and so ehehehe

I'll try adding a rm command on Kodi's autoexec so it deletes the file on boot. Let's hope this prevents further problems until you update the addon.

Again, thanks for your work Wink
find quote
queeup Offline
Posting Freak
Posts: 805
Joined: Feb 2009
Reputation: 16
Post: #35
service.inadyn: updated to v2.0.10:
Code:
-RPi 2 support (thanks to @minoas)
-check if process exist. If not exist remove pid file
-better kill by pid process
find quote
minoas Offline
Junior Member
Posts: 3
Joined: Feb 2015
Reputation: 0
Post: #36
(2015-02-20 13:11)queeup Wrote:  -RPi 2 support (thanks to @minoas)

Bug report 2
Checking the diff on service.py I did notice this:

Code:
62      self.INADYN_EXEC = '%s/bin/inadyn.armv6l''

Which will translate the self.INADYN_EXEC = '%s/bin/inadyn.armv6l

I am pretty sure your intention was to replace %s with the path:

Code:
self.INADYN_EXEC = '%s/bin/inadyn.armv6l'% (__path__)
(This post was last modified: 2015-02-21 20:08 by minoas.)
find quote
queeup Offline
Posting Freak
Posts: 805
Joined: Feb 2009
Reputation: 16
Post: #37
You are rescuing my but Smile thank you.

Lol at the end I break your fix. Sorry...
find quote
queeup Offline
Posting Freak
Posts: 805
Joined: Feb 2009
Reputation: 16
Post: #38
service.inadyn: updated to v2.0.11:
Code:
-fix inadyn exec path (thanks to @minoas)
find quote
minoas Offline
Junior Member
Posts: 3
Joined: Feb 2015
Reputation: 0
Post: #39
Don't mention it I know how hard it is to develop without the hardware to test it.

With the lack of supplies on Rpi2 I don't think many people actually used my patch anyway.

You should consider changing the if statement to something like

Code:
if 'arm' in os.usname()[4]:

To make it more generic.Considering that newer boards will be using newer arm instructions that are fully compatible v6 version.
The above can only break if someone releases a board with older architecture than Pi1, which is highly unlikely.

At any rate this is not a critical change just makes it more future proof.
find quote
queeup Offline
Posting Freak
Posts: 805
Joined: Feb 2009
Reputation: 16
Post: #40
You are totally right. I should do future compatibility. I will do that in next version.

I hope everything OK for you now. Anytime you can suggest or bug report. I will be glad to hear.
find quote
queeup Offline
Posting Freak
Posts: 805
Joined: Feb 2009
Reputation: 16
Post: #41
service.inadyn: updated to v2.0.12
Code:
-arm support instead of just RPi (thanks to @minoas)
-proper way to start & stop service
-use waitForAbort instead abortRequested
-cosmetic
find quote
Post Reply