[Karlson2k]

I'm new to XBMC, correct me if I post to wrong forum!

I'm using sources from http://mirrors.xbmc.org/releases/source/...ta2.tar.gz
MiniGW lib can't be compiled: bootstrap in lib/libdvd/libdvdcss can't detect automake.
I found that

Code:

if expr "$amvers" "<" "1.5" > /dev/null 2>&1; then

don't work with 1.11.1 version of automake.
After little correction

Code:

if expr "$amvers" "<" "1.5" && expr "$amvers" "<" "1.10" > /dev/null 2>&1; then

everything was fine compiled.

[WiSo]

No bug. Compiled fine for me and billy otherwise he would have barfed on building beta 3.
Did you run DownloadMingwBuildEnv.bat to update your mingw env?

[Karlson2k]

Rechecked now (with Beta 3) and it's OK.
As I see automake is detected now in this code:

Code:

for v in 11 10 9 8 7 6 5; do
  if automake-1.${v} --version >/dev/null 2>&1; then
    amvers="-1.${v}"
    break
  elif automake1.${v} --version >/dev/null 2>&1; then
    amvers="1.${v}"
    break
  fi
done

But on my prevision try automake was detected on this part of code:

Code:

if test "${amvers}" = "no" && automake --version > /dev/null 2>&1; then
  amvers="`automake --version | sed -e '1s/[^0-9]*//' -e q`"
  if expr "$amvers" "<" "1.5" > /dev/null 2>&1; then
    amvers="no"
  else
    amvers=""
  fi
fi

I don't know why that happen, but it any case "expr" command works wrong for last portion of code.
Small test:

Code:

$ expr "1.1" "<" "1.5"
1

$ expr "1.5" "<" "1.5"
0

$ expr "1.9" "<" "1.5"
0

$ expr "1.10" "<" "1.5"
1

$ expr "1.11" "<" "1.5"
1

$ expr "1.11" "<" "1.10"
0

So code needs to be corrected!

[WiSo]

maybe it gets updated when we update the third party lib. this isn't our code. until it won't fail I see no reason for changing it.

[Karlson2k]

I could fail from time to time, like in my case.
Seems that "expr" do string comparison rather that numeric comparison so "1.11" will be smaller that "1.5".
In other words - to avoid sporadic errors it's better to polish all parts of code to make it work properly.
You just need to add '&& expr "$amvers" "<" "1.10"'.