Posts: 2,745
Joined: Oct 2003
Reputation:
1
WiSo
Team-Kodi Developer
Posts: 2,745
2013-09-05, 18:27
(This post was last modified: 2013-09-05, 18:28 by WiSo.)
@Skixbmc: The right fix imo would be to change CWIN32Util::GetProfilePath() to return a smb path (if strProfilePath is an unc path) because the translate function returns what we set in application.cpp l1205 (CSpecialProtocol::SetHomePath(strWin32UserFolder)). cpluff is a dll and thus still patched by our dll loader. That way it supports our vfs and can handle smb paths.
CUtil::GetHomePath could be handled the same. We could factor out the windows stuff to CWIN32Util::GetHomePath and make it returning a smb path if GetFullPathNameW returns an unc path (dunno what they return if xbmc lays on a share).
Posts: 89
Joined: Sep 2012
Reputation:
1
@ WiSo
Is it an id to change the code in the DirectoryFactory.cpp that instead of retuning a new CHDDirectory we return CWINSMBDirectory? IMO we can remove the specific code for windows from the HDDirectory and we can also do the same for the FileFactory.cpp.
Silverstone Grandia GD02-MT | AMD A8-3850 | Breakaway Audio Enhancer, HK AVR-365 | HKTS 30, Philips 50PFL7956H/12 21:9 3D
Posts: 2,745
Joined: Oct 2003
Reputation:
1
WiSo
Team-Kodi Developer
Posts: 2,745
No. I would like to be in line with the other platforms and separate local and smb file access.
The change in application.cpp you suggested is wrong as it again would use unc path internally which we don't want. That way an unc path could be forwarded to a dll which might not handle it (but would understand smb paths).
Posts: 2,745
Joined: Oct 2003
Reputation:
1
WiSo
Team-Kodi Developer
Posts: 2,745
As said I'm happy for every help but I don't like approaches which seems to hide the bug but not solve it. As already said I don't want to merge hd and SMb code together. What's wrong with the ideas I gave you in the previous posts?
And yes I want this solved but not at any price given that not many suffer from this bug.
Posts: 89
Joined: Sep 2012
Reputation:
1
2013-09-16, 05:52
(This post was last modified: 2013-09-16, 05:56 by Skixbmc.)
Sadly though, the loading of DLLs and add-ons as problems in the POC.
But to update the monolog, the webserver is working, next step is the loading of the environments for the dll which seem to been changed in VS2012
Silverstone Grandia GD02-MT | AMD A8-3850 | Breakaway Audio Enhancer, HK AVR-365 | HKTS 30, Philips 50PFL7956H/12 21:9 3D
Posts: 350
Joined: Oct 2010
Reputation:
10
Skixbmc, let's keep on topic.
You can start another thread with UNC problems.
I think that we can change in application.cpp line 1206 to CStdString strWin32UserFolder = CWIN32Util::SmbToUnc(CWIN32Util::GetProfilePath()); for the appdata redirect bug
