Comskip for Linux released

  Thread Rating:
  • 6 Vote(s) - 4.17 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
tmm1 Offline
Junior Member
Posts: 12
Joined: Sep 2015
Reputation: 4
Post: #286
I have merged my SDL changes. If you `git pull` and `make` it should create a new `comskip-gui` binary that contains the debugwindow. Make sure you install libsdl1.2-dev first.
find quote
Pit80333 Offline
Junior Member
Posts: 7
Joined: Sep 2015
Reputation: 0
Post: #287
Just test "comskip-gui" for Arch and Ubuntu 14.04 (15.04 not yet tested). Works without any problem. Great job!
Your suggestion "enable_mencoder_pts=1" gave me the right hint. It has been replaced meanwhile by "output_edlp=1" setting, which enable generating a pts based mencoder file. I will give it a try tomorrow.
Did you use mplayer as your standard play-back program for video with .edl?
find quote
schumi2004 Offline
Posting Freak
Posts: 1,574
Joined: Aug 2011
Reputation: 17
Post: #288
(2015-09-18 19:21)tmm1 Wrote:  
(2015-09-18 19:04)schumi2004 Wrote:  Can this also be (cross) compiled for a Synology DS715 (alpine) ?

Yes, but you will have to cross-compile ffmpeg first to link against.

Thanks. Now i need to figure out how to accomplish this. In the past @aisman compiled them for me for other architecture Wink
find quote
schumi2004 Offline
Posting Freak
Posts: 1,574
Joined: Aug 2011
Reputation: 17
Post: #289
For my understanding. What does comskip-gui do?
Does it give Linux users a GUI to configure Comskip, if yes, how does it look like?
find quote
Pit80333 Offline
Junior Member
Posts: 7
Joined: Sep 2015
Reputation: 0
Post: #290
(2015-09-21 10:19)schumi2004 Wrote:  For my understanding. What does comskip-gui do?
Does it give Linux users a GUI to configure Comskip, if yes, how does it look like?

comskip-gui is used for "debuging" information and to "finetune" the found commercial breaks, see http://www.kaashoek.com/files/debugwindow.htm. It is not used to change the comskip.ini directly.
find quote
ketjap Offline
Junior Member
Posts: 2
Joined: Jun 2014
Reputation: 0
Post: #291
(2015-09-10 02:51)tmm1 Wrote:  
Quote:Can we rebuild a linux version off the latest windows?

I've ported the latest version of comskip to be POSIX compatible, and it now works on both mac and linux.

Furthermore, Erik has graciously accepted my patches back into the official version. This means all three major platforms can now use the latest and greatest comskip features.

You can build comskip for linux or mac directly from the git repository under Erik's account: https://github.com/erikkaashoek/Comskip

How great is this. Thanks for the good work.
find quote
ketjap Offline
Junior Member
Posts: 2
Joined: Jun 2014
Reputation: 0
Post: #292
I have a running comskip version on Ubuntu 14.04, Kodi 15.1 and TvHeadend 4.1-398~g4844b32. The edl file is being generated, but when playing with the kodi-pvr-hts plugin 2.1.17-1~trusty in Kodi it is not skipping the commercials for recorded tv with TvHeadend. I'm recording in ts files.
When I press 'o' during playback I can see the edl file is loaded and contain information where to skip the commerials.
When I stop playback during a commercial and resume playback again the commercial is skipped.

Do I miss something in the configuration of Kodi, or is this function not fully implemented yet? I believe I remember something you can specify if commercials/edl files should be used, but can't remeber where this is. Maybe it was another pvr addon, but if anyone have more information please let me know.

Thanks.

[edit]I was to quick with getting conclusions. It seems comskip is doing what it should do.[/edit]
(This post was last modified: 2015-10-05 21:15 by ketjap.)
find quote
schumi2004 Offline
Posting Freak
Posts: 1,574
Joined: Aug 2011
Reputation: 17
Post: #293
(2015-09-18 19:21)tmm1 Wrote:  
(2015-09-18 19:04)schumi2004 Wrote:  Can this also be (cross) compiled for a Synology DS715 (alpine) ?

Yes, but you will have to cross-compile ffmpeg first to link against.
Is it really neccesary to link against ffmpeg or will a seperate ffmpeg do the trick also?
find quote
tmm1 Offline
Junior Member
Posts: 12
Joined: Sep 2015
Reputation: 4
Post: #294
(2015-09-29 21:39)schumi2004 Wrote:  
(2015-09-18 19:21)tmm1 Wrote:  
(2015-09-18 19:04)schumi2004 Wrote:  Can this also be (cross) compiled for a Synology DS715 (alpine) ?

Yes, but you will have to cross-compile ffmpeg first to link against.
Is it really neccesary to link against ffmpeg or will a seperate ffmpeg do the trick also?

Yes, comskip needs to link against ffmpeg libraries during compile. It doesn't not use the bin/ffmpeg exe, only the libav* libs.
find quote
taiebot Offline
Junior Member
Posts: 38
Joined: Oct 2015
Reputation: 0
Post: #295
I tried to compile on raspberry pi2 on osmc https://osmc.tv/. and i do not manage to compile it. Here my output from osmc.

I would hope if someone manage to compile it on osmc to post about it.

Code:
sudo make -i
make: sdl-config: Command not found
cc -c -g -pipe -Wall -W -Wno-address -Wno-unused-parameter -Wno-unused-label -Wno-unused-result -O2 -DDONATOR -DPROCESS_CC   -I.  -o comskip.o comskip.c
comskip.c:675:24: error: expected declaration specifiers or ‘...’ before numeric constant
comskip.c:675:34: error: unknown type name ‘histogram’
comskip.c:676:24: error: expected declaration specifiers or ‘...’ before numeric constant
comskip.c:676:34: error: unknown type name ‘lastHistogram’
comskip.c:9406:24: error: expected declaration specifiers or ‘...’ before numeric constant
comskip.c:9406:33: error: unknown type name ‘own_histogram’
comskip.c: In function ‘ScanBottom’:
comskip.c:9445:13: error: ‘own_histogram’ undeclared (first use in this function)
comskip.c:9445:13: note: each undeclared identifier is reported only once for each function it appears in
comskip.c: In function ‘ScanTop’:
comskip.c:9495:13: error: ‘own_histogram’ undeclared (first use in this function)
comskip.c: In function ‘ScanLeft’:
comskip.c:9545:13: error: ‘own_histogram’ undeclared (first use in this function)
comskip.c: In function ‘ScanRight’:
comskip.c:9595:13: error: ‘own_histogram’ undeclared (first use in this function)
comskip.c: In function ‘CheckSceneHasChanged’:
comskip.c:9646:12: error: ‘lastHistogram’ undeclared (first use in this function)
comskip.c:9646:27: error: ‘histogram’ undeclared (first use in this function)
comskip.c:9652:12: error: ‘own_histogram’ undeclared (first use in this function)
Makefile:76: recipe for target 'comskip.o' failed
make: [comskip.o] Error 1 (ignored)
cc -c -g -pipe -Wall -W -Wno-address -Wno-unused-parameter -Wno-unused-label -Wno-unused-result -O2 -DDONATOR -DPROCESS_CC   -I.  -o mpeg2dec.o mpeg2dec.c
mpeg2dec.c: In function ‘audio_packet_process’:
mpeg2dec.c:641:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
mpeg2dec.c:644:99: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
mpeg2dec.c:716:63: error: ‘AVFrame’ has no member named ‘channels’
mpeg2dec.c:721:92: error: ‘AVFrame’ has no member named ‘channels’
mpeg2dec.c:724:38: error: ‘AVFrame’ has no member named ‘channels’
mpeg2dec.c: In function ‘Set_seek’:
mpeg2dec.c:945:38: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
mpeg2dec.c: In function ‘DecodeOnePicture’:
mpeg2dec.c:1048:79: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
mpeg2dec.c:1049:28: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
mpeg2dec.c: In function ‘video_packet_process’:
mpeg2dec.c:1191:9: warning: implicit declaration of function ‘av_stream_get_parser’ [-Wimplicit-function-declaration]
mpeg2dec.c:1191:89: error: invalid type argument of ‘->’ (have ‘int’)
mpeg2dec.c:1196:9: warning: implicit declaration of function ‘av_frame_get_best_effort_timestamp’ [-Wimplicit-function-declaration]
mpeg2dec.c:1199:35: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
mpeg2dec.c:1206:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
mpeg2dec.c:1207:87: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
mpeg2dec.c:1217:109: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
mpeg2dec.c:1218:76: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
mpeg2dec.c:1329:66: error: ‘AVStream’ has no member named ‘r_frame_rate’
mpeg2dec.c: In function ‘stream_component_open’:
mpeg2dec.c:1579:35: error: ‘CODEC_ID_MPEG1VIDEO’ undeclared (first use in this function)
mpeg2dec.c:1579:35: note: each undeclared identifier is reported only once for each function it appears in
mpeg2dec.c:1587:35: error: ‘CODEC_ID_H264’ undeclared (first use in this function)
mpeg2dec.c:1664:9: warning: ‘lowres’ is deprecated (declared at /usr/include/libavcodec/avcodec.h:2524) [-Wdeprecated-declarations]
mpeg2dec.c:1664:9: warning: implicit declaration of function ‘av_codec_get_max_lowres’ [-Wimplicit-function-declaration]
mpeg2dec.c: In function ‘log_callback_report’:
mpeg2dec.c:1735:5: warning: implicit declaration of function ‘av_log_format_line’ [-Wimplicit-function-declaration]
mpeg2dec.c: In function ‘file_open’:
mpeg2dec.c:1777:23: error: ‘AVFormatContext’ has no member named ‘max_analyze_duration2’
mpeg2dec.c:1834:37: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
mpeg2dec.c:1841:24: error: ‘AVStream’ has no member named ‘r_frame_rate’
mpeg2dec.c:1841:58: error: ‘AVStream’ has no member named ‘r_frame_rate’
mpeg2dec.c:1843:42: error: ‘AVStream’ has no member named ‘r_frame_rate’
mpeg2dec.c: In function ‘main’:
mpeg2dec.c:2140:79: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
mpeg2dec.c:2141:32: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
mpeg2dec.c:2238:29: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
Makefile:76: recipe for target 'mpeg2dec.o' failed
make: [mpeg2dec.o] Error 1 (ignored)
cc -g  -o comskip comskip.o platform.o mpeg2dec.o video_out_dx.o ccextratorwin/608.o ccextratorwin/ccextractor.o ccextratorwin/encoding.o ccextratorwin/general_loop.o ccextratorwin/myth.o   -lavutil -lavformat -lavcodec -largtable2 -pthread -lm
cc: error: comskip.o: No such file or directory
cc: error: mpeg2dec.o: No such file or directory
Makefile:96: recipe for target 'comskip' failed
make: [comskip] Error 1 (ignored)
[email protected]:~/comskip/Comskip$ sudo make -i
find quote
tmm1 Offline
Junior Member
Posts: 12
Joined: Sep 2015
Reputation: 4
Post: #296
What does "cc -v" say?
find quote
tmm1 Offline
Junior Member
Posts: 12
Joined: Sep 2015
Reputation: 4
Post: #297
Ah I think that error occurs if you are using too old a version of ffmpeg
find quote
schumi2004 Offline
Posting Freak
Posts: 1,574
Joined: Aug 2011
Reputation: 17
Post: #298
Now several commits are merged in Erik's branch does it still support mkv or not?
find quote
tmm1 Offline
Junior Member
Posts: 12
Joined: Sep 2015
Reputation: 4
Post: #299
Yes mkv is supported
find quote
schumi2004 Offline
Posting Freak
Posts: 1,574
Joined: Aug 2011
Reputation: 17
Post: #300
(2015-10-27 18:30)tmm1 Wrote:  Yes mkv is supported

Great.

Another question.
By default comskip looks for the comskip.ini file in /etc/comskip right?
Is there a way to change it so comskip will always look for other location?

I'm asking this because i create a Synology Package for it but now realize that the config location could be wrong when launching.
I would like to have the default location set to: [email protected]/comskip/var/

Is such possible?
(This post was last modified: 2015-10-29 13:28 by schumi2004.)
find quote
Post Reply