There is unnecessary SystemInfo refreshes.
#1
Hello,

I think there is unnecessary refresh for some infos on SystemInfo.cpp.

What do you think?
https://github.com/queeup/xbmc/commit/5c...6f7b60607c
Reply
#2
This will only read system info on boot and leave it the same throughout the entire run?
Seems more than sane to me (we also discussed this screen at DevCon).
Read/follow the forum rules.
For troubleshooting and bug reporting, read this first
Interested in seeing some YouTube videos about Kodi? Go here and subscribe
Reply
#3
Yes. Because there is no need to look Kernel version all the time. It's not going to change.

For example if I am using jsonrpc for look kernel version most of the time because of this refreshes jsonrpc return "Busy" string.
Also GPU & CPU heat not refreshes. Adding them there maybe also good idea.
Reply
#4
Anything static and doesn't change could be excluded imo.
Any "dynamic" should be included.
Read/follow the forum rules.
For troubleshooting and bug reporting, read this first
Interested in seeing some YouTube videos about Kodi? Go here and subscribe
Reply
#5
GetMACAddress, could change if switching networks.
Reply
#6

  1. Summary
    • Free memory: dynamic
    • IP address: dynamic
    • Screen resolution: dynamic
    • Operation system: static
    • System uptime: dynamic
    • Total uptime: dynamic
    • Battery level: dynamic

  2. Storage: dynamic
  3. Network
    • Link: dynamic
    • MAC address: dynamic
    • IP address: dynamic?
    • Subnet mask: static?
    • Gateway: static?
    • Primary DNS: static?
    • Secondary DNS: static?
    • Internet: dynamic
  4. Video
    • GPU: static
    • Screen resolution: dynamic?
    • OpenGL vendor: static
    • OpenGL version: static
    • GPU temperature: dynamic
  5. Hardware
    • CPU: static
    • CPU temperature: dynamic
    • CPU speed: dynamic
    • CPU Usage: dynamic
    • Total memory: static
    • Free memory: dynamic
Reply
#7
3. Network: all dynamic because they can change during run
4. Video CPU speed: my guess dynamic
5. Hardware CPU speed: dynamic

Are these values even refreshed when you are not viewing these windows? (no clue here) If they won't it be better to not refresh these if they aren't used anywhere else and only update on viewing them.
Read/follow the forum rules.
For troubleshooting and bug reporting, read this first
Interested in seeing some YouTube videos about Kodi? Go here and subscribe
Reply
#8
Yes they are refreshing even you are not looking. Just inside DoWork() things refreshing.
Reply
#9
I'm not 100% sure if even GPU static in all cases...
What about boundary case of starting XBMC, then remote desktopping in (or vice-versa). My Windows programming isn't strong but I think that changes "GPU" no?
Reply
#10
"Yes they are refreshing even you are not looking".

How do you conclude that? They're only refreshed when that job is run, which is not continuously, right?
Always read the XBMC online-manual, FAQ and search the forum before posting.
Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting please make sure you read this first.


Image
Reply
#11
(2013-01-10, 01:29)queeup Wrote: Yes they are refreshing even you are not looking. Just inside DoWork() things refreshing.

you bp that and hit it ?

Reply
#12
(2013-01-10, 05:13)edrikk Wrote: I'm not 100% sure if even GPU static in all cases...
What about boundary case of starting XBMC, then remote desktopping in (or vice-versa). My Windows programming isn't strong but I think that changes "GPU" no?

Remote desktop does not work iirc
Besides those are remote border cases.
Read/follow the forum rules.
For troubleshooting and bug reporting, read this first
Interested in seeing some YouTube videos about Kodi? Go here and subscribe
Reply
#13
(2013-01-10, 06:01)jmarshall Wrote: "Yes they are refreshing even you are not looking".

How do you conclude that? They're only refreshed when that job is run, which is not continuously, right?
When I am using jsonrpc for checking kernel version most of the time it returns "Busy" string. Yea you are right it doesn't mean working all the time but it is disturbing kernel version check somehow.

(2013-01-10, 06:04)davilla Wrote:
(2013-01-10, 01:29)queeup Wrote: Yes they are refreshing even you are not looking. Just inside DoWork() things refreshing.

you bp that and hit it ?
bp?
Reply
#14
bp = breakpoint.
If you hit the breakpoint when normal use of xbmc the info is refreshed.
Read/follow the forum rules.
For troubleshooting and bug reporting, read this first
Interested in seeing some YouTube videos about Kodi? Go here and subscribe
Reply
#15
I left system running for half an hour and that part of the code wasn't hit unless i opened the system info window
Read/follow the forum rules.
For troubleshooting and bug reporting, read this first
Interested in seeing some YouTube videos about Kodi? Go here and subscribe
Reply

Logout Mark Read Team Forum Stats Members Help
There is unnecessary SystemInfo refreshes.0