VDR VNSI Timer issue if event name has / character
#1
Hi,

i'm using Frodo with VDR 1.7.27 and Plugin/vnsiserver4 from here https://github.com/FernetMenta/xbmc-pvr-addons

If the event name has the character '/' for example "Die Tierärzte vom Kilimanjaro (2/3)", the '/' character will not be handled correctly.
If recording is started, directory structure looks like "

Code:
Die_Tierärzte_vom_Kilimanjaro_(2
+---3)
     +---2013-03-04.00.43.2-0.rec

instead of

Code:
Die_Tierärzte_vom_Kilimanjaro_(2~3)
  +---2013-03-04.00.43.2-0.rec

There is also a difference in timers.conf, it looks like

Code:
1:T-8468-514-515:2013-03-05:1605:1710:99:99:Die Tierärzte vom Kilimanjaro (2/3):<vdradmin-am><bstart>10</bstart><bstop>10</bstop></vdradmin-am>

if timer is programmed with vdradmin-am and

Code:
1:T-8468-514-515:2013-03-05:1613:1710:50:99:Die Tierärzte vom Kilimanjaro (2~3):

if timer is programmed via xbmc.

Here is a vdr.log of an event i programmed last night:
Code:
Mar  4 01:00:31 [32730] VNSI: Timer 1 (2 0043-0250 'Kommissarin Lund Das Verbrechen III (4~5)') added
Mar  4 01:00:31 [32726] VNSI: Timers state changed (1)
Mar  4 01:00:31 [32726] VNSI: Requesting clients to reload timers
Mar  4 01:00:32 [32717] [core.pids] 0/0: tune to same source/transponder
Mar  4 01:00:32 [32717] timer 1 (2 0043-0250 'Kommissarin Lund Das Verbrechen III (4~5)') start
Mar  4 01:00:32 [32717] record /srv/videos/vdr/Kommissarin_Lund_Das_Verbrechen_III_(4/5)/2013-03-04.00.43.2-0.rec
Mar  4 01:00:32 [32726] VNSI: Recordings state changed (13)
Mar  4 01:00:32 [32726] VNSI: Requesting clients to reload recordings list

Recording has been successfully finished, only directory structure is wrong.
Kodi 18.6 @ openSUSE 13.1 x86_64 - Asus E35M1-I DELUXE | 8GB Ram | 240G 2.5" SSD
Kodi 20.2 on 1st Raspberry Pi B @ XBian | Kodi 20.2 on Raspberry Pi 3B+ @ XBian | Kodi 21a2 on Raspberry Pi4B @ XBian | Kodi 19.0 on SolidRun i.MX6 @ XBian
VDR 2.4.5 & Tvheadend4.3-1917 (for recording) on Cubieboard2 @ Debian Buster
Reply
#2
check cVNSIData::AddTimer (addon). Replacement of directory reparators should be done before adding the title.

Code:
// replace directory separators
  for(std::size_t i=0; i<path.size(); i++) {
    if(path[i] == '/' || path[i] == '\\') {
      path[i] = '~';
    }
  }

  if(strlen(timerinfo.strTitle) > 0) {
    path += timerinfo.strTitle;
  }

If you got time, a pull request is very welcome Smile
Reply
#3
Thank you for your quick response.

Currently i looked to the code and found the same position to change the code in exactly the same way you would.

I will make the change and test it. After it works, i will try to make a PR Wink
Kodi 18.6 @ openSUSE 13.1 x86_64 - Asus E35M1-I DELUXE | 8GB Ram | 240G 2.5" SSD
Kodi 20.2 on 1st Raspberry Pi B @ XBian | Kodi 20.2 on Raspberry Pi 3B+ @ XBian | Kodi 21a2 on Raspberry Pi4B @ XBian | Kodi 19.0 on SolidRun i.MX6 @ XBian
VDR 2.4.5 & Tvheadend4.3-1917 (for recording) on Cubieboard2 @ Debian Buster
Reply

Logout Mark Read Team Forum Stats Members Help
VDR VNSI Timer issue if event name has / character0