[moreginger]

There must be a way to get the ISO-639-1 2-letter language code for the XBMC language? The best API I have found is xbmc.getLanguage() which returns something like "English".

[Martijn]

i could make a script.module.language and put it in repo.
that way everyone could use that and saves them hacking around in each individual script themselves.
preferred would be and optional in the xbmc.getLanguage() where you define what type you want to retrieve.
0: full language
1: two letter code
2: three letter code

[sphere]

@Martijn:
If you want to develop such an add-on, feel free to copy some code from my iTunes Podcast Add-on.

But, personally I would prefer a core solution.

[Martijn]

@Martijn:
If you want to develop such an add-on, feel free to copy some code from my iTunes Podcast Add-on.

But, personally I would prefer a core solution.

i'd prefer a core solution to but for the time being.

[Ace]

i'd prefer a core solution to but for the time being.

I could try it if no one else is working on that.

[Martijn]

i'd prefer a core solution to but for the time being.

I could try it if no one else is working on that.

yes please
core also has these language codes internally so just need to bee hooked up.

however we will probably still require some 3rd party converter as you may also scrape the ISO codes from a site and want to display them as normal language string.
imo that shouldn't be of any core concern.
So if we could at least have the xbmc.getlanguage() to return one of those 3 options it would be great.

[moreginger]

preferred would be and optional in the xbmc.getLanguage() where you define what type you want to retrieve.
0: full language
1: two letter code
2: three letter code

This sounds great!
Would we get access to regionalized variants, e.g. pt-br, en-gb? I don't know if XBMC regionalizes at that granularity, but TED subtitles do (at least for pt-br ).

[Ace]

yes please
core also has these language codes internally so just need to bee hooked up.

Done

This sounds great!
Would we get access to regionalized variants, e.g. pt-br, en-gb? I don't know if XBMC regionalizes at that granularity, but TED subtitles do (at least for pt-br ).

Is this really reasonable? Do you have a use case? If so I will dig a bit deeper.

[moreginger]

This sounds great!
Would we get access to regionalized variants, e.g. pt-br, en-gb? I don't know if XBMC regionalizes at that granularity, but TED subtitles do (at least for pt-br ).

Is this really reasonable? Do you have a use case? If so I will dig a bit deeper.

If they aren't available then the following happens:

* Brazilian user selects XBMC language: Portuguese (Brazil) - assuming this is or will be possible.
* xbmc.getLanguage(...) returns 'pt'.
* Subtitles fetched in 'ordinary' Portuguese not 'pt-br'.

It's not exactly apocalyptic stuff (maybe Brazilians disagree ) but it would be nice.

[Martijn]

@Martijn:
If you want to develop such an add-on, feel free to copy some code from my iTunes Podcast Add-on.

But, personally I would prefer a core solution.

Maybe an idea to just put it in xbmcswift?
At least for Frodo.

[sphere]

Yes, when it gets merged and the API is stable me (or Jbel) will pre-port it into xbmcswift2 to have a seamless migration to Gotham later.

[Martijn]

I mean instead of creating a separate module for it now already put it in swift. So for now let the module handle the converting of he code by putting the ISO table in it.

[sphere]

Yes, that's also what I meant, it will be available in xbmcswift2 soon (before xbmc Gotham) - but to have a similar interface like the later available native solution I need to see it first

Assumptive jbel doesn't say no

EDIT: xbmcswift Issue

[Martijn]

For testing
https://github.com/xbmc/xbmc/pull/2643


Since that only handles the xbmc.getLanguage we should as an extra also be able to convert two to three letter code and vice versa and also back to complete language string. That would still be a job of a module I guess
Like convert_language() with the option to define what you want to get back.

[Ace]

For testing
https://github.com/xbmc/xbmc/pull/2643


Since that only handles the xbmc.getLanguage we should as an extra also be able to convert two to three letter code and vice versa and also back to complete language string. That would still be a job of a module I guess
Like convert_language() with the option to define what you want to get back.

I can add a conversion method to the core tomorrow if you like. I have that in mind since my language unification pr got merged. Since that point audio and sub languages get returned as 3char code.

---

This sounds great!
Would we get access to regionalized variants, e.g. pt-br, en-gb? I don't know if XBMC regionalizes at that granularity, but TED subtitles do (at least for pt-br ).

Is this really reasonable? Do you have a use case? If so I will dig a bit deeper.

If they aren't available then the following happens:

* Brazilian user selects XBMC language: Portuguese (Brazil) - assuming this is or will be possible.
* xbmc.getLanguage(...) returns 'pt'.
* Subtitles fetched in 'ordinary' Portuguese not 'pt-br'.

It's not exactly apocalyptic stuff (maybe Brazilians disagree ) but it would be nice.

Had a brief look, should be possible. @Martijn Shall I add a second bool param with default value false?