(2015-08-17, 20:16)Lunatixz Wrote: (2015-08-17, 06:07)aptalca Wrote: (2015-08-14, 18:43)Lunatixz Wrote: I use landscape because that's what I prefer and I'm the skins designer
PTVL is designed to use fallbacks when the primary art isn't found.... Ie. Landscape falls back to fanart.
Has nothing to do with extra hits, sounds more like I broke the fanart caching function... Easy fix
I figured out the issue. Artwork downloader saves the images named as fanart.jpg
Kodi exports images with the name filename-fanart.jpg
PTVL only looks for fanart.jpg and does not see filename-fanart.jpg
I used artwork downloader to download fanart with the overwrite setting turned off. It ended up replacing all my fanart in my library because it ignored the filename-fanart.jpg and thought I didn't have any fanart.
Now PTVL does fall back to fanart but I ended up with messed up artwork :-(
I'm planning on going back to the original ones but could you add support for the filename-fanart.jpg naming convention? Technically it is the official kodi way.
Thanks
No, sorry I only support the conventional naming scheme: http://kodi.wiki/view/Add-on:Artwork_Dow...onventions
Its a pretty standard format, almost all mediainfo utilities I use default to this scheme.
BTW I think you are misinformed.... I do not believe its the default kodi way...
http://kodi.wiki/view/Artwork#Naming_conventions
Ok, fair enough. How about a solution that fixes the root of the problem so we don't even have to worry about naming conventions or even local files?
I do have a suggestion that might make it more universal for kodi users.
What if PTVL queries kodi for the fanart like the skins, other addons and android and ios remotes do, instead of looking for files on disk? Any user who scraped their database should have a fanart linked in the the database and a local thumb in kodi's thumbcache. I understand you prefer landscape art and that's fine, as that can be the first choice, but for the fallback fanart, kodi could be queried. The following could be the workflow:
1) PTVL looks for local landscape art (as it is the default and your preferred way) (landscape art AFAIK is not linked in kodi database so no way of querying, it has to be a local file on disk)
2) If there is no landscape art, PTVL queries kodi through json-rpc api, retrieves the fanart and caches it for later use
Pros:
1) No need to worry about local files or naming conventions (people who prefer landscape thumbs can still use them)
2) No need to rely on external add-ons like the artwork downloader (people can still use it to retrieve landscape art if they prefer)
3) Anybody who scraped their library in kodi will have no problems with PTVL artwork as there should already be fanart linked
4) You'll have fewer support requests as it should just work
5) Even people who have all their movies in one folder would be able to use PTVL as is
Cons:
1) It will take time for you to code it (knowing how productive and efficient you are, it should take minimal time
)
I think this would make PTVL more universal in terms of artwork support. What do you think?
Thanks