Posts: 824
Joined: Jun 2005
Reputation:
6
How should be external subs named to prefer them over internal ones with default or/and forced flag?
Can't you prefer external subs regardless of their name by default? I believe that's how it always worked in xbmc.
Posts: 824
Joined: Jun 2005
Reputation:
6
Prior to this patch external subs were always preferred regardless of internal subs flags. You only needed to have external subtitles named with prefix of the video filename (video*.srt for video.mkv) That's how it always worked, except some small timeframes where it was broken.
I thought, that this shouldn't touch external subtitles behaviour.
Most people have external subtitles because they don't care about internal subtitles.
So now they have to rename all external subtitles they have to have them preferred over internal ones? That does sound little bit complicated.
If this should go in, there should be setting available to have external subs always preferred when they are detected at the beginning of the playback.
Posts: 1,251
Joined: Dec 2008
Reputation:
15
Yeah, the external ones really ought to be preferred over the internal ones even when the external one has no flags. All other media players I use behave that way; VLC and MPC-HC for example always prefer external ones over internal ones regardless of the flags of the internal subtitles.
Posts: 4,142
Joined: Jun 2010
Reputation:
335
2013-10-25, 15:52
(This post was last modified: 2013-10-25, 16:09 by Wanilton.)
I compiled merged PR 3396 e 3496 codes, but nothing appears external ou internal subtitle using same movie in ISO BD, 007 Skyfall.
Posts: 3,956
Joined: Dec 2008
Reputation:
62
Can we have an option in settings that would read "always ask"?
It should then present a list of audio and subtitle tracks to choose from when you select a movie.
Posts: 4,142
Joined: Jun 2010
Reputation:
335
Ok ace20022, don´t my intention push you, only think is fine report if it´s ok or not.
Posts: 819
Joined: Aug 2012
Reputation:
35
Ace
Team-Kodi Member
Posts: 819
I have added a switch labelled "Prefer external subtitles" to the settings. It's turned on by default. The new build can be found in the OP.
Posts: 455
Joined: Apr 2010
Reputation:
13
Hope me piping in here isn't off topic and not what's being discussed but seems relevant.
Personally, I remux desired audio streams / subtitles that are relevant to my language, like most others I expect. Often films have the odd forced subtitle within a full subtitle track, for non english parts that would be forced if watching a bluray for example.
I find that XBMC doesn't seem to be able to even detect the difference between a "forced" flag and a "default" and a "not default and not forced" flag set in the MKV container.
This is surely more important than any of the discussion taking place here and what really needs "fixing".
For example, currently have to actually wait for a forced subtitle to not appear when it should to think "ahhh better go into the menu and manually turn on subtitles and set the forced one on".
The only other option is to have subtitles set to on by default, which obviously is completely impractical since when watching "Live TV" or the majority of films that don't have or need a forced subtitle have to manually turn them off.
Does XBMC currently not even parse these flags?
Posts: 819
Joined: Aug 2012
Reputation:
35
Ace
Team-Kodi Member
Posts: 819
I've update the build in the op. The original case should work now. Additionally I've added switching forced sub when switching audio track. Could you please re-ckeck with your test cases?