• 1
  • 65
  • 66
  • 67(current)
  • 68
  • 69
  • 140
Release script.skinshortcuts
(2015-11-30, 20:45)BobCratchett Wrote:
(2015-11-30, 13:56)Jeroen Wrote: Cheers Bob Smile

I have to admit though at the moment I am behind on recent(ish) developments and as a result a bit confused about the difference between using <shortcut> elements for widgets and defining them as <widget>

I am currently defining then as shortcut in a custom grouping and everything works as intended, but I am unsure if this is the advised way.

Can you please test https://github.com/BigNoid/script.skinsh...s/pull/115 - Cheers

I think its fair to say that the <shortcuts /> were really added for the scripts own use but skinners have found them useful as they allow far more customisation of where their widgets appear. I don't think one is particularly recommended over the other - defining widgets the classic way is a little easier (especially for setting defaults), doing it via <shortcuts /> is more customisable - use whichever works for you Big Grin

Great, customization it is then Wink

I'm afraid I haven't been able to get it to work though I'm afraid. Code excerpts:

overrides.xml:
PHP Code:
<widget-groupings>
...
<
shortcut label="342" type="32099" name="Movies Watchlist" icon="DefaultIconWatchlist.png" widget="Addon" widgetType="movies" widgetTarget="video" condition="System.HasAddon(script.watchlist)">plugin://script.watchlist/?type=movies</shortcut> 

where the label should appear:
PHP Code:
<label>$INFO[Container(9000).ListItem.Property(name)]</label

I can get any of the other properties to show up here, exept from "name". I tried widgetName too, that returns the name listed in the management dialog.

I cleared out the addon data folder too just in case.
Reply
(2015-11-30, 23:49)Jeroen Wrote: Great, customization it is then Wink

I had a feeling you'd say that Wink

(2015-11-30, 23:49)Jeroen Wrote: I'm afraid I haven't been able to get it to work though I'm afraid.

'widgetName', not just 'name' (for both the <shortcut /> attribute and the property that is returned - the <widget /> attribute is 'name') Wink

Code:
<shortcut label="342" type="32099" widgetName="Movies Watchlist" icon="DefaultIconWatchlist.png" widget="Addon" widgetType="movies" widgetTarget="video" condition="System.HasAddon(script.watchlist)">plugin://script.watchlist/?type=movies</shortcut>

Code:
<label>$INFO[Container(9000).ListItem.Property(widgetName)]</label>

It's always the same 5 properties that are returned for widgets, however they're defined:- widget, widgetName, widgetType, widgetTarget, widgetPath. More details Smile
Reply
I had a feeling I'd be wrong Tongue

I actually tried widgetName in the label but forgot to do the same for the actual widget definition

And it's only monday... Shy

Working fine now, thanks!
Reply
Great, I'll get it merged on git shortly Smile
Reply
Where's the download link for the zip file for Kodi 16?
CPU:- AMD FX 4100 Motherboard: Gigabyte 78LMT-S2 RAM:-4GB Graphics: AMD HD 7750 1GB DDR5 PSU: IBALL 500W Display: DELL S2240M Storage: 1TB
Reply
There's no official release for Jarvis as yet (should be relatively soon, but I believe the plan is to test it via the Emby beta repo before an official repo push to try and find any last-minutes bugs.) If you find things aren't working on Jarvis, there are some Jarvis changes - mostly to music shortcuts - on Git:- https://github.com/BigNoid/script.skinshortcut

Otherwise, the official release can be downloaded from the Isengard repo - http://mirrors.kodi.tv/addons/isengard/s...-0.6.6.zip - and should work fine with Jarvis unless you come across any issues with the music shortcuts (I don't use Kodi for music, and have only heard 3rd hand non-specific reports of shortcuts not working) though any skin that uses it should install it automatically when the skin is installed.
Reply
(2015-12-01, 00:23)BobCratchett Wrote: Great, I'll get it merged on git shortly Smile

Sorry, it seems I have run into a slight issue after all

Using
PHP Code:
widgetName="$LOCALIZE[31029]

or

PHP Code:
widgetName="::LOCAL::31029" 

makes the string ("episodes watchlist") show up fine when the main menu item the widget is tied to is highlighted.

When this menu's submenu items are highlighted however it shows:

PHP Code:
$Skin[31029]|skin.refocus|episodes watchlist

Something seems to be going wrong with the "clonewidgets" build option here?
Reply
I have some strange things happening with the propertyfallback and templates.

So in my script-skinshortcuts.xml
Code:
<control type="button" id="312">
                    <description>Change widget 1</description>
                    <width>1316</width>
                    <height>90</height>
                    <textoffsetx>30</textoffsetx>
                    <font>font15</font>
                    <label>$ADDON[script.skinshortcuts 32044] 1</label>
                    <label2>$INFO[Container(211).ListItem.Property(widgetName)]</label2>
                    <onclick>SetProperty(customProperty,widgetArt)</onclick>
                    <onclick>SendClick(404)</onclick>
                    <visible>StringCompare(Window.Property(groupname),mainmenu)</visible>
                </control>
and
Code:
<control type="button" id="512">
                    <description>Change widget 2</description>
                    <width>1316</width>
                    <height>90</height>
                    <textoffsetx>30</textoffsetx>
                    <font>font15</font>
                    <label>$ADDON[script.skinshortcuts 32044] 2</label>
                    <label2>$INFO[Container(211).ListItem.Property(widgetName.2)]</label2>
                    <onclick>SetProperty(widgetID,2)</onclick>
                    <onclick>SendClick(312)</onclick>
                    <onclick>SetProperty(customProperty,widgetArt.2)</onclick>
                    <onclick>SendClick(404)</onclick>
                    <visible>StringCompare(Window.Property(groupname),mainmenu)</visible>
                </control>

In the template.xml for widget 1

Code:
<other include="widgetPanel1">
        <condition tag="property" attribute="name|widgetStyle">Panel</condition>
and for widget 2
Code:
<other include="widgetPanel2">
        <condition tag="property" attribute="name|widgetStyle.2">Panel</condition>


With no property fallback in my overrides.xml the template builds without a problem.

I then add this to my overrides.xml
Code:
<propertyfallback property="widgetStyle">Panel</propertyfallback>
    <propertyfallback property="widgetArt">FanArt</propertyfallback>
    <propertyfallback property="widgetStyle.2">Panel</propertyfallback>
    <propertyfallback property="widgetArt.2">FanArt</propertyfallback>

Then Widget 2 does not build the template for all the menu items only the first item in the menu. If I set the value for widget style 1 in the dialog widget 2 then appears.

Here is the log of a reset and rebuild of the main menu.
http://pastebin.com/raw.php?i=QRLkybpa

All the skin xml's ect is here
https://github.com/mikesilvo164/Aeon-Nox...widgets_v3
Madnox 2.0
Forum / Source
Reply
@Jeroen - Nice spot Smile I'm kind of coding blind here as I don't have any skin set up with clone options, but can you try https://github.com/Ignoble61/script.skin...idget-name to see if that fixes it? Cheers

@Mr. V - Downloaded your widgets branch and can't reproduce this, any 2nd widget I set shows up on all menu items. It's also an odd bug because the fallback property code didn't touch the template code at all Confused My instinct - which is often wrong - is that the reason the template would only be building once is likely because it only matches once, so the first thing to check would be that, in your script-skinshortcuts-includes.xml, the fallback properties have been set on menu items whose template isn't building. Other things worth checking are if it happens with any particular widget, and if it happens when the widget is re-added to the menu item. Assuming nothing shows up with those tests, I'll have a better go at breaking it this evening Big Grin
Reply
(2015-12-02, 10:37)BobCratchett Wrote: @Jeroen - Nice spot Smile I'm kind of coding blind here as I don't have any skin set up with clone options, but can you try https://github.com/Ignoble61/script.skin...idget-name to see if that fixes it? Cheers

Yup, widgetName showing up as intended on main and submenu items now Smile Thanks again!
Reply
@Jeroen - Great Smile

@Mr. V - I've found a case where the code that finds the 'other' templates can return after only finding one. Not sure if it's related to your problem, but can you please test https://github.com/Ignoble61/script.skin...idget-name to see if it makes a difference Smile
Reply
(2015-12-02, 11:34)BobCratchett Wrote: @Mr. V - I've found a case where the code that finds the 'other' templates can return after only finding one. Not sure if it's related to your problem, but can you please test https://github.com/Ignoble61/script.skin...idget-name to see if it makes a difference Smile

Cheers Bob. It is working now. Big Grin

Thanks for you quick fix.
Madnox 2.0
Forum / Source
Reply
Hi, Bob

I was going to give a shot to the new DefaultProperty but I admit being a bit lost ATM and after reading the doc, I'm not sure to be able to achieve what I wanted when requested the DefaultProperty.

First, I didn't get from where the "GroupName" comes from :

PHP Code:
<propertydefault labelID="[LabelID]" group="[GroupName]" property="[Property]">[Property Value]</propertydefault

Then, what I wanted is for coming from an "already built" menu, add the Properties needed by my skin, as follow :

Condition : menu Item has "widgetPath" > Set DefaultProperty name="viewtype" as HOM.View2
Condition : menu Item hasn't "widgetPath" > Set DefaultProperty name="viewtype" as HOM.View1
Condition : menu Item has "widgetPath" & labelID="livetv" > Set DefaultProperty name="viewtype" as HOM.View3

Maybe using SetProperty(custom-grouping,[groupname]) and defining this "I think the same" groupname as "Widget" or "NotWidget" ? and then make it as follow ?

PHP Code:
<propertydefault group="Widget" property="viewtype">HOM.View2</propertydefault>
<
propertydefault group="NotWidget" property="viewtype">HOM.View1</propertydefault>
<
propertydefault group="WidgetTV" property="viewtype">HOM.View3</propertydefault

Thx in advance
[Skin] KOver - V1.1.0 Stable (Repo version)
[WIP] ReKOver - Skinning tool project

If I've been helpful or you like my work, hit "THANK USER" button ;) ...
Reply
Hi
how can now the answer?

http://forum.kodi.tv/showthread.php?tid=...pid2173338
Reply
(2015-12-02, 18:56)avia Wrote: Hi
how can now the answer?

http://forum.kodi.tv/showthread.php?tid=...pid2173338

(2015-11-29, 08:08)avia Wrote: Where can I translate this text?

Image

script.skinshortcuts/resources/language/
Reply
  • 1
  • 65
  • 66
  • 67(current)
  • 68
  • 69
  • 140

Logout Mark Read Team Forum Stats Members Help
script.skinshortcuts8