Posts: 28
Joined: Sep 2009
Reputation:
0
I've fixed the addon somewhat. It isn't my addon so how do I get this on the repo?
There is still a glaring security hole in the script, there is an 'eval' which is executing a string originating from a HTTP.
Aren't these things audited before allowed in the repo?
Posts: 2,078
Joined: Nov 2012
Reputation:
176
enen92
Team-Kodi Member
Posts: 2,078
I think divingmule has been absent for a long time (Last Visit: 2014-01-27 15:40)
Probably a good idea to contact the team-kodi via the addon mailing list and submit your pr's there even not being the author of the plugin...
Posts: 28
Joined: Sep 2009
Reputation:
0
The plugin is under my control now, if divingmule wants it back that's fine of course. I've emailed the addon mailinglist some while ago and since then I was able to publish the new plugin based on divingmule's code. In the source code he's still listed as original author. This forum thread is still the main means of bug reporting, let me know if something breaks. The scraping is brittle due to the engadget website being horrible with HTML errors and all - so I _don't_ expect this to work fine in to eternity.
Posts: 256
Joined: Dec 2009
Reputation:
1
well this plugin is crashing Kodi whenever it is opened.
Kodi 17.0alpha2
uninstalled
Posts: 28
Joined: Sep 2009
Reputation:
0
Well, I can't reproduce, so it's hard for me to say anything.
Personally I'd blame Kodi in this case, first reason is that you're running an Alpha, and the second reason is that in no way should Kodi crash whatever a plugin is doing.
If you are in the ability to test again and get a debug log while reproducing the error, please do.
Thanks for the feedback though!