[AndyFurniss]

I am building a stripped down xbmc like -

./configure --disable-mysql --disable-samba --disable-dbus --disable-sdl --disable-texturepacker --disable-ssh --disable-optical-drive --disable-joystick --disable-pulse --prefix=/usr

On an LFS setup where Intel drivers/mesa/kernel are recent gits/

While testing for vaapi deinterlacers I noticed that the file burosch1.mpg behaved strangely - debug osd showing 36 fps (should be 50) with any deint other than bob, scaling is bilinear

This does not happen with any other file I tried including burosch2.mpg and also only happens with current master and not FernetMenta master.

logs below, obvious diff is that failing master shows some pullup detected. I renamed burosch1.mpg Letters.mpg years ago - I have just confirmed md5sum matches with

https://samples.libav.org/MPEG2/interlaced/

Working log

http://xbmclogs.com/show.php?id=333764

Failing log

http://xbmclogs.com/show.php?id=333776

[fritsch]

The ffmpeg versions differ - how is that?

[FernetMenta]

There is still a couple of changes in my master not merged to mainline. So is is absolutely possible that you observe issues with masinline and not with my master. If I thought that those changes did not improve anything, I would not maintain them.

[AndyFurniss]

If that's aimed @ me I haven't got a clue :-)

Both trees were distcleaned git clean -dfx and reset, though I did have to get back on master from saveme on one.

Using below it seems that I have pulled/built new ffmpeg today in both cases -

asr[xbmc]$ pwd
/home/andy/Src/FernetMenta/xbmc
asr[xbmc]$ ls -lh tools/depends/target/ffmpeg/
total 8.5M
-rwxrwxr-x 1 andy andy 4.0K Oct 22 20:00 autobuild.sh
drwxrwxr-x 16 andy andy 4.0K Oct 29 11:58 ffmpeg-2.4.2-Helix-alpha5
-rw-rw-r-- 1 andy andy 8.5M Oct 29 11:57 ffmpeg-2.4.2-Helix-alpha5.tar.gz
drwxrwxr-x 4 andy andy 4.0K Oct 29 12:04 ffmpeg-install
-rw-rw-r-- 1 andy andy 128 Oct 22 20:00 FFMPEG-VERSION
-rw-rw-r-- 1 andy andy 2.9K Oct 22 20:00 Makefile

asr[xbmc]$ cd ../../xbmc/
asr[xbmc]$ pwd
/home/andy/Src/xbmc
asr[xbmc]$ ls -lh tools/depends/target/ffmpeg/
total 8.5M
-rwxrwxr-x 1 andy andy 4.0K Oct 28 17:07 autobuild.sh
drwxrwxr-x 16 andy andy 4.0K Oct 29 12:45 ffmpeg-2.4.2-Helix-alpha5
-rw-rw-r-- 1 andy andy 8.5M Oct 29 12:44 ffmpeg-2.4.2-Helix-alpha5.tar.gz
drwxrwxr-x 4 andy andy 4.0K Oct 29 12:50 ffmpeg-install
-rw-rw-r-- 1 andy andy 128 Oct 28 17:07 FFMPEG-VERSION
-rw-rw-r-- 1 andy andy 2.9K Oct 28 17:07 Makefile

I still have both trees built of course so if you want config.log(s) I can upload, git status in both cases says

On branch master
Your branch is up-to-date with 'origin/master'.
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git checkout -- <file>..." to discard changes in working directory)

modified: xbmc/visualizations/Goom/goom2k4-0/mkinstalldirs

Untracked files:
(use "git add <file>..." to include in what will be committed)

tools/depends/target/ffmpeg/ffmpeg-2.4.2-Helix-alpha5.tar.gz
tools/depends/target/ffmpeg/ffmpeg-2.4.2-Helix-alpha5/

no changes added to commit (use "git add" and/or "git commit -a")

[fritsch]

If you might have too much time :-) you can start picking patches onto xbmc mainline (one after one) and find out which patch makes the difference. Take care: some of those need to be applied together.

[AndyFurniss]

Well knowing how to use git would have helped, but I managed to make some patches eventually and the winner is -

0001-VAAPI-implement-codec-control-flags.patch

toggling this will fix/replicate the issue and make the pullup detection logging disappear/appear.

To get a build/be able to apply I needed

0001-Revert-vdpau-comment-some-features-that-will-be-adde.patch
0001-dvdplayer-rename-codec-ctrl-flags.patch
0001-videoplayer-adapt-lateness-detection-and-dropping-to.patch
0001-video-player-present-correct-pts-to-user-for-a-v-syn.patch

to get fieldrate also needed is

0001-xbmc-pr-3080.patch

Of course there are other patches that look to be to do with stability/locking and I only tested briefly for this issue.

[fritsch]

See: https://github.com/xbmc/xbmc/pull/5698#i...t-62709028

[AndyFurniss]

Tested now it's in and working OK for me.