[fritsch]

This makes it work:

Code:

From 65120f92f671656d2a66012fb013f10728da344c Mon Sep 17 00:00:00 2001
From: fritsch <[email protected]>
Date: Sat, 1 Nov 2014 09:05:51 +0100
Subject: [PATCH] PGS Subs: Don't read from null ptr

---
xbmc/cores/dvdplayer/DVDCodecs/Overlay/DVDOverlayCodecFFmpeg.cpp | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/xbmc/cores/dvdplayer/DVDCodecs/Overlay/DVDOverlayCodecFFmpeg.cpp b/xbmc/cores/dvdplayer/DVDCodecs/Overlay/DVDOverlayCodecFFmpeg.cpp
index 72b9bca..326f9d2 100644
--- a/xbmc/cores/dvdplayer/DVDCodecs/Overlay/DVDOverlayCodecFFmpeg.cpp
+++ b/xbmc/cores/dvdplayer/DVDCodecs/Overlay/DVDOverlayCodecFFmpeg.cpp
@@ -294,9 +294,12 @@ CDVDOverlay* CDVDOverlayCodecFFmpeg::GetOverlay()
     uint8_t* t = overlay->data;
     for(int i=0;i<rect.h;i++)
     {
-      memcpy(t, s, rect.w);
-      s += rect.pict.linesize[0];
-      t += overlay->linesize;
+      if (s && t)
+      {
+        memcpy(t, s, rect.w);
+        s += rect.pict.linesize[0];
+        t += overlay->linesize;
+      }
     }

     for(int i=0;i<rect.nb_colors;i++)
--
1.9.1

Basically we read from a Null ptr. I will ping the original author to see if this fix is correct. I never did something with PGS Subs. Can you pick that patch and verify?

[shadow]

I'm not setup to compile right now since I just use the PPA but I'll look into compiling it again which I got tired of a long time ago.

[fritsch]

you can visit me on IRC, i can show you howto compile within three minutes :-)

[shadow]

I'll just refresh my memory from the Internet, it's just something I have not done in so long that my memory is fuzzy.

[fritsch]

I PRd that fix as it works for me and asked the team to review it more in detail.

Edit: https://github.com/xbmc/xbmc/pull/5617 <- PR

[shadow]

I have Kodi compiling now hopefully it works and is fast (testing on 5 year old laptop but still my fastest system)

[fritsch]

It's mainly:

Dependencies:

Code:

# this first thing is only needed as you run a very old ubuntu version
# which does not have libtag-dev in the correct version
sudo apt-add-repository ppa:wsnipex/xvba-dev
sudo apt-get update
sudo apt-get build-dep xbmc

Cloning / Patching

Code:

git clone https://github.com/xbmc/xbmc.git
cd xbmc
# now this is for the patch
git remote add fritsch https://github.com/fritsch/xbmc.git
git fetch fritsch
# now we cherry-pick the patch
git cherry-pick e172ee40afa5fcf1e4a3b7ea206dcf74e7861c3b

Building:

Code:

# in xbmc checkout directory
./bootstrap
# if backtrace is needed
./configure --enable-debug
# else if not
./configure --disable-debug --enable-optimizations
# use count processor cores  +1, quad core = 5, dual core = 3
make -j5

After build is finished, you can start the resulting binary with: ./kodi.bin

Best regards
Peter

Edit: Damn two minutes too late :-)

[shadow]

Don't worry that was some good info about doing the patch that I didn't know. I had just copy and pasted from this thread into a text file then applied it with "patch -p1 < ~/3dpatch"

---

Compile just finished and the patch did work for me. No crashing on the sample. I also tested a second movie with no problems either.

[fritsch]

Oki, cool. Then let's wait what other team members say.

[TonyPh12345]

Hey guys...

With my first 3D conversion, I'm having this same issue.

Commentary here stopped five months ago, and I see nothing in the TRAC about a fix being included.

Any news?