Bug TV shows not scraped correctly, Kodi 14 beta 2/3
#1
I think I have found a bug. I have made a clean install of OpenELEC 4.95.2 (Kodi 14 beta 2) on my RPi and found that only half of my TV shows showed up when scraped. Oddly, the shows that didn't show up are listed under "Recently added episodes".

Both some of the working shows and the non working shows has local nfo files and scraping these shows worked in earlier versions of Xbmc.

For troubleshooting I've copied two of the shows to a new directory and using that as the only source. The show that don't show up is "Genom Ryssland på 30 dagar".
Debug log: http://sprunge.us/ZHNj

I don't se any obvious errors in the log other than a 404 from the thetvdb.com. I don't know why the scraper talks to thetvdb when it has local nfo files.

Just updated to OE 4.95.3 (Kodi 14 beta 3), removed, cleaned and readded the source and the problem remains.

Does it look like my nfo files are bad or is the scraper messing things up?
I can post more info on my filestructure and the nfo files but I thought that I should keep my first post brief.
Reply
#2
Quote:09:38:27 1370.897339 T:2899309632 DEBUG: GetArt: Reading art for '-1' using The TVDB scraper (file: '/usr/share/kodi/addons/metadata.tvdb.com', content: 'tvshows', version: '1.5.8')
09:38:27 1370.900757 T:2899309632 DEBUG: scraper: GetArt returned <details><url function="ParseArt" cache="-1-banners.xml">http://thetvdb.com/api/1D62F2F90030C444/series/-1/banners.xml</url></details>
09:38:27 1370.902588 T:2899309632 DEBUG: CurlFile::Open(0xb4c0b5d0) http://thetvdb.com/api/1D62F2F90030C444/...anners.xml

This is definitely a bug, it shouldn't try to fetch the art if the series ID couldn't be determined.

Can you post one of the episode NFO files?
Reply
#3
Here is a nfo episode file:
Code:
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<episodedetails>
    <title>Genom Ryssland på 30 dagar, del 1</title>
    <showtitle>Genom Ryssland på 30 dagar</showtitle>
    <rating>0</rating>
    <season>1</season>
    <episode>1</episode>
    <plot>Finsk resereportageserie från 2010. Del 1 av 8. Under 30 dagar reser programledaren Ville Haapasalo med tåg genom Ryssland, från Moskva till Vladivostok. Resan börjar i hans andra hemstad - Moskva. Haapasalo är född och uppvuxen i Finland, men utbildade sig till skådespelare i Sankt Petersburg i början av 90-talet. Han åtnjuter stjärnstatus i Ryssland efter sin medverkan i ett par ryska filmsuccéer.
    </plot>
    <outline></outline>
    <mpaa></mpaa>
    <playcount>0</playcount>
    <lastplayed></lastplayed>
    <aired>2011-05-17</aired>
    <studio>YLE</studio>
    <fileinfo>
        <fileinfo>
            <streamdetails>
                <video/>
            </streamdetails>
        </fileinfo>
    </fileinfo>
</episodedetails>

And the tvshow.nfo just in case:
Code:
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<tvshow>
    <id>-1</id>
    <title>Genom Ryssland på 30 dagar</title>
    <rating></rating>
    <year>2010</year>
    <season>-1</season>
    <episode>-1</episode>
    <displayseason>-1</displayseason>
    <displayepisode>-1</displayepisode>
    <outline></outline>
    <plot>Finsk resereportageserie från 2010. Under 30 dagar reser programledaren Ville Haapasalo med tåg genom Ryssland, från Moskva till Vladivostok.
    </plot>
    <genre>Documentary</genre>
    <premiered>2010-08-13</premiered>
    <studio>YLE</studio>
</tvshow>
Reply
#4
People are saying this is an OE only issue since they include some patches that breaks this. Are you able to test stock Kodi on some other distro?
Reply
#5
there are no distros i think that don't have a heavily patched version of Kodi for the R-Pi.
So imo @popcornmix should drop the commits he included in his branch regarding the TVDB scraper.

since i knew about this i prevented a dev chasing ghost for this. So in short, if that patch is still included, no support from us about this topic unless it's confirmed that it is still a problem without those patches.

Note if we would push an update of our scraper to repo all r-pi would instantly be broken regarding tv shows
Read/follow the forum rules.
For troubleshooting and bug reporting, read this first
Interested in seeing some YouTube videos about Kodi? Go here and subscribe
Reply
#6
(2014-11-19, 19:35)negge Wrote: People are saying this is an OE only issue since they include some patches that breaks this. Are you able to test stock Kodi on some other distro?

OK, I managed to install Kodi on my really old Linux Mint 13 box. This time it merged the two shows to one show with 18 episodes!?

Log file: http://sprunge.us/KJNG

For testing I copied the nfo files to a new dir and created 0 byte mp4 files, please ignore the errors "ERROR: ffmpeg[AB8FEB40]: [mov,mp4,m4a,3gp,3g2,mj2] moov atom not found".
Reply
#7
Do you use the same ID in both tvshow.nfo files?
Reply
#8
Yes, it is -1 (negative one) and I think i read somewhere that it should be when you created your own tvshow.nfo files. What value is safe to use as ID if should change it?
Reply
#9
(2014-11-19, 19:53)Martijn Wrote: there are no distros i think that don't have a heavily patched version of Kodi for the R-Pi.
So imo @popcornmix should drop the commits he included in his branch regarding the TVDB scraper.

since i knew about this i prevented a dev chasing ghost for this. So in short, if that patch is still included, no support from us about this topic unless it's confirmed that it is still a problem without those patches.

Note if we would push an update of our scraper to repo all r-pi would instantly be broken regarding tv shows

Do you know what the commit is that causes the problem? This is the only one I can think of:
https://github.com/jmarshallnz/xbmc/comm...93dc38ab94
Reply
#10
Edit: ignore, I can't really reproduce.

It seems it behaves as intended. The nfo has <id>-1</id> and it tries to find arts for a show with (scraper) ID -1 (Reading art for '-1').

Just guessing, but this doesn't seem completely correct: https://github.com/jmarshallnz/xbmc/comm...733034R935
It seems that if it fails to grab arts, then infotags are empty. I think this causes the shows to not get added to the library.
I'd move that before video.Load(). It is in a for, so: if (!fRet) video.Reset();
Reply
#11
(2014-11-19, 22:16)menakite Wrote: Just guessing, but this doesn't seem completely correct: https://github.com/jmarshallnz/xbmc/comm...733034R935
It seems that if it fails to grab arts, then infotags are empty. I think this causes the shows to not get added to the library.
I'd move that before video.Load(). It is in a for, so: if (!fRet) video.Reset();

Like: https://github.com/popcornmix/xbmc/commi...bb3732a8ec ?
Reply
#12
(2014-11-19, 22:37)popcornmix Wrote:
(2014-11-19, 22:16)menakite Wrote: Just guessing, but this doesn't seem completely correct: https://github.com/jmarshallnz/xbmc/comm...733034R935
It seems that if it fails to grab arts, then infotags are empty. I think this causes the shows to not get added to the library.
I'd move that before video.Load(). It is in a for, so: if (!fRet) video.Reset();

Like: https://github.com/popcornmix/xbmc/commi...bb3732a8ec ?
I think that should be correct. I have just edited my previous post as I really can't reproduce using the same NFOs, though.
Both the show and the episode (1) get scanned correctly. Both are missing arts but that's expected.

Edit: multiple seasons with multiple episodes, still working fine.
Reply
#13
The above change is included in my latest build here which nikstra could help testing. If it doesn't resolve the issue then we can look at possibly reverting all of the jmarshall commits to confirm if they are the cause. I'm not aware of any other scraper-related patches in the OpenELEC Pi builds.

Alternatively nikstra should create a reproducible test case (archive of test files) and upload it somewhere.
Texture Cache Maintenance Utility: Preload your texture cache for optimal UI performance. Remotely manage media libraries. Purge unused artwork to free up space. Find missing media. Configurable QA check to highlight metadata issues. Aid in diagnosis of library and cache related problems.
Reply
#14
Upgraded to the Milhouse build and now I get the same behaviour on the RPi as on Linux Mint box. All shows with an ID of -1 in tvshow.nfo has their episodes under the same show title. Should I remove the <id> tags or how do I select a unique value for them?

Here is the log while I'm adding the test source /storage/nas/videos/TVdbg which scraped OK with different ID's and then removing that source and then adding the reals source /storage/nas/videos/TV.
http://sprunge.us/Ybjc
Reply
#15
Updated to OE beta 4 and it is still not working. Cleared library and rescanned and it merged all episodes with nfo files into one single TV show.

I deleted ~/.kodi and added back the source. This time it didn't scan the library until I did it manually. Then it merged all episodes as before.

http://sprunge.us/ULGA
Reply

Logout Mark Read Team Forum Stats Members Help
TV shows not scraped correctly, Kodi 14 beta 2/30