[RFC] Regarding pull request #5946 "Allow up to 30 days to display in the EPG"?
#1
bkuhls have submitted a pull request to change the maximum amount of days displayed in the EPG to be changed to 30 here

https://github.com/xbmc/xbmc/pull/5946

But I am wondering if it should be changed then would it not be more logical to either change it to 28-days (for 4-weeks) or change it to 31-days (for amount of days in the longest months) instead make more sense than 30-days as the maximum?

All I'm saying is that when it comes to days, weeks, and months it probably does not make sense to use the number "30" as a maximum to allow.

Yes 30 days is a round number when divided by 10, however calender dates like days, weeks, and months i a year are not divided by 10.

So would it not be more not be more logical to divide an EPG into an amount of days that can be devised by 7 (days)?

If so then either have it 28-days (for 4-weeks), or 35-days (for 5-weeks), or a month which are usually 30 or 31 days, so maximum would then be 31 days to display, or?
Reply
#2
Makes sense.
Reply
#3
How about making it user defined under UI PVR settings? Keep the original default and add 1, 3, 5, 7, 14, 21, 28, etc. No, not a Fibonacci sequence.
Reply
#4
(2014-12-16, 13:04)Hedda Wrote: Yes 30 days is a round number
That´s the reason I chose it. At the end I do not care what the max.
value is, as long as it is >28 Wink I will have a look at MAXBLOCKS.
Kodi 19.5-Matrix/OpenGLES/gbm (+ PR19558 ) - Linux kernel 5.14.21 x86_64 - ffmpeg 4.4-git (+ patch )
Mesa 22.3.7 with iris driver - VA-API version 1.16.0 + Intel iHD driver version 22.6.3 - libdrm 2.4.116 - libcec 6.0.2
Intel i9-11900T - ASRock Z590 Extreme - BIOS version 2.20
Reply
#5
(2014-12-16, 23:24)h.udo Wrote: How about making it user defined under UI PVR settings? Keep the original default and add 1, 3, 5, 7, 14, 21, 28, etc. No, not a Fibonacci sequence.

+1
Reply
#6
Any caching beyond a week is silly... Lineups can change on a weekly basis, Unless kodi checks for listing changes... cached data will become stale.
Image Lunatixz - Kodi / Beta repository
Image PseudoTV - Forum | Website | Youtube | Help?
Reply
#7
(2014-12-20, 01:24)Lunatixz Wrote: Any caching beyond a week is silly...
-1
There are programs like the New Year's Concert of the Vienna Philharmonic orchestra which are broadcasted live at the same time for decades now.
Kodi 19.5-Matrix/OpenGLES/gbm (+ PR19558 ) - Linux kernel 5.14.21 x86_64 - ffmpeg 4.4-git (+ patch )
Mesa 22.3.7 with iris driver - VA-API version 1.16.0 + Intel iHD driver version 22.6.3 - libdrm 2.4.116 - libcec 6.0.2
Intel i9-11900T - ASRock Z590 Extreme - BIOS version 2.20
Reply
#8
(2014-12-20, 01:24)Lunatixz Wrote: Any caching beyond a week is silly... Lineups can change on a weekly basis, Unless kodi checks for listing changes... cached data will become stale.

Kodi updates the epg at runtime so this works fine. You also have the possibility to change the interval how often it's done.
Reply
#9
New PR: https://github.com/xbmc/xbmc/pull/6136
Kodi 19.5-Matrix/OpenGLES/gbm (+ PR19558 ) - Linux kernel 5.14.21 x86_64 - ffmpeg 4.4-git (+ patch )
Mesa 22.3.7 with iris driver - VA-API version 1.16.0 + Intel iHD driver version 22.6.3 - libdrm 2.4.116 - libcec 6.0.2
Intel i9-11900T - ASRock Z590 Extreme - BIOS version 2.20
Reply
#10
Can you please change the new pull request #6136 to 31-days as per discussion above?
Reply
#11
(2015-01-08, 19:54)Hedda Wrote: Can you please change the new pull request #6136 to 31-days as per discussion above?
Done
Kodi 19.5-Matrix/OpenGLES/gbm (+ PR19558 ) - Linux kernel 5.14.21 x86_64 - ffmpeg 4.4-git (+ patch )
Mesa 22.3.7 with iris driver - VA-API version 1.16.0 + Intel iHD driver version 22.6.3 - libdrm 2.4.116 - libcec 6.0.2
Intel i9-11900T - ASRock Z590 Extreme - BIOS version 2.20
Reply

Logout Mark Read Team Forum Stats Members Help
[RFC] Regarding pull request #5946 "Allow up to 30 days to display in the EPG"?0