[necbot]

I had a script that ran fine on XBMC Gotham, however when I upgraded to Kodi I encountered the following problem. I create a list item like this...

Code:

litem = xbmcgui.ListItem(label='Title', label2='Other meta info here', iconImage='icon_resource_name.png')

The icon and label display fine but label2 does not. I checked the documentation and the api has not changed. Any help would be appreciated. Thanks!

[Karnagious]

Some skins dont display the second label.

What skin is being used?

[necbot]

Confluence. I was using confluence before and label2 worked.

[Karnagious]

What window?

[necbot]

The window that I'm not seeing label2 on is a modification of the transmission addon. The transmission addon is a GUI frontend to transmission daemon. I never like the way it displayed the search results so I created my own script in which the search results display in a control list. My script worked fine on Gotham, it doesn't in Helix. I can post my code if you want.

[Karnagious]

Couldnt hurt.

[necbot]

Here is the class that creates the window containing the search results...

Code:

# -*- coding: utf-8 -*-
# Copyright (c) 2010 Correl J. Roush

import sys
import base64
import threading
import xbmc
import xbmcgui
from basictypes.bytes import Bytes
import transmissionrpc
import searchall
import common
import os
import traceback

from default import BASE_MEDIA_PATH

_ = sys.modules[ "__main__" ].__language__
__settings__ = sys.modules[ "__main__" ].__settings__

KEY_BUTTON_BACK = 275
KEY_KEYBOARD_ESC = 61467
KEY_MENU_ID = 92

EXIT_SCRIPT = ( 6, 10, 247, 275, 61467, 216, 257, 61448, )
CANCEL_DIALOG = EXIT_SCRIPT + ( 216, 257, 61448, )

UPDATE_INTERVAL = 1.0

STATUS_ICONS = {'stopped': 'pause.png',
                'seeding': 'ok.png',
                'downloading': 'down.png'}

class TransmissionGUI(xbmcgui.WindowXMLDialog):
    def __init__(self, strXMLname, strFallbackPath, strDefaultName, bforeFallback=0):
        self.list = {}
        self.torrents = {}
        self.timer = None
    def set_settings(self, params):
        __settings__.setSetting('rpc_host', params['address'])
        __settings__.setSetting('rpc_port', params['port'])
        __settings__.setSetting('rpc_user', params['user'])
        __settings__.setSetting('rpc_password', params['password'])
    def onInit(self):
        p = xbmcgui.DialogProgress()
        p.create(_(32000), _(32001)) # 'Transmission', 'Connecting to Transmission'
        try:
            self.transmission = common.get_rpc_client()
        except:
            p.close()
            self.close()
            (type, e, traceback) = sys.exc_info()
            message = _(32900) # Unexpected error
            if type is transmissionrpc.TransmissionError:
                if e.original:
                    if e.original.code is 401:
                        message = _(32902) # Invalid auth
                    else:
                        message = _(32901) # Unable to connect
                if xbmcgui.Dialog().yesno(_(32002), message, _(32003)):
                    __settings__.openSettings()
            elif type is ValueError:
                # In python 2.4, urllib2.HTTPDigestAuthHandler will barf up a lung
                # if auth fails and the server wants non-digest authentication
                message = _(32902) # Invalid auth
                if xbmcgui.Dialog().yesno(_(32002), message, _(32003)):
                    __settings__.openSettings()
            else:
                message = _(32900) # Unexpected error
                xbmcgui.Dialog().ok(_(32002), message)
            return False
        self.updateTorrents()
        p.close()
        self.timer = threading.Timer(UPDATE_INTERVAL, self.updateTorrents)
        self.timer.start()
    def updateTorrents(self):
        list = self.getControl(120)
        self.torrents = self.transmission.info()
        for i, torrent in self.torrents.iteritems():
            statusline = "[%(status)s] %(down)s down (%(pct).2f%%), %(up)s up (Ratio: %(ratio).2f)" % \
                {'down': Bytes.format(torrent.downloadedEver), 'pct': torrent.progress, \
                'up': Bytes.format(torrent.uploadedEver), 'ratio': torrent.ratio, \
                'status': torrent.status}
            if i not in self.list:
                # Create a new list item
                l = xbmcgui.ListItem(label=torrent.name, label2=statusline)
                list.addItem(l)
                self.list[i] = l
            else:
                # Update existing list item
                l = self.list[i]
            l.setLabel(torrent.name)
            l.setLabel2(statusline)
            l.setProperty('TorrentStatusIcon', STATUS_ICONS.get(torrent.status, 'pending.png'))
            l.setProperty('TorrentID', str(i))
            l.setProperty('TorrentProgress', "%3d%%" % torrent.progress)

        removed = [id for id in self.list.keys() if id not in self.torrents.keys()]
        if len(removed) > 0:
            # Clear torrents from the list that have been removed
            for id in removed:
                del self.list[id]
            list.reset()
            for id, item in self.list.iteritems():
                list.addItem(item)
        list.setEnabled(bool(self.torrents))

        # Update again, after an interval, but only if the timer has not been cancelled
        if self.timer:
          self.timer = threading.Timer(UPDATE_INTERVAL, self.updateTorrents)
          self.timer.start()
    def onClick(self, controlID):
        list = self.getControl(120)
        if (controlID == 111):
            kb = xbmc.Keyboard('', 'Search')
            kb.doModal()
            if not kb.isConfirmed():
                return
            terms = kb.getText()
            p = xbmcgui.DialogProgress()
            p.create(_(32000), _(32290))
            try:
                engines = searchall.SearchAllMt(1, terms)
                engines.search()
                results = engines.torrents
            except Exception as e:
                traceback.print_exc()
                # xbmcgui.Dialog().ok("tracking error", str(traceback.format_exc()))
                p.close()
                xbmcgui.Dialog().ok(_(32000), _(32292))
                return
            p.close()
            if not results:
                xbmcgui.Dialog().notification(_(32000), 'No Torrents Found', xbmcgui.NOTIFICATION_INFO)
                return

            srw = SearchResults("script-Transmission-searchresults.xml", __settings__.getAddonInfo('path'), "Default")
            srw.transmission = self.transmission
            srw.results = results
            srw.doModal()
            del srw
            return
        if (controlID == 112):
            # Remove selected torrent
            item = list.getSelectedItem()
            selected_rm = xbmcgui.Dialog().select(_(32000),['Torrent and Data','Torrent','Cancel'])
            if selected_rm == 0 and item:
                self.transmission.remove(int(item.getProperty('TorrentID')), True)
            elif selected_rm == 1 and item:
                self.transmission.remove(int(item.getProperty('TorrentID')), False)

        if (controlID == 113):
            # Stop selected torrent
            item = list.getSelectedItem()
            if item:
                self.transmission.stop(int(item.getProperty('TorrentID')))
        if (controlID == 114):
            # Start selected torrent
            item = list.getSelectedItem()
            if item:
                self.transmission.start(int(item.getProperty('TorrentID')))
        if (controlID == 115):
            # Stop all torrents
            self.transmission.stop(self.torrents.keys())
        if (controlID == 116):
            # Start all torrents
            self.transmission.start(self.torrents.keys())
        if (controlID == 117):
            # Exit button
            self.close()
        if (controlID == 118):
            # Settings button
            prev_settings = common.get_settings()
            __settings__.openSettings()
            p = xbmcgui.DialogProgress()
            p.create(_(32000), _(32001)) # 'Transmission', 'Connecting to Transmission'
            try:
                self.transmission = common.get_rpc_client()
                self.updateTorrents()
                p.close()
            except:
                p.close()
                xbmcgui.Dialog().ok(_(32002), _(32901))
                # restore settings
                self.set_settings(prev_settings)
                try:
                    self.transmission = common.get_rpc_client()
                except err:
                    xbmcgui.Dialog().ok(_(32002), _(32901))
                    self.close()
        if (controlID == 120):
            # A torrent was chosen, show details
            item = list.getSelectedItem()
            w = TorrentInfoGUI("script-Transmission-details.xml", __settings__.getAddonInfo('path') ,"Default")
            w.setTorrent(self.transmission, int(item.getProperty('TorrentID')))
            w.doModal()
            del w
    def onFocus(self, controlID):
        pass

    def onAction( self, action ):
        if ( action.getButtonCode() in CANCEL_DIALOG ) or (action.getId() == KEY_MENU_ID):
            self.close()
    def close(self):
        if self.timer:
            self.timer.cancel()
            self.timer.join()
        super(TransmissionGUI, self).close()


class SearchResults(xbmcgui.WindowXMLDialog):
    def __init__(self, strXMLname, strFallbackPath, strDefaultName):
        self.results = []
        self.transmission = None

    def onInit(self):
        bkgrd_img_path = os.path.join(BASE_MEDIA_PATH, 'transmission-dialog.png')
        self.bkgrd_image = xbmcgui.ControlImage(0, 0, 850, 540, bkgrd_img_path)
        self.addControl(self.bkgrd_image)

        self.close_button = xbmcgui.ControlButton(740, 0, 64, 32, '',
                                                  'DialogCloseButton-focus.png', 'DialogCloseButton.png')
        self.addControl(self.close_button)

        self.rlist = xbmcgui.ControlList(32, 32, 790, 520,
                                         buttonFocusTexture='list-bg-selected-nofocus.png',
                                         _itemTextXOffset=5, _itemTextYOffset=-1, _imageWidth=16,
                                         _imageHeight=16)
        self.addControl(self.rlist)

        for result in self.results:
            label = '%s' % result['name']
            label2 = '%s (%d)' % (result['size'], result['seeds'])
            litem = xbmcgui.ListItem(label=label, label2=label2, iconImage=result['icon'])
            self.rlist.addItem(litem)

        self.setFocus(self.rlist)

    def onAction( self, action ):
        if ( action.getButtonCode() in CANCEL_DIALOG ) or (action.getId() == KEY_MENU_ID):
            self.close()

    def onClick(self, control):
        sel_pos = self.rlist.getSelectedPosition()
        if control == self.close_button.getId():
            self.close()
        elif control == self.rlist.getId():
            try:
                self.transmission.add_torrent(self.results[sel_pos]['url'])
                self.rlist.removeItem(sel_pos)
                self.results.pop(sel_pos)
                if sel_pos == self.rlist.size():
                    self.rlist.selectItem(sel_pos-1)
                else:
                    self.rlist.selectItem(sel_pos)
            except:
                xbmcgui.Dialog().notification(_(32000), _(32293), xbmcgui.NOTIFICATION_ERROR)


class TorrentInfoGUI(xbmcgui.WindowXMLDialog):
    def __init__(self, strXMLname, strFallbackPath, strDefaultName, bforeFallback=0):
        self.transmission = None
        self.torrent_id = None
        self.list = {}
        self.timer = None
    def setTorrent(self, transmission, t_id):
        self.transmission = transmission
        self.torrent_id = t_id
        self.timer = threading.Timer(UPDATE_INTERVAL, self.updateTorrent)
        self.timer.start()
    def updateTorrent(self):
        pbar = self.getControl(219)
        list = self.getControl(220)
        labelName = self.getControl(1)
        labelStatus = self.getControl(2)
        labelProgress = self.getControl(11)
        torrent = self.transmission.info()[self.torrent_id]
        files = self.transmission.get_files(self.torrent_id)[self.torrent_id]

        statusline = "[%(status)s] %(down)s down, %(up)s up (Ratio: %(ratio).2f)" % \
            {'down': Bytes.format(torrent.downloadedEver), 'pct': torrent.progress, \
            'up': Bytes.format(torrent.uploadedEver), 'ratio': torrent.ratio, \
            'status': torrent.status}
        if torrent.status is 'downloading':
            statusline += " ETA: %(eta)s" % \
                    {'eta': torrent.eta}

        labelName.setLabel(torrent.name)
        labelStatus.setLabel(statusline)
        labelProgress.setLabel('%3d%%' % (torrent.progress))
        pbar.setPercent(torrent.progress)

        for i, file in files.iteritems():
            if i not in self.list:
                # Create a new list item
                l = xbmcgui.ListItem(label=file['name'])
                list.addItem(l)
                self.list[i] = l
            else:
                # Update existing list item
                l = self.list[i]
            l.setProperty('Progress', '[%3d%%]' % (file['completed'] * 100 / file['size']))

        # Update again, after an interval
        self.timer = threading.Timer(UPDATE_INTERVAL, self.updateTorrent)
        self.timer.start()
    def onInit(self):
        self.updateTorrent()
    def close(self):
        if self.timer:
            self.timer.cancel()
            self.timer.join()
        super(TorrentInfoGUI, self).close()
    def onAction(self, action):
        if (action.getButtonCode() in CANCEL_DIALOG) or (action.getId() == KEY_MENU_ID):
            self.close()
            pass
    def onClick(self, controlID):
        if controlID == 111:
            self.close()
    def onFocus(self, controlID):
        pass

if __name__ == '__main__':
    print 'test'

XML:

Code:

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<window>
    <defaultcontrol>111</defaultcontrol>
    <allowoverlay>yes</allowoverlay>
    <coordinates>
        <system>1</system>
        <posx>180</posx>
        <posy>70</posy>
    </coordinates>
</window>

[Karnagious]

And the xml?

And the code calling this window?

[belese]

Hi

I've got same problem for an addon i've developped for XBian, (label1 and label2 have disapeared too for me)
it was ok for gotham (frodo too), but not for Kody
it's not me that have fixed this,
but looks like it was due to the position of label, something must have changed in Kodi

here's the fix if it can help :
https://github.com/xbianonpi/xbian-packa...11087871da

Belese

XML is a template, but this part of code is fixed, only content item is added at runtime.

[necbot]

I posted the code that calls the SearchResults window and it's XML. I also tried rewriting this class as a WindowDialog subclass and the result is still the same, label2 does not show up.

[necbot]

@belese

It looks like you're using XML to specify the position of your list item label and label2. I could try this approach. For example I could wait for the search results and generate a temporary xml file with a list item for each result where I explicitly specify the positions of label1 and label2 the way you did. If this bug isn't fixed I may do this, but it seems like a clunky work around for something that should work the way I have it implemented right now.

[ronie]

we made some alignment changes to labels inside containers in Kodi Helix.
see: 1718582 (post)

you just need to update the skin part of your addon.

[belese]

Thanks, i've got the explanation now.