[Hitcher]

EDIT: Store the skin screenshot folder unzipped on the repo so skin's can access it.

Original post -

Is it possible to get a skin's _screenshots folder path?

I would like to use them in DialogAddoInfo.

Thanks.

[jurialmunkey]

cant you just use

Code:

special://skin/_screenshots

edit: now I realize what you are asking: for skins other than the current one. Thought that was too easy....

edit: the following works for a multiimage control. Would need to use a variable to check for confluence as its not in the special://home folder. There's also the problem of not being able to check if the folder is empty.

Code:

$INFO[ListItem.Filename,special://home/addons/,/_screenshots/]

[Hitcher]

Sorry I should have mentioned it was for other skins, and also for skins in repos.

I've tried using ListItem.Property(Addon.Path) but that's actually file name and path so you end up with this -

Code:

http://mirrors.xbmc.org/addons/gotham/skin.conq/skin.conq-1.2.0.zip

EDIT: Never mind, looks we couldn't use that anyway if it was just the path because the screenshot folder is zipped.

I'll use you method for locally stored ones though, thanks.

[jurialmunkey]

Ah I see now. This actually makes a lot of sense to be able to browse the screenshots before deciding on whether to download a skin. This could work well as a built-in button in the info dialog that loads a slideshow of the screenshots.

[wyrm]

Is it possible to get a skin's _screenshots folder path?

I would like to use them in DialogAddoInfo.

Thanks.

Hitcher,

This is something I asked about previously. One thing I did not realise and I guess you did not as well is that when skins are packaged up for inclusion in the repo, the screenshot directory is removed.

So in short there is NO screenshots directory for you to make use of.

Wyrm (AppTV)

[Hitcher]

So they are! What a missed opportunity.

[Hitcher]

I'm not one to give up on a good idea so I thought I'd try loading the ZIP URL as dynamic content.

eg <content target="images">http://mirrors.xbmc.org/addons/gotham/skin.titan/screenshots.zip</content>

and this is what happened -

Code:

07:45:35 T:13136    INFO: XCURL::DllLibCurlGlobal::easy_aquire - Created session to http://mirrors.xbmc.org
07:45:35 T:13136   DEBUG: CCurlFile::GetMimeType - http://mirrors.xbmc.org/addons/gotham/skin.titan/screenshots.zip -> application/zip
07:45:36 T:4912   DEBUG: CWinEventsWin32::WndProcWindow is active
07:45:36 T:4912   DEBUG: CWinEventsWin32::WndProc: Focus switched to process C:\Program Files (x86)\Notepad++\notepad++.exe
07:46:05 T:7580   DEBUG: Thread JobWorker 7580 terminating (autodelete)
07:46:05 T:4912   DEBUG: SECTION:UnloadDelayed(DLL: special://xbmcbin/system/ImageLib.dll)
07:46:05 T:13136   DEBUG: Thread JobWorker 13136 terminating (autodelete)
07:46:05 T:4912    INFO: XCURL::DllLibCurlGlobal::CheckIdle - Closing session to http://mirrors.xbmc.org (easy=04B69918, multi=00000000)

ListItem Label returned skin.titan but ListItem.Icon was empty.

Can a ZIP be used this way?

[ronie]

I'm not one to give up on a good idea so I thought I'd try loading the ZIP URL as dynamic content.

i wouldn't qualify that as a good idea.
in fact, imo it would be a very bad idea if skins start to download stuff.

use a script if you have to, but not this way please.

[Hitcher]

Any reason as to why the screenshot folder is zipped ronie?

It seems like a great feature - preview of a skin's (or any addon for that matter) look, feel and layout - is almost available but not quite.

[ronie]

Any reason as to why the screenshot folder is zipped ronie?

It seems like a great feature - preview of a skin's (or any addon for that matter) look, feel and layout - is almost available but not quite.

years ago one of the devs (i think it was theuni) came up with the screenshots idea.
we had quite some plans with them back then, though i can't remember exactly what they were.

since then i've been pushing skin devs to add screenshots, bugging them about the images sizes, filename conventions and what more...
and what have we done with the screenshots in all those years? absolutely nothing!

that makes me feels bad. i feel bad about forcing work upon you guys that goes wasted in the end.
as far as i'm concerned skins can drop that _screenshots folder. it doesn't serve any purpose at all.


but to answer your question: i don't know :-)

[Hitcher]

The only place I know they're used is here -

http://kodi.wiki/view/Skin_screenshots

but it doesn't appear to be an automated process from the repos.

[zag]

since then i've been pushing skin devs to add screenshots, bugging them about the images sizes, filename conventions and what more...
and what have we done with the screenshots in all those years? absolutely nothing!

The reason nothing was done was because they where zipped

If they can be unzipped on the mirrors, we can start having some really cool stuff.

[ronie]

since then i've been pushing skin devs to add screenshots, bugging them about the images sizes, filename conventions and what more...
and what have we done with the screenshots in all those years? absolutely nothing!

The reason nothing was done was because they where zipped

If they can be unzipped on the mirrors, we can start having some really cool stuff.

they are unzipped in our github repo,
wouldn't it be possible to fetch them from there?
https://github.com/xbmc/repo-skins/tree/jarvis

[User 224999]

Something for the skin helper addon maybe ;-)