[Amelandbor]

Hey guys, I need some help for my subtitle addon.

When I try to extract zip or rar files, often but not always I get errors like this:

Code:

ZipManager: unable to open file

or

Code:

rarmanager::extractarchive error while extracting

When I try to open the temporary files with 7zip it works fine.

I don't know if it's something in my code or something wrong with XBMC.Extract

My code is located at https://github.com/Amelandbor/service.su...ndertitels

[ironic_monkey]

link to one of them broken files. code looks fine.

[Amelandbor]

This is one of the files which is going wrong for example.
http://www.nlondertitels.com/download/35247

[ironic_monkey]

https://github.com/notspiff/kodi-cmake/c...fdb904fe59

takes care of the zip files. stupid idiot software developers inventing their own standards :/

for rar i need a broken file.

and no, i don't know if upstream will grab it or not. it's fine if they do, but i cba to do deal with the bureaucracy.

[Amelandbor]

Example for rar file:

http://www.nlondertitels.com/download/35201

If I understand correctly what you're saying, this is packed with software that isn't following standards?

[ironic_monkey]

well, sort of.

originally there was no header for the data record entry in zip files - it just used a local entry header (ie the same header that is used for each file inside the zip file). peeps didn't like this, and started writing files with a different header to mark the data record section. the zip standard has been altered in retrospect since these files got so abundant out in the wild, forcing all zip implementation to basically handle what was originally out-of-spec files.

[ironic_monkey]

the rar one is more involved. you'd have to bump the rar code to get support for the newer compression schemes.

[Amelandbor]

After reading into it, apparently the idea is to switch to libarchive, but the last work/info I could find about that was from May 2014.

I guess I'll have to wait for that.

Thanks for your help and info.

[Ace]

https://github.com/xbmc/xbmc/pull/6589

[Amelandbor]

Thanks for the PR Ace

[phate89]

Is this going to fix this zip too?
http://trac.kodi.tv/ticket/15191

[ironic_monkey]

nope. https://github.com/notspiff/kodi-cmake/c...6253ede825 will though.

[Ace]

PR updated.

[phate89]

PR updated.

Thanks both