(2015-06-23, 11:31)jjd-uk Wrote: (2015-06-23, 00:48)Ned Scott Wrote: I don't like the idea of adding another setting that someone has to hunt down and flip before being able to use an option that is already in our UI.
Why not? the whole point is putting an extra hoop in place for users to jump through so we can point to out to anyone who asks that only add-ons in the Official repository can be installed by default, thus the only way a pirate add-on will get onto a system using a vanilla install of Kodi is for the user to have made a conscious effort themselves to allow this and then carry out the install themselves.
I made the same argument about just adding one extra click to show "Kodi.tv add-on repository" when people install by repo in v15, rather than flattening it when there is only one repo, and the idea was quickly shot down. I've since been swayed the the argument that it wasn't a good idea, and I worry about how far is "reasonable" to show a message or warning.
We shouldn't make it harder to install add-ons from a zip file. We're not trying to stop piracy add-ons from being installed. We're only trying to let people made an informed decision.
Quote: (2015-06-23, 00:48)Ned Scott Wrote: As for pre-configured boxes, I don't think this will help significantly. They'll make modified versions that remove the warning. Several venders already do this for various other little things. They know how to do it, and it will just turn into a silly cat and mouse game.
Actually most vendors are stupid, lazy and just out to make a quick buck with as little effort as necessary, I doubt any changes made are beyond the skin/xml level, thus if we do something in the C++ code I doubt many will bother making any changes. The only the exception might be the TVMC guys, but that would also be a good thing if it drives more vendors to use their fork instead of using vanilla Kodi as they might start marketing it as as TVMC box rather than a Kodi box, thus helping to distance ourselves from the piracy community.
This is what a lot of venders already do, except they're not using "TVMC" which is renamed. They're using versions that the community has made that preloads things. There are add-on authors "for hire" (and for cheap) that will help pre-configure Kodi installs for venders. That's how they come with add-ons reloaded or customized backgrounds. It doesn't take a C++ programmer to bypass something like this. It only requires that someone change a value in guisettings.xml or something like that.
While I haven't gotten an Android box lately, about a year ago I had two of them that were like that. The venders aren't smart, but they don't have to be smart to get past something like this. They just copy someone else's work or get some python scripter to do it for them.
So again, I think the goal here shouldn't be about stopping people, but just helping them make an informed decision.
On that note, I think we should just show a warning on-screen and not as a pop-up. I don't know how possible this would be without some code changes, but whenever you go into "install from zip" you then go into a unique list layout instead of the generic list layout, and that has a warning on-screen that is built into Confluence. It would always be there, it would be the kind of thing that venders wouldn't care about removing and it wouldn't already be "dismissed", and it wouldn't make installing from a zip any harder than it is now.