Add support for tag in opus files
#1
Hi all,

It would be nice to add support for opus tag in future releases of Kodi. Indeed while is currently possible to play opus file, is not possible to add them to the Music library, that is a key characteristic for a media center.

Thanks
Reply
#2
https://github.com/xbmc/xbmc/pull/8925
Reply
#3
Thanks for taking a look at this Smile
Reply
#4
Initailly this only supports title, artist, album, and track tags. I have offered to extend to include other standard, things that Kodi music library processes, not that I know much about Opus file tagging. Anything to say about that Protomucca that I should know?
Reply
#5
"opus tags" are vorbis comments.
Reply
#6
No problem then. How about the .mka, .dff and .dsf formats, are they Vorbis too?

I'll get in there once 8925 has merged.
Reply
#7
they are not. that was my initial reason for meh'ing on that part of the tag loader. afaik (i haven't investigated this a lot) the dictionary ffmpeg provides does not use common tag keys, so they might vary slightly across tag formats. title artist etc is fairly safe so that's why i only did those.

dsf/dff is aiff. mka is matroska (container level) tags.
Reply
#8
So I need to do some research then, OK.
Reply
#9
Many thanks to have taken care of this request
Reply
#10
Just installed the latest nightly build, and opus files are now correctly added to the library. Thanks
Reply
#11
(2016-02-01, 17:59)protomucca Wrote: Just installed the latest nightly build, and opus files are now correctly added to the library. Thanks

Not working ok for me.

Just compiled master branch of kodi today (3/2/16)

opus thumbnails are not displayed and are not added to the textures db, and the song duration is not being added to "iDuration" in the music db.
Reply
#12
none of those are expected to work.
Reply
#13
Currently only uses (single) artist, title, album and tracknumber tags. When I get chance I will look to add more, but have not found the ffmpeg documentation for what tags it processes yet.

Just a thought, any reason Ironic_Monkey why OPUS was implemented using ffmpeg rather than TagLib? I think it supports that format too, and we have the Vorbis/Xiph tag process ready to go in that unit, would just need to enable "OPUS" as a format. It may not be that easy, I only know the library side of things.
Reply
#14
if taglib can do opus now, use taglib. it couldn't when i did the code..
Reply
#15
@ ironic_monkey

I should have looked at the original PR before posting

@ DaveBlake

As ironic_monkey said it's vorbis comments.
https://xiph.org/vorbis/doc/v-comment.html

I've found that not a lot programs can tag .opus files directly without putting them in another container (ie.mp4) but
TagScanner http://www.xdlab.ru/en/ does the job nicely. (might be useful for testing)
Reply

Logout Mark Read Team Forum Stats Members Help
Add support for tag in opus files0