[Kodi 17] Cancel button in DialogSelect.xml
#1
I just started updating Rapier for Krypton, and have some issues with the cancel button in DialogSelect.xml.

When using Artwork Downloader to select art, I used to have a cancel button in the bottom.

When using the new cancel button with id=7, the button is there, but it doesn't have a label or onclick function.
I tried adding my own cancel button using !Control.IsVisible(7), but it doesn't work as the button is physically there. I can use IsEmpty(Control.GetLabel(7)), but that seems a bit far fetched.

Image

Other than that issue, the button seems to work as expected.
Reply
#2
not only skins, but addons utilizing the select dialog need to update their code as well.

just in case any addon dev stumbles across this post, here are some examples of what needs to be done:
- script.favourites: https://github.com/ronie/script.favourit...80ede9a146
- script.image.resource.select: https://github.com/ronie/script.image.re...7f75a85fda
Do not PM or e-mail Team-Kodi members directly asking for support.
Always read the Forum rules, Kodi online-manual, FAQ, Help and Search the forum before posting.
Reply
#3
I see. Thanks for the fast reply - that's very helpful.

I hope Artwork Downloader will make use of the new cancel button then Smile
Reply
#4
(2016-02-15, 14:02)ronie Wrote: not only skins, but addons utilizing the select dialog need to update their code as well.

just in case any addon dev stumbles across this post, here are some examples of what needs to be done:
- script.favourites: https://github.com/ronie/script.favourit...80ede9a146
- script.image.resource.select: https://github.com/ronie/script.image.re...7f75a85fda

Cheers for that, will need to update Super Favourites too.

Kinda makes this post

http://forum.kodi.tv/showthread.php?tid=262250

Irrelevant too Smile
Reply
#5
(2016-03-09, 19:48)spoyser Wrote:
(2016-02-15, 14:02)ronie Wrote: not only skins, but addons utilizing the select dialog need to update their code as well.

just in case any addon dev stumbles across this post, here are some examples of what needs to be done:
- script.favourites: https://github.com/ronie/script.favourit...80ede9a146
- script.image.resource.select: https://github.com/ronie/script.image.re...7f75a85fda

Cheers for that, will need to update Super Favourites too.

Kinda makes this post

http://forum.kodi.tv/showthread.php?tid=262250

Irrelevant too Smile

as a for your info, there's a python changes for kodi thread as well, where this change was announced:
http://forum.kodi.tv/showthread.php?tid=...pid2246458
Do not PM or e-mail Team-Kodi members directly asking for support.
Always read the Forum rules, Kodi online-manual, FAQ, Help and Search the forum before posting.
Reply

Logout Mark Read Team Forum Stats Members Help
[Kodi 17] Cancel button in DialogSelect.xml0