Posts: 106
Joined: Dec 2004
Reputation:
0
herg
Senior Member
Posts: 106
I'm trying to track down a couple of bugs related to the creation of thumbnails, and I've run into a barrier. Everything looks good until functions that I believe are in the ImageLib are called. The problem is that I don't know what code is used to create ImageLib since it's stored in svn as a binary.
Posts: 106
Joined: Dec 2004
Reputation:
0
herg
Senior Member
Posts: 106
Thanks Jonathan. I dug around and found the sources folder a little earlier, and after much stumbling, I figured ImageLib is not at fault here either.
In xbmc/linux/XFileUtils.cpp, CopyFile(), the open of the destination file is creating a file with weird permissions. If I use the stat() from the source file to set dest permission during open(), it looks better, but I still can't set owner read. Best I can tell, the thread umask is goofed up, but I haven't been able to track down the thread creation yet.
Posts: 4,132
Joined: May 2004
Reputation:
4
sho
Team-XBMC Member
Posts: 4,132
Out of curiosiosity, what are these bugs?
Posts: 106
Joined: Dec 2004
Reputation:
0
herg
Senior Member
Posts: 106
First one, now fixed, was that video thumbnails did not show up.
Second one is that music folder thumbnails only show up if scan is started from that particular folder. Recursive scans result in thumbnails being created in UserData/Thumbnails/Music/*/, but they do not have read permissions. In XBMC, they show as nothing, not even the default folder icon.
I plan to work on it more later, but I'm out of town this weekend.
Posts: 31
Joined: Jun 2007
Reputation:
0
vulkanr
Retired Team-Kodi Member
Posts: 31
commited a fix (hopefully). thanks herg.
Posts: 106
Joined: Dec 2004
Reputation:
0
herg
Senior Member
Posts: 106
vulkanr,
Works for me. I think you squashed it.