[scott967]

I was looking at a skin and in the standard file dialogButtonMenu.xml in this skin it is declared as type "Dialog" but I see in Estuary it is defined as type "buttonMenu". AFAICT it works as a defined dialog but I am wondering why/when to use one type or the other? I assume that type dialog is Modal, is that right or is there something else to know? I looked in the code and see it gets used in application.cpp and there also is a window type of "submenu". Is that actually used by anyone?

scott s.
.

[ronie]

skins don't need to define a window type. if you do (you shouldn't) kodi will ignore it anyway.

the only time you need to define a type (either window or dialog) is in customXXXX.xml skin windows.

[Hitcher]

It does beg the question as to why DialogButtonMenu is like this?

PHP Code:

<?xml version="1.0" encoding="UTF-8"?>
<window type="buttonMenu">
    <defaultcontrol>9000</defaultcontrol> 


[ronie]

just remove the type definition, you don't need it ;-)

estuary cleanup: https://github.com/xbmc/xbmc/pull/10428