Looking for a developer to help with Krypton Back navigation

  Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
nickr Offline
Team-Kodi Member
Posts: 17,622
Joined: May 2009
Reputation: 355
Location: Christchurch NZ
Post: #16
Read the conversation on the pull request.

If I have helped you or increased your knowledge, click the 'thank user' button to give thanks :) (People with less than 20 posts won't see the "Thank you" button.)
find quote
kenmills Offline
Junior Member
Posts: 42
Joined: Jun 2016
Reputation: 0
Post: #17
Hey again Null - looks like this got fixed, using your suggestions, if I am not mistaken!

I am quite new to this, how do I check out the code? Just do a new git pull on the Kodi Krypton repo?

Thanks a million for your hard work! This was quite a pain in the @ss. Not sure why more folks hadn't complained about it, lol

Cheers,
Ken
find quote
kenmills Offline
Junior Member
Posts: 42
Joined: Jun 2016
Reputation: 0
Post: #18
And thanks nichr - yes, I have read the pull thread and now understand. :-)
find quote
null_pointer Offline
Senior Member
Posts: 208
Joined: Oct 2011
Reputation: 8
Post: #19
In the end my suggested code change was not correct. I was mistaken about the full history being built when return was specified. I though the history should not be build but in fact it is still built but not used.
The actual fix was to make sure the start directory was correctly set so when back space was used and the current path == the start directory the previous window was shown.
In the end it was a two line fix.

I testing this I also found that I needed to specify the plugin path correctly, it needed to have the / at the end of the plugin name. Read the pull request to see more details.

These changes have not been merged yet, the PR are still open, I believe they will be merged soon though. Keep an eye on the PR and when the status changes to merged then you can pull the changes from the Krypton or master branch.

https://github.com/xbmc/xbmc/pull/12050
and
https://github.com/xbmc/xbmc/pull/12058
find quote
kenmills Offline
Junior Member
Posts: 42
Joined: Jun 2016
Reputation: 0
Post: #20
Thanks so much null, for your time and effort. I read the thread, thx! You may have been mistaken, but you certainly initiated the issue and got it resolved. :-)

And mad props to the devs that fixed the code: xhaggi and jenkins

Have a brilliant weekend, and thanks again!
Ken
find quote
jmh2002 Offline
Posting Freak
Posts: 1,089
Joined: Dec 2008
Reputation: 63
Location: FRA, ITA, UKR,
Post: #21
(2017-05-06 07:00)kenmills Wrote:  Thanks so much null, for your time and effort. I read the thread, thx! You may have been mistaken, but you certainly initiated the issue and got it resolved. :-)

And mad props to the devs that fixed the code: xhaggi and jenkins

Have a brilliant weekend, and thanks again!
Ken

+1

If I have helped you or increased your knowledge please click the Thank User button to show me your appreciation :)

For YouTube questions please see the OFFICIAL THREAD, including the latest info in Post 1, and the Personal API Key Instructions and FAQ in Posts 2 & 3
find quote
null_pointer Offline
Senior Member
Posts: 208
Joined: Oct 2011
Reputation: 8
Post: #22
yeah xhaggi nail it.
find quote
Soli Online
Posting Freak
Posts: 819
Joined: Oct 2011
Reputation: 19
Post: #23
Jenkins too, he pretty badass
find quote
thekid Offline
Junior Member
Posts: 31
Joined: Jan 2014
Reputation: 0
Post: #24
Hi I noticed you guys found the same back issue as me and tried the new kodi app which seems to fix the issue. I see it is kodi 18 alpha 1. Is this safe to use or does it have more bugs than the official v17.1 build? Is there a kodi android apk which includes this fix?
find quote
null_pointer Offline
Senior Member
Posts: 208
Joined: Oct 2011
Reputation: 8
Post: #25
It is in the nightly, I did not know there was an Alpha.
find quote
Post Reply