Posts: 26,215
Joined: Oct 2003
Reputation:
187
You mean for static lists, or for allowing users + skinners to control the built in context menu on the media lists?
Posts: 217
Joined: Jan 2007
Reputation:
0
CHI3f
Team-XBMC Skinner
Posts: 217
Ok. For example in the list on the home window in xTV there are conditional buttons like the You Tube button, allowing the Movies button link to the library,etc. I think it would be alot easier if that list had it's own "context menu" to control these options rather than have to navigate to the skin settings to change these options. I think this could be useful in other skins as well so users could control what items are in the lists so they could get rid of any items they don't use and maybe add ones they would, which brings me to another suggestion I have been thinking about but I would have to think a little more on how it could be pulled off.
Posts: 217
Joined: Jan 2007
Reputation:
0
CHI3f
Team-XBMC Skinner
Posts: 217
The context menu could just be a custom dialog xml made by the skinner with the butons of their choosing.
Posts: 26,215
Joined: Oct 2003
Reputation:
187
Sure, but is XBMC going to know what to do when you press one of these buttons? Popping up and filling a context menu is the easy bit. Knowing what to do when a user clicks on it is the tricky bit. Problems are:
1. How is XBMC supposed to know what the skinner is wanting - having a built in is fine, but I suspect you want more than that?
2. If it is just a built in, then why can't you already do this (other than the fact that WHITE isn't mapped to bring up your custom dialog, which is just a keymapping thing.)
Cheers,
Jonathan
Posts: 217
Joined: Jan 2007
Reputation:
0
CHI3f
Team-XBMC Skinner
Posts: 217
I don't want more than that. I do just want the menu to just contain built-in's coded by the skinner in the custom xml. But what I am thinking is that the white button in the home window be mapped to do the home view toggle and the black button bring up the custom dialog specified by the <contextmenu>CustomContext.xml</contextmenu> tag in the list control just to keep it the same throughout the skin and for the user not to have to edit the keymap just to do it.
Posts: 489
Joined: Apr 2004
Reputation:
13
Freddo
Skilled Skinner
Posts: 489
Most users aren't using a gamepad, would this still work on a remote control?
Posts: 489
Joined: Apr 2004
Reputation:
13
Freddo
Skilled Skinner
Posts: 489
Oh don't get me wrong I love the request I just want to make sure it'll work for remote controls too. Recently Aeon has put a bunch of stuff in the shutdown menu which isn't actually mapped to the remote (to my knowledge) which is kind of annoying so, hopefully this feature request could remove the need for that.
Posts: 7,172
Joined: Dec 2003
Reputation:
4
kraqh3d
Retired Developer
Posts: 7,172
why do these functions need to be in the context menu? the menus are already getting rather large and already contain non-contextual items (now playing, settings, go to root, switch media).
Posts: 3,660
Joined: Feb 2008
Reputation:
93
Jeroen
Team-Kodi Member
Posts: 3,660
Correct me if I´m wrong, but I think what CHI3F means is having a skin specific context menu to be used in places where the built in context menu isn´t used. So not additional entries in the existing context menu.
All it would be is a custom xml binded to the context menu button without having the user having to set this in a keymap.
Posts: 7,172
Joined: Dec 2003
Reputation:
4
kraqh3d
Retired Developer
Posts: 7,172
There used to be a customized menu called the "DialogSubMenu" which fits the bill. It was similar to the Favourites. You could put anything in there. I see its still in the code, but PM3 doesn't make use of it. I guess it would be possible to use the same context menu action to invoke this menu when there's no context menu through the base window class. But it will only work in non media windows.