2004-06-24, 02:49
hi,
i was trying to add functionality for the rss control to display the description tag from an rss newsfeed as well as just the title tag. when i was looking at rssreader.cpp, i noticed that there was already code to do this at line 135, but commented out.
despite that, i readded the code to handle this - with some slight modifications (removing the 127 character chop, and calling html::chtmlutil::converthtmltoansi() on the text), and added a <showdescriptions> boolean tag to the control factory to allow it to be switched on or off.
it appears to work fine on my xbox, but what i'm wondering is if anyone knows why the original code was commented out. i'd submit it as a patch if that wasn't the case, since i'm sure it's something that many people would find useful, but i'm worried that there's some hidden flow on effect that i don't know about.
i was trying to add functionality for the rss control to display the description tag from an rss newsfeed as well as just the title tag. when i was looking at rssreader.cpp, i noticed that there was already code to do this at line 135, but commented out.
despite that, i readded the code to handle this - with some slight modifications (removing the 127 character chop, and calling html::chtmlutil::converthtmltoansi() on the text), and added a <showdescriptions> boolean tag to the control factory to allow it to be switched on or off.
it appears to work fine on my xbox, but what i'm wondering is if anyone knows why the original code was commented out. i'd submit it as a patch if that wasn't the case, since i'm sure it's something that many people would find useful, but i'm worried that there's some hidden flow on effect that i don't know about.
