waldo22 Wrote:Is this functionality in the xbox build too, or just the Linux/Mac/Windows builds?
This chapter code only appears to be in the DVDPlayer core and support for MKV chapters is only in the ffmpeg demuxer, so unless Xbox builds don't use the mplayer any more there's no chance of it being in Xbox.
To change topic: I'm really shaky on how things should be coded but here's a go at a patch to add support for chapter names for mkv files
, which can be accessed through skins via the player.chaptername $INFO tag. I welcome comments from developers
Link to diff vs r13974 since sf's tracker is down
Things I'm not sure if I did the XBMC Way:
-- When adding a GUI Info constant (i.e. PLAYER_CHAPTERNAME) should it go with the other constants related to chapter and move the rest down, or just at the end like I did?
-- Should IPlayer::GetChapterName() return a string vs modify a passed one? Other functions in the class seem to work with the passed string, so I copied that.
Tested on the Win32 and Linux builds on DVDs, mkvs with chapters, mkvs with no chapters, mp4s with chapters and without (although chapters do not work at all in mp4), and avi files.