Where should I post patches to SVN plugins?
#1
I didn't see a mailing list for the xbox-addons, but I could have missed it. I am pretty sure this is the wrong place, so please redirect me.

I am attaching a minor patch to the picasa plugin. It has a small problem if there is a single quotation mark in the title of a gallery -- this fixes that problem.

--- xbmcplugin_photos.py.old Thu Apr 2 01:22:48 2009
+++ xbmcplugin_photos.py Thu Apr 2 01:22:54 2009
@@ -50,7 +50,7 @@

def _parse_argv( self ):
# call _Info() with our formatted argv to create the self.args object
- exec "self.args = _Info(%s)" % ( unquote_plus( sys.argv[ 2 ][ 1 : ] ).replace( "&", ", " ).replace( "\\u0027", "'" ).replace( "\\u0022", '"' ).replace( "\\u0026", "&" ), )
+ exec "self.args = _Info(%s)" % ( unquote_plus( sys.argv[ 2 ][ 1 : ].replace("%27s","\\'") ).replace( "&", ", " ).replace( "\\u0027", "'" ).replace( "\\u0022", '"' ).replace( "\\u0026", "&" ), )

def _get_authkey( self ):
self.authkey = xbmcplugin.getSetting( "authkey" )
Reply
#2
http://code.google.com/p/xbmc-addons/issues/list
Reply
#3
in the plugins release thread in the future. but thanks will fix.
For python coding questions first see http://mirrors.xbmc.org/docs/python-docs/
Reply
#4
i can't reproduce this bug.

i changed one of my albums to: test "album

and it works fine. are you using ver1.3.4?
For python coding questions first see http://mirrors.xbmc.org/docs/python-docs/
Reply
#5
ok, first I may be wasting everyones time (and I apologize)...

I have version 1.3.3... Which seems to be the trunk of CVS...

But the bug occurs only when a SINGLE quote is used '

Because it is inserted into the string to be exec i.e.:
title='Kid's Bday'
Which isn't valid...

Again, if I don't have the latest version, please let me know where to get it Smile

Thanks again!!!
Reply
#6
ok 1.3.3 is latest, i have local changes. and i did reproduce with the apostrophe.

will have the fix in later today or tonight.

thanks again.
For python coding questions first see http://mirrors.xbmc.org/docs/python-docs/
Reply
#7
fixed in version 1.3.4
For python coding questions first see http://mirrors.xbmc.org/docs/python-docs/
Reply

Logout Mark Read Team Forum Stats Members Help
Where should I post patches to SVN plugins?0