!! ALL DEVS !! Local actor thumbs

  Thread Rating:
  • 0 Votes - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
spiff Offline
Retired Developer
Posts: 12,386
Joined: Nov 2003
Post: #1
Make sure you don't miss http://trac.xbmc.org/changeset/22123
find quote
flipped cracker Offline
Senior Member
Posts: 238
Joined: May 2008
Reputation: 0
Location: anaheim, ca
Post: #2
awesome, thanks!

Contribute to TheTVDB.com - The Online TV Database
find quote
Waffa Offline
Posting Freak
Posts: 1,163
Joined: May 2008
Reputation: 7
Location: Netherlands
Post: #3
Yeah very cool !!!
Thx spiff
find quote
fekker Offline
Posting Freak
Posts: 1,545
Joined: Oct 2008
Reputation: 30
Post: #4
cool, thanks spiff
find quote
spiff Offline
Retired Developer
Posts: 12,386
Joined: Nov 2003
Post: #5
before this gets settled; is my way of storing it acceptable or do you have a better convention to suggest? i chose to keep them out of the main folder for tidyness and the folder name to have them hidden in *nix.
find quote
ezechiel1917 Offline
Aeon Group
Posts: 745
Joined: Jun 2005
Location: Czech Republic
Post: #6
What about having them in a seperate folder which would store all actors at same folder level as your media folders? With that you wouldn't have to have multiple copies of actors thumbs in different folders and it would be more tidier and managable for enduser? Is this possible?

example:
Code:
MOVIES
[b]-.actors[/b]
-American Beauty (1999)
--CD1
--CD2
-American Pie (1999)
-American Pie 2 (2001)
...

Code:
SERIES
[b]-.actors[/b]
-24
--Season 01
---Episode 1x1
--Season 02
-30 Rock
--Season 01
...

XBMCbuntu 13.0 | XBMC PRE-14.0 | VDR + VNSI @ Technotrend CT-3650 CI | Transparency! skin | trakt.tv
find quote
spiff Offline
Retired Developer
Posts: 12,386
Joined: Nov 2003
Post: #7
possible, but not what i had in mind. the extra code complexity is not worth it imo. the thumbs take next to none space compared to the real media.

complexity means identifying that folder (we have multipaths and whatnot). current storage scheme means it's dead simple to find the folder
find quote
fekker Offline
Posting Freak
Posts: 1,545
Joined: Oct 2008
Reputation: 30
Post: #8
i like the way you have it, no change needed, will work for shows and movies with just a few checks and allows more granular actor info

I'm thinking along the lines that movie from 20 years ago, shouldn't really have the actor image from today with it. (which a central image store would have)
(This post was last modified: 2009-08-13 18:41 by fekker.)
find quote
CrashX Offline
Posting Freak
Posts: 1,164
Joined: Jan 2009
Reputation: 2
Post: #9
Do we really need multiple actor thumbs of the same actor ? Unless we want to have actor gallery. Big GrinBig Grin

I wonder if it is stored in the database as a single or multiple entry forr the same actor ?

The normal XBMC log IS NOT a debug log, to enable debug logging you must toggle it on under XBMC Settings - System or in advancedsettings.xml. Use XBMC Debug Log Addon to retrieve it.
find quote
ezechiel1917 Offline
Aeon Group
Posts: 745
Joined: Jun 2005
Location: Czech Republic
Post: #10
ok, then i think your solution is fine, as there's not many ways where to store them, if it's supposed to be inside folder with media.

It's just I would prefer not having one visible subfolder for every movie/episode. Anyway your setup is better in fact that if you delete a movie, you delete all associated thumbs, with my idea it would leave you with few "dead" thumbs.

XBMCbuntu 13.0 | XBMC PRE-14.0 | VDR + VNSI @ Technotrend CT-3650 CI | Transparency! skin | trakt.tv
find quote
spiff Offline
Retired Developer
Posts: 12,386
Joined: Nov 2003
Post: #11
currently we only support on thumb per actor, and as such, storing along with the media has no gains in those regards. but we have the flexibility to add if we see fit
find quote
ezechiel1917 Offline
Aeon Group
Posts: 745
Joined: Jun 2005
Location: Czech Republic
Post: #12
fekker Wrote:I'm thinking along the lines that movie from 20 years ago, shouldn't really have the actor image from today with it. (which a central image store would have)

from what I understand spiff import works once, after you have actor thumb cached, it won't cache another thumb of same actor.

Or does import overwrites cached thumb if one exists, spiff?

XBMCbuntu 13.0 | XBMC PRE-14.0 | VDR + VNSI @ Technotrend CT-3650 CI | Transparency! skin | trakt.tv
find quote
spiff Offline
Retired Developer
Posts: 12,386
Joined: Nov 2003
Post: #13
you are correct
find quote
flipped cracker Offline
Senior Member
Posts: 238
Joined: May 2008
Reputation: 0
Location: anaheim, ca
Post: #14
is it based on name alone? i'm just wondering because thetvdb.com has images for actors based on each show, with the actors dressed in character. so if it's based on name alone, you could have an image from a totally different show for an actor. if possible, it'd be better if it was based on movie/tvshow and name.

Contribute to TheTVDB.com - The Online TV Database
find quote
billyad2000 Offline
Media Companion Founder
Posts: 727
Joined: Oct 2007
Reputation: 17
Post: #15
Hi spiff, I was wondering if it is possible yet to allow the <thumb> tag for an actor to contain a network path for the thumb? The only reason I would prefer this is that it would allow single or multiple images for the same actor (MC for example uses actorid from imdb, or Numeric ID for images from TVDB. This not only allows multiple thumbs for each actor if needed aka tvdb, but also to select a higher quality image, some of the default imdb actor images are awful.

The biggest advantage is that for most instances each thumb would only need to be stored once (Twice if you include xbmc)

eg.
<actor>
<name>Charlize Theron</name>
<role>Mary Embrey</role>
<thumb>smb://HomeNAS/public/Actors/34/nm0000234.jpg</thumb>
</actor>

Homepage for XBMC Media Companion, and XBMC-DB - seperate nfo files http://www.billyad2000.co.uk
Forums for XBMC Media Companion http://billyad2000.darkbb.com/
find quote
Post Reply