Hi all,
Just to let you know I've added a ticket on Trac to enable LATM-AAC decoding for Windows platforms. The feature was added a few weeks/months ago but only worked for Linux as part of the requirement for it to work was that libfaad be compiled into ffmpeg. Because the build system is slightly different for Windows over Linux this wasn't happening hence it wasn't working on Windows builds. Hopefully this patch will enable ffmpeg to be compiled with the correct options to make this work.
I'm not a programmer just a average hacker at best so my solution may be a little rough around the edges. So here are a couple of things which I think are potential areas to improve the code:
1. the libfaad code needs to be patched to compile for windows using mingw. The source I used for this is: http://ffmpeg.arrozcru.org/wiki/index.php?title=Faad
because this patch would probably wreck compiles for linux I've made a shell script to build it for Windows. It replaces the required files with ones from a backup and compiles then replaces those with the originals from backup. The script is very straight forward so I won't go into any more detail. Tidier ways to do this might be for the shell to apply the patch then reverse it or to add extra config arguments which direct the compiler to use other files than the defaults.
2. when libfaad is compiled it copies the compiled code to the /mingw folder. I did this because I couldn't find the right configure arguments to pass to ffmpeg to get it to find libfaad libraries and headers. I think the required arguments are '--extra-ldflags' but all variations I could think of didn't work.
Anyway this is my first contribution back to the open-source community so it feels good.
Just to let you know I've added a ticket on Trac to enable LATM-AAC decoding for Windows platforms. The feature was added a few weeks/months ago but only worked for Linux as part of the requirement for it to work was that libfaad be compiled into ffmpeg. Because the build system is slightly different for Windows over Linux this wasn't happening hence it wasn't working on Windows builds. Hopefully this patch will enable ffmpeg to be compiled with the correct options to make this work.
I'm not a programmer just a average hacker at best so my solution may be a little rough around the edges. So here are a couple of things which I think are potential areas to improve the code:
1. the libfaad code needs to be patched to compile for windows using mingw. The source I used for this is: http://ffmpeg.arrozcru.org/wiki/index.php?title=Faad
because this patch would probably wreck compiles for linux I've made a shell script to build it for Windows. It replaces the required files with ones from a backup and compiles then replaces those with the originals from backup. The script is very straight forward so I won't go into any more detail. Tidier ways to do this might be for the shell to apply the patch then reverse it or to add extra config arguments which direct the compiler to use other files than the defaults.
2. when libfaad is compiled it copies the compiled code to the /mingw folder. I did this because I couldn't find the right configure arguments to pass to ffmpeg to get it to find libfaad libraries and headers. I think the required arguments are '--extra-ldflags' but all variations I could think of didn't work.
Anyway this is my first contribution back to the open-source community so it feels good.
