2010-05-27, 00:51
First off, I hope this is the correct spot for mentioning this - I can't seem to submit bugs on trac, don't really know where else to post this - my apologies if I was mistaken
When using a fancy $10 remote from DealExtreme, almost everything works straight out - which is very awesome. However, one particular button is being a bugger: play / pause. When XBMC is playing something it does let me pause and then resume, but when not playing I cannot use it to start playback. Not so much a problem for movies, but with music it's a bit of a bugger.
I've tracked down the key command send by the remote using debug logging: WinEventsWin32.cpp: APPCOMMAND 14. This appears to correspond to the play/pause command. Looking in WinEventsWin32.cpp around line 454 we see:
Judging by the application header, I am guessing this should be changed to:
Sadly I am unfamiliar with the source and my builds don't want to run (crash on startup, if they compile at all, I'm probably doing something wrong there) so I can't test it myself, would much appreciate it if any of the dev gods here could take a look
The exact same problem occurs also with the play/pause button on my "multimedia" keyboard, so it is not just limited to my remote.
//edit
Woops, didn't know my forum username/pass worked for trac as well. I'm guessing this is the same problem as the bug reported here so this thread can probably be closed.
When using a fancy $10 remote from DealExtreme, almost everything works straight out - which is very awesome. However, one particular button is being a bugger: play / pause. When XBMC is playing something it does let me pause and then resume, but when not playing I cannot use it to start playback. Not so much a problem for movies, but with music it's a bit of a bugger.
I've tracked down the key command send by the remote using debug logging: WinEventsWin32.cpp: APPCOMMAND 14. This appears to correspond to the play/pause command. Looking in WinEventsWin32.cpp around line 454 we see:
Code:
case APPCOMMAND_MEDIA_PLAY_PAUSE:
if (g_application.IsPaused())
newEvent.appcommand.action = ACTION_PLAYER_PLAY;
else
newEvent.appcommand.action = ACTION_PAUSE;
break;
Code:
case APPCOMMAND_MEDIA_PLAY_PAUSE:
if (!g_application.IsPlaying())
newEvent.appcommand.action = ACTION_PLAYER_PLAY;
else
newEvent.appcommand.action = ACTION_PAUSE;
break;
The exact same problem occurs also with the play/pause button on my "multimedia" keyboard, so it is not just limited to my remote.
//edit
Woops, didn't know my forum username/pass worked for trac as well. I'm guessing this is the same problem as the bug reported here so this thread can probably be closed.