[frnando]

Hi,

Recently, I wasn't getting any subtitle/audio track info (on matroska file) on fullscreen interface, so I searched a lot, and found on svn when ffmpeg gets the track info.

So, I discovered why I'm not getting any track info when I change the tracks.

FFMpeg is looking for the 'description' metadata token (DVDDemuxFFmpeg.cpp - twice audio & sub - in 'AddStream' procedure), while all of my matroska files has the info for tracks on 'title' index (generated by MkvToolnix).

My suggestion is: When ffmpeg looks for 'description' in metadata, if the result string is empty, then it should look for 'title' string, so if the 'description' doesn't exists, use 'title' instead (more common).

Best regards,

Fernando

[spiff]

i don't understand, please speak diff/C/C++ please.

[frnando]

Ok, I'll try.

I don't know if this is the right way to post the diff, tell me if I'm wrong.

Code:

--- C:/DOCUME~1/ADMINI~1/LOCALS~1/Temp/DVDDemuxFFm-revBASE.svn007.tmp.cpp    qua ago 11 17:15:22 2010
+++ D:/xbmc/xbmc/cores/dvdplayer/DVDDemuxers/DVDDemuxFFmpeg.cpp    qua ago 11 17:15:16 2010
@@ -939,6 +939,9 @@
    
         if(m_bMatroska && m_dllAvFormat.av_metadata_get(pStream->metadata, "description", NULL, 0))
           st->m_description = m_dllAvFormat.av_metadata_get(pStream->metadata, "description", NULL, 0)->value;    
+        else
+          if(m_bMatroska && m_dllAvFormat.av_metadata_get(pStream->metadata, "title", NULL, 0))
+            st->m_description = m_dllAvFormat.av_metadata_get(pStream->metadata, "title", NULL, 0)->value;

         break;
       }
@@ -1012,6 +1015,9 @@
        
           if(m_bMatroska && m_dllAvFormat.av_metadata_get(pStream->metadata, "description", NULL, 0))
             st->m_description = m_dllAvFormat.av_metadata_get(pStream->metadata, "description", NULL, 0)->value;
+          else
+            if(m_bMatroska && m_dllAvFormat.av_metadata_get(pStream->metadata, "title", NULL, 0))
+              st->m_description = m_dllAvFormat.av_metadata_get(pStream->metadata, "title", NULL, 0)->value;
    
           break;
         }

[Montellese]

Best way is to create a new ticket in Trac describing your changes and why they are needed and attach the patch/diff to that ticket.