[WIP] Metropolis skin

  Thread Rating:
  • 5 Vote(s) - 5 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
MacGyver Offline
Fan
Posts: 635
Joined: Jan 2007
Reputation: 5
Location: Weilerbach Germany
Post: #1186
(2015-08-05 22:35)great_vc Wrote:  now that i have you here and you look so vivid Laugh did you check out this ?

(2015-07-27 15:13)great_vc Wrote:  Also on the modified skin the votes appear correctly on the movie info page but when you play a movie and hit pause, on the pause screen the votes section says NA
[Image: JPhrvzn.png]

tnx

-Vassilis

Problem is that it's not me, it has been broken in Kodi since it was put in. "VideoPlayer.Votes" is the problem, or the fact that Kodi isn't populating it. There are two labels I use for that and only "ListItem.Votes" is working correctly, which is why it works everywhere but in the player info window.

BTW, displaying votes in this way is only in my personal version, so officially it's not a problem. Smile

Using a 2820FYKH0 Intel NUC, a Revo 1600, and two Foxconn NT-330i - All running OpenELEC. :)
(This post was last modified: 2015-08-05 23:17 by MacGyver.)
find quote
great_vc Offline
Member
Posts: 91
Joined: Apr 2015
Reputation: 0
Post: #1187
(2015-08-05 23:12)MacGyver Wrote:  BTW, displaying votes in this way is only in my personal version, so officially it's not a problem. Smile

hehe Big Grin yes you are right. I will learn to live with it no problem
find quote
MacGyver Offline
Fan
Posts: 635
Joined: Jan 2007
Reputation: 5
Location: Weilerbach Germany
Post: #1188
Did you catch this code change jingai?

2015-03-21 option to use params in includes

Holy crap, that has the potential to simplify a million things.

Using a 2820FYKH0 Intel NUC, a Revo 1600, and two Foxconn NT-330i - All running OpenELEC. :)
find quote
MacGyver Offline
Fan
Posts: 635
Joined: Jan 2007
Reputation: 5
Location: Weilerbach Germany
Post: #1189
I have now added all commits needed for "Changes to the skinning engine for Kodi 15 (Isengard)". (I had to add some older ones last as I thought they had been done already)

Commits or complete changes.

That should be everything needed to go to Kodi 15, let me know if you need anything else. (The menu-refactor commits on the other separate branch should merge correctly too as none of those files were changed)

Using a 2820FYKH0 Intel NUC, a Revo 1600, and two Foxconn NT-330i - All running OpenELEC. :)
(This post was last modified: 2015-08-09 12:09 by MacGyver.)
find quote
jingai Offline
Skilled Skinner
Posts: 1,325
Joined: Mar 2010
Reputation: 15
Post: #1190
Thanks again MacGyver. I'll get to this as soon as I can.
find quote
Post Reply