2011-04-22, 01:00
Hi bole5, is it possible for you to fix the AC3 passthrough issue? I'm asking since it's audio related too. thanks
ldi9999 Wrote:Hi bole5, is it possible for you to fix the AC3 passthrough issue? thanks
ldi9999 Wrote:I don't think he meant to ask for how to compile. He was most likely asking if he needs to compile.
bole5 Wrote:After spending some time debugging the IOSAudioRenderer with the help of the new IOSAudioRingBuffer I think I finally fixed the problem with the video slowdown on FF/REW!
The result is a rock solid build (at least in my tests). I was not able to crash the ATV2 however I tried, but please give it a go and post about your experience
As usual I provided the full patch based on the latest trunk (20. April) and the binary.
The diff can be found on pastebin: http://pastebin.com/sTNUZHty.
This build should completely eliminate video slowdown and rebooting when doing a lot of FF/REW. Please follow the instructions below and report your results. The binary was build on Apr 20 2011 Git:20110419-28f5811. If you don't understand the instructions below, please don't even try this...
1. Download the compiled XBMC binary from: http://www.megaupload.com/?d=WW8PU73E
2. Copy the file XBMC using your scp client to the folder: /Applications/AppleTV.app/Appliances/XBMC.frappliance/
3. Restart the ATV2 by running: killall AppleTV in unix shell, or reboot your ATV2
Enjoy and don't forget to post your results in this tread
i5Js Wrote:Exactly I've download the source code this night and compiled it. is it still necessary apply the patch??
davilla Wrote:Nice, but I have a concern with IOSAudioRingBuffer and the reset function. It touches both read/write. A reset would most likely come from DVDPlayer and if audio codec is pulling from m_Buffer, you could get problems when reading if the thread switch happened at the wrong time. Also should not need the memset(m_Buffer,'\0',m_iSize) in reset. A reader will only read if there's something to read and then m_Buffer has valid contents.
CSliceQueue is really what you want to use, it's lockless and threadsafe. It does look complicated but it has to be to cover all the holes.
ldi9999 Wrote:Applied the patch. Looks like the issue is fixed. Great work!