i couldn't find this in the earlier post (searched for "select or selected" and browsed back 10 pages) please excuse me if this was already reported
don't know if this is by design or if it got broken since the last version i used, but i just noticed that when i return to the video selection screen from video playback, the selection marker has been placed back on the first file and is no longer on the last selected file.
it's a bit of an inconvenience, especially when you're viewing some episodes of your favorite series which are all together in one folder :d
my current build is from today (april 10, 2005)
my previous build was from february 6, 2005
regards
remco
i confirmed this bug last night. i'll take a look at it later today.
its already fixed... good thing cuz im more than a little drunk atm
(kraqh3d @ april 12 2005,02:56 Wrote:its already fixed... good thing cuz im more than a little drunk atm
yeah, don't drink & code, you might cause a crash!
:o
anyway, i submitted it to the bug tracker as well and jmarshall picked it up and fixed it. however, i yesterday it hadn't made it's way to the cvs sources yet.
can someone tell me, how long it takes for a bugfix/code-change to make it into the cvs sources?
also, since you looked into it, what was the selection set to? because in different folders, the selection would reset to different files (never always the first file, even in different sort-modes).
remco
i've checked this again with today's cvs code, and it hasn't been solved in it.
so, how long does it take for the patches to trickle over to the cvs sources?
<edit>
just read through this thread: "how-to compile xbmc from cvs, build source to xbox executable". this gave me the impression it shouldn't be more then 4 hours until a patch makes it into the cvs sources. right?
so can i conclude the bug hasn't been fixed?
just to be precise, to reproduce this bug, i have the list in files-view, with simple stacking. i click on a videofile somewhere in the middle of the list, so it starts playing. i almost immediately exit playback (by pressing the b-button on the controller) and when i get back to the my video's screen, another file is now selected. it is always the same file that is selected, but across different folders, it's not consistently the first file in that folder.
</edit>
thanks!
unable to reproduce.
it works perfectly for me, to matter what the sort method is.
tried with simple stacking both on and off. didn't matter whether files were stacked or not - the cursor always returned to the correct file in the list.
cheers,
jonathan
wow, weird...
could it be the skin? because i just checked my old build again from february, and i don't have it in there. that version uses the project mayhem skin, while for the current build i use project mayhemm iii.
also, i couldn't see what file always gets the selection, because no matter what sorting i use, it's always the same file in a particular folder, but not always the first file in the list.
any idea what settings might influence this? i'll go over all my settings and compare the two versions...
regards...
are you using the latest skin from cvs?
if not, that might be the problem, though i doubt it.
nothing else i can think of would influence it at all.
gone over the settings.. the only thing i see is in appearance->view options:
remember selected file on forward navigation.
i'm not sure what this is supposed to do, but turning it on or of had no difference for me. while entering folders and going back up, the selected folder would be remembered, when starting an stopping playback, the selected file wouldn't be remembered...
i've also tried to do a complete fresh install (deleted the 0face008 folders on e
but still the same problem.
i've you still can't find it, perhaps someone could tell met the source file and method name in which i can find this. (i tried finding it, but since i'm not familiar with the xbmc code, i find it a bit difficult to locate). i might just try patching my xbox into a development box and try to debug this problem myself. or otherwise, i might try to write some info into the logfile, and see if i can't find the problem that way.
the file(s) you want is guiwindowvideofiles.cpp and it's base class guiwindowvideobase.cpp.
the selected item is saved in the variable m_iselecteditem, and the focused control is saved in m_ilastcontrol. this occurs in the deinit message in onmessage(), in the baseclass.
the setting of the selected item/control occurs in init message in onmessage(). you see that it both focuses the appropriate control, and sets the correct item.
i can't see where the code could be going wrong on this front, but seeing as i wrote a lot of it, it could just be a case of another pair of eyes needed. just adding a log message to both of these routines will probably be sufficient to at least check whether it's doing what it's supposed to.
cheers,
jonathan
thanks,
i'm now in the process of checking the latest skin, it might be the cause, since i hadn't used the latest skin. only, after uploading it to the box, the my video's was completely empty.. deleting the 0face008 folders didn't help either... i'm now doing a new fresh install.
i'll keep you posted
whoa!
with the latest pmiii cvs skin, xbmc crashes... since "my videos" was empty i plaued around with the view options in it. when i set it from files to genre it crashed. now whenever i enter it, it crashes.
here's the last log:
Quote:16-04-2005 13:14:07 notice -----------------------------------------------------------------------
16-04-2005 13:14:07 notice starting...
16-04-2005 13:14:07 notice q is mapped to:harddisk0\partition6\apps\xbmc\safe
16-04-2005 13:14:07 notice load settings...
16-04-2005 13:14:07 notice loading t:\settings.xml
16-04-2005 13:14:08 notice getting hardware information now...
16-04-2005 13:14:08 notice checking resolution 2
16-04-2005 13:14:08 notice av pack: scart
16-04-2005 13:14:08 notice av flags: widescreen,pal60
16-04-2005 13:14:08 notice setting safe mode 5
16-04-2005 13:14:08 notice loading q:\xboxmediacenter.xml
16-04-2005 13:14:08 info key combination detected for full debug logging (x+y)
16-04-2005 13:14:08 info map drives...
16-04-2005 13:14:08 info map drive c:
16-04-2005 13:14:08 info map drive e:
16-04-2005 13:14:08 info map drive d:
16-04-2005 13:14:08 info map drive f:
16-04-2005 13:14:08 info drives are mapped
16-04-2005 13:14:08 info checking skinpath existance, and existence of keymap.xml:q:\skin...
16-04-2005 13:14:08 debug setting resolution 5
16-04-2005 13:14:08 debug we set resolution 5
16-04-2005 13:14:08 debug setting resolution 5
16-04-2005 13:14:08 debug we set resolution 5
16-04-2005 13:14:08 info load language file:q:\language\english\strings.xml
16-04-2005 13:14:08 notice loaded q:\system\players\mplayer\iso639-1.xml
16-04-2005 13:14:08 notice loaded q:\system\players\mplayer\iso639-2.xml
16-04-2005 13:14:08 info load keymapping
16-04-2005 13:14:08 info loading q:\keymap.xml
16-04-2005 13:14:08 info checking skin version of: project mayhem iii
16-04-2005 13:14:08 info skin version is: 1.3
16-04-2005 13:14:08 info gui format 720x480 ntsc 16:9
16-04-2005 13:14:08 info gui screen offset (0,0)
16-04-2005 13:14:08 info install unhandled exception filter
16-04-2005 13:14:08 info creating subdirectories
16-04-2005 13:14:08 info thumbnails folder:q:\thumbs
16-04-2005 13:14:08 info shortcuts folder:q:\shortcuts
16-04-2005 13:14:08 info albums folder:q:\albums
16-04-2005 13:14:08 info recording folder:q:\recordings
16-04-2005 13:14:08 info screenshots folder:q:\screenshots
16-04-2005 13:14:08 info subtitle folder:q:\subtitles
16-04-2005 13:14:08 notice initialize assignment:[dash] network ip:[192.168.0.3] netmask:[255.255.255.0] gateway:[192.168.0.1] nameserver:[0.0.0.0]
16-04-2005 13:14:08 warning not initializing network, using settings as they are setup by dashboard
16-04-2005 13:14:08 info init network
16-04-2005 13:14:08 info get local ip address:
16-04-2005 13:14:09 info ip adres:10.0.0.153
16-04-2005 13:14:09 notice start ftpserver
16-04-2005 13:14:10 notice start led control
16-04-2005 13:14:10 notice dim lcd on playback
16-04-2005 13:14:10 notice start dvd mediatype detection
16-04-2005 13:14:10 notice initializing playlistplayer
16-04-2005 13:14:10 info lcd not used
16-04-2005 13:14:10 notice start fancontroller
16-04-2005 13:14:10 notice load default skin:[project mayhem iii]
16-04-2005 13:14:10 info load skin from:q:\skin\project mayhem iii
16-04-2005 13:14:10 info delete old skin...
16-04-2005 13:14:10 info default 4:3 resolution directory is q:\skin\project mayhem iii\pal
16-04-2005 13:14:10 info default 16:9 resolution directory is q:\skin\project mayhem iii\pal16x9
16-04-2005 13:14:10 info skin version is: 1.3
16-04-2005 13:14:10 info load fonts for skin...
16-04-2005 13:14:10 info loading fonts from q:\skin\project mayhem iii\ntsc16x9\font.xml
16-04-2005 13:14:10 info load font:font18 path:q:\skin\project mayhem iii\fonts\common-font18.xpr
16-04-2005 13:14:10 info load font:font13 path:q:\skin\project mayhem iii\fonts\common-font13.xpr
16-04-2005 13:14:10 info load font:font14 path:q:\skin\project mayhem iii\fonts\common-font14.xpr
16-04-2005 13:14:10 info load font:font64 path:q:\skin\project mayhem iii\fonts\common-font64.xpr
16-04-2005 13:14:10 info load font:matrix8 path:q:\skin\project mayhem iii\fonts\matrix8.xpr
16-04-2005 13:14:10 info load font:font04 path:q:\skin\project mayhem iii\fonts\common-font14.xpr
16-04-2005 13:14:10 info load font:font12 path:q:\skin\project mayhem iii\fonts\common-font12.xpr
16-04-2005 13:14:10 info load font:font10 path:q:\skin\project mayhem iii\fonts\common-font10.xpr
16-04-2005 13:14:10 info load font:font15 path:q:\skin\project mayhem iii\fonts\common-font15.xpr
16-04-2005 13:14:10 info load font:fontkb path:q:\skin\project mayhem iii\fonts\common-font13.xpr
16-04-2005 13:14:10 info load font:font101 path:q:\skin\project mayhem iii\fonts\common-font10.xpr
16-04-2005 13:14:10 info load font:special12 path:q:\skin\project mayhem iii\fonts\special-normal.xpr
16-04-2005 13:14:10 info load font:special13 path:q:\skin\project mayhem iii\fonts\special-bold.xpr
16-04-2005 13:14:10 info load new skin...
16-04-2005 13:14:10 info skin version is: 1.3
16-04-2005 13:14:10 info loading skin file: home.xml
16-04-2005 13:14:10 info loading references file: q:\skin\project mayhem iii\ntsc16x9\references.xml
16-04-2005 13:14:10 info loading skin file: myprograms.xml
16-04-2005 13:14:10 info loading skin file: mypics.xml
16-04-2005 13:14:10 info loading skin file: filemanager.xml
16-04-2005 13:14:10 info loading skin file: myvideo.xml
16-04-2005 13:14:10 info loading skin file: myvideogenre.xml
16-04-2005 13:14:10 info loading skin file: myvideoactors.xml
16-04-2005 13:14:10 info loading skin file: myvideoyear.xml
16-04-2005 13:14:10 info loading skin file: myvideotitle.xml
16-04-2005 13:14:10 info loading skin file: settings.xml
16-04-2005 13:14:10 info loading skin file: myvideoplaylist.xml
16-04-2005 13:14:10 info loading skin file: settingssysteminfo.xml
16-04-2005 13:14:10 info loading skin file: dialogalbuminfo.xml
16-04-2005 13:14:10 info loading skin file: dialogscriptinfo.xml
16-04-2005 13:14:10 info loading skin file: settingsprofile.xml
16-04-2005 13:14:10 info loading skin file: dialogyesno.xml
16-04-2005 13:14:10 info loading skin file: dialogprogress.xml
16-04-2005 13:14:10 info loading skin file: dialogvolumebar.xml
16-04-2005 13:14:10 info loading skin file: dialogkaitoast.xml
16-04-2005 13:14:10 info loading skin file: dialognumeric.xml
16-04-2005 13:14:10 info loading skin file: dialoggamepad.xml
16-04-2005 13:14:10 info loading skin file: dialogsubmenu.xml
16-04-2005 13:14:10 info loading skin file: dialogbuttonmenu.xml
16-04-2005 13:14:10 info loading skin file: dialogcontextmenu.xml
16-04-2005 13:14:10 info loading skin file: dialogmusicscan.xml
16-04-2005 13:14:10 info loading skin file: playercontrols.xml
16-04-2005 13:14:10 info loading skin file: mymusicplaylist.xml
16-04-2005 13:14:10 info loading skin file: mymusicsongs.xml
16-04-2005 13:14:10 info loading skin file: mymusicnav.xml
16-04-2005 13:14:10 info loading skin file: mymusictop100.xml
16-04-2005 13:14:10 info loading skin file: dialogselect.xml
16-04-2005 13:14:10 info loading skin file: dialogok.xml
16-04-2005 13:14:10 info loading skin file: dialogfilestacking.xml
16-04-2005 13:14:10 info loading skin file: dialogvideoinfo.xml
16-04-2005 13:14:10 info loading skin file: musicoverlay.xml
16-04-2005 13:14:10 info loading skin file: settingsuicalibration.xml
16-04-2005 13:14:10 info loading skin file: settingsscreencalibration.xml
16-04-2005 13:14:10 info loading skin file: settingscategory.xml
16-04-2005 13:14:10 info loading skin file: videooverlay.xml
16-04-2005 13:14:10 info loading skin file: videofullscreen.xml
16-04-2005 13:14:10 info loading skin file: myscripts.xml
16-04-2005 13:14:10 info loading skin file: musicvisualisation.xml
16-04-2005 13:14:10 info loading skin file: slideshow.xml
16-04-2005 13:14:10 info loading skin file: videoosd.xml
16-04-2005 13:14:11 info loading skin file: myweather.xml
16-04-2005 13:14:11 info loading skin file: dialoginvite.xml
16-04-2005 13:14:11 info loading skin file: dialoghost.xml
16-04-2005 13:14:11 info loading skin file: dialogkeyboard.xml
16-04-2005 13:14:11 info loading skin file: mybuddies.xml
16-04-2005 13:14:11 info loading skin file: pointer.xml
16-04-2005 13:14:11 info loading skin file: dialogmutebug.xml
16-04-2005 13:14:11 info loading user windows q:\skin\project mayhem iii\pal16x9\custom*.xml
16-04-2005 13:14:11 info loading skin file: q:\skin\project mayhem iii\pal16x9\custom1.xml
16-04-2005 13:14:11 info initialize new skin...
16-04-2005 13:14:11 info skin loaded...
16-04-2005 13:14:11 info initializing skin
16-04-2005 13:14:11 info kaiclient: instantiating...
16-04-2005 13:14:11 debug udpclient: creating udp socket...
16-04-2005 13:14:11 debug udpclient: setting broadcast socket option...
16-04-2005 13:14:11 debug udpclient: setting non-blocking socket options...
16-04-2005 13:14:11 debug udpclient: spawning listener thread...
16-04-2005 13:14:11 debug udpclient: ready.
16-04-2005 13:14:11 info kaiclient: ready.
16-04-2005 13:14:11 notice kaiclient: discovering kai engine via udp broadcast.
16-04-2005 13:14:11 info activating window id: 10000
16-04-2005 13:14:11 info removing tempfiles
16-04-2005 13:14:11 info checking bookmarks for special directories
16-04-2005 13:14:11 notice initialize done
16-04-2005 13:14:11 notice running the application...
16-04-2005 13:14:11 info get url: http://www.xbox-scene.com/xbox1data/xbox-scene.xml
16-04-2005 13:14:13 debug udpclient: listening.
16-04-2005 13:14:13 debug udpclient tx: 7862 -> 'kai_client_discover;'
16-04-2005 13:14:15 info activating window id: 10004
16-04-2005 13:14:18 info activating window id: 10019
16-04-2005 13:14:29 info activating window id: 10006
16-04-2005 13:14:29 info activating window id: 10021
16-04-2005 13:14:29 error exception in capplication::render()
16-04-2005 13:14:29 error exception in capplication::render()
16-04-2005 13:14:29 error exception in capplication::render()
16-04-2005 13:14:29 error exception in capplication::render()
16-04-2005 13:14:29 error exception in capplication::render()
16-04-2005 13:14:29 error exception in capplication::render()
16-04-2005 13:14:29 error exception in capplication::render()
16-04-2005 13:14:29 error exception in capplication::render()
16-04-2005 13:14:29 error exception in capplication::render()
16-04-2005 13:14:29 error exception in capplication::render()
16-04-2005 13:14:29 error exception in capplication::render()
16-04-2005 13:14:29 error capplication::render(), too many exceptions
16-04-2005 13:14:29 fatal exception_access_violation (0xc0000005)
at 0x0003edb7
i'll try downloading pmiii from the homepage and i'll see what happens with that...
when i try the old pmiii skin (which i took from cvs on april 10th) it works fine...
seems to me like the selection mught be a skin problem as well then...
i'll first try to get the skin working....
hmmm - check you have the latest xbe on the xbox as well.
if you don't, you could get a crash in database views if you don't have any actual info in the database.
i'll put a fix for this in now. if you want to check in your build, it's in the render() routine of guiwindowvideobase.cpp. we do a getcontrol(50) and then use the pointer to the control without checking it's non-null. the reason this might cause crashes in older builds or with non-1.3 compatible skins (doesn't effect pm3) is that the id of the list control used to be 10.
edit: corrected location of the possible bug.
cheers,
jonathan
unforunately, with the latest pmiii skin, i can't get into the my video's page.
tried another skin (the orbs) but the selection problem remains... i'll see if i can find the bug...
remco
aaaaargh, i hate it when this happens.
the minute you start debugging, the bug doesn't occur anymore!
so, yeah, it's solved. i added some log messages, and voila it worked. looking at the code it seemed to me it hardly could go wrong anyway.
this makes me believe there might be a bug in the download and build script i used (
xbmc dbr)
just confirmed this, i got the latest version of the script, run that, and it had this problem. then built xbmc myself and copied the default.xbe over, problem gone...
thanks for all the help and patience!
remco