Kodi Community Forum

Full Version: [LINUX] FTBFS due to bad include order
You're currently viewing a stripped down version of our content. View the full version with proper formatting.
Hello,

I think I've found a fail-to-build-from-scratch bug in the build logic. This is XBMC git 59dec9661fdcaeef88fd0af36fad272cae197e9a (2011-10-20). This has been a persistent problem for several months.

I use Slackware64 (x86-64) as my host distribution. Some packages, both official and third-party, provide a 'config.h' in their include directories.
Code:
[email protected]:/usr/include# ls */config.h                                
OpenSP/config.h     mcabber/config.h  mysql/config.h  ruby/config.h
libcgroup/config.h  msn/config.h      pci/config.h



The issue is, when any given XBMC source tries to #include <config.h>, it will use the wrong copy out of a system search path (such as mysql) in preference to the config.h generated as part of ./configure. My Makefile.include:
Code:
INCLUDES+=$(sort  -I$(abs_top_srcdir) -I/usr/include/mysql   -I/usr/include/fribidi     -I/usr/include/libpng14           -I/usr/include/freetype2     -I/usr/include/alsa   -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include   -D_GNU_SOURCE=1 -D_REENTRANT -I/usr/include/SDL   -DDBUS_API_SUBJECT_TO_CHANGE -I/usr/include/hal -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include   -DDBUS_API_SUBJECT_TO_CHANGE -I/usr/include/hal -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include               -I/usr/include/libcec    )
INCLUDES+=-I/tmp/SBo/xbmc-pre11.0git.20111020.59dec96/lib
INCLUDES+=-I/tmp/SBo/xbmc-pre11.0git.20111020.59dec96/xbmc
ifneq (1,1)
        INCLUDES+=-I/tmp/SBo/xbmc-pre11.0git.20111020.59dec96/lib/ffmpeg
endif
INCLUDES+=-I/tmp/SBo/xbmc-pre11.0git.20111020.59dec96/xbmc/linux
INCLUDES+=-I/tmp/SBo/xbmc-pre11.0git.20111020.59dec96/xbmc/cores/dvdplayer



This causes most of the autodetected #defines in the XBMC config.h to be ignored, resulting in lots of warning spew about deprecated functions being used and macros being redefined. It will eventually fail the build when it tries to use no-longer-existing interfaces when building against ffmpeg. From http://pastebin.ca/2092015
Code:
In file included from /tmp/SBo/xbmc-pre11.0git.20111020.59dec96/lib/DllAvCodec.h:27:0,
                 from DVDOverlayCodecFFmpeg.h:25,
                 from DVDOverlayCodecFFmpeg.cpp:22:
/tmp/SBo/xbmc-pre11.0git.20111020.59dec96/lib/DllAvCore.h:53:32: fatal error: libavcore/avcore.h: No such file or directory



A simple fix is to add the system -Iincludedir search list *after* the XBMC -Iincludedir list. We can do this by relocating the $(sort @[email protected]) to be the very last addition to the list.
Code:
--- ./Makefile.include.in.orig  2011-10-20 14:22:43.681801349 -0500
+++ ./Makefile.include.in       2011-10-20 14:22:57.883801485 -0500
@@ -34,3 +34,2 @@
[email protected]@
-INCLUDES+=$(sort @[email protected])
[email protected][email protected]/lib
@@ -42,2 +41,3 @@
[email protected][email protected]/xbmc/cores/dvdplayer
+INCLUDES+=$(sort @[email protected])
DEFINES+= \

When this patch is applied, XBMC sucessfully builds.
Hi,

Could a dev look at this and post some feedback?

Thanks
To the top.

Do any of the devs read this forum?
The issue is also that nothing should really do #include <config.h>, they should be doing #include "config.h"