(2020-10-16, 04:55)amf1 Wrote: [ -> ]Thanks for the information. I don't believe 3 is just the TMDB issue, however. Surely, if a poster fails to load, Kodi should fall back to a working poster rather than showing me nothing at all?
Nope. Check your log for the error. If it is a http:// address, then it will fail. If it is a http
s:// address then it will work.
(2020-10-16, 04:55)amf1 Wrote: [ -> ]Also, do you have any suggestions for issue 1?
If it is not working (did it ever work?) then something has changed at IMDB. IMDB don't have a public API so the scraper works off the website, and changes in the layout will commonly cause problems with the scraper. @
olympia will need to look at that.
On my kodi, which uses the universal scraper, it's the same thing.. there are no posters showing.. However it is configured to grab the posters from IMDB and TMDB...
(2020-10-16, 06:47)Karellen Wrote: [ -> ] (2020-10-16, 06:13)vtwin0001 Wrote: [ -> ]On my kodi, which uses the universal scraper, it's the same thing.. there are no posters showing..
https://forum.kodi.tv/showthread.php?tid...pid2982169
I think the issue we are trying to point out is different. The problem is fixed for me (because of the TMDB addon update), so I can't check it, but what I was seeing was UMS would find a lot of posters, and the ones at the top of the list would all be TMDB, and none of those would work. I would see a bunch of errors in the log. But if I manually went and changed the cover art, when I scrolled to the bottom of the list, there would be one working poster, from IMDB. I would
not get the error described in the other thread.
What this means is that the scraper has the ability to show a working poster (by falling back from a broken URL to a working one), but it's not doing that.
Quote:Nope. Check your log for the error. If it is a http:// address, then it will fail. If it is a https:// address then it will work.
Exactly, I'm not getting an error for the IMDb posters because they are working. The issue is that Kodi isn't automatically using them.
(2020-10-16, 07:30)amf1 Wrote: [ -> ]What this means is that the scraper has the ability to show a working poster (by falling back from a broken URL to a working one), but it's not doing that.
No, it does not have that ability. What makes you think that Kodi can realise a link is broken and keep trying links to find a working one. There is no code for that. It just has a list of artwork links, it has no idea what works and what doesn't. The presumption is that if TMDB offers the links, then they work.
And yes, it sounds illogical because the log is full of errors, but there is no code that says,
oh look, error 404 lets try the next link and the next one until I find one that does not have an error.
(2020-10-16, 07:30)amf1 Wrote: [ -> ]Exactly, I'm not getting an error for the IMDb posters because they are working. The issue is that Kodi isn't automatically using them.
Kodi uses the first (most popular) piece of artwork in the list of artwork URL's. If you are using UMS, then go into settings and disable scraping posters from TMDB. After all, UMS has all these settings, use them.
(2020-10-15, 15:21)amf1 Wrote: [ -> ]1. Changing "Get Plot From" from "IMDb" to "IMDb Outline" gives me a broken / empty description. I'd ultimately like it to use the short description that IMDb shows at the top of the page, as this usually has fewer spoilers. (Actually, this is what prompted me to try switching from the default scraper to UMS - the default scraper shows spoilers for the movie with alarming frequency in the plot description.)
@
olympia has fixed the issue...
https://github.com/xbmc/repo-scrapers/co...c3e408b64e
It can be dowloaded by zip here...
http://mirrors.kodi.tv/addons/gotham/met....imdb.com/
or wait for your local repo to update automatically.
Its not the scraper, but one of the dependency addons.
(2020-10-16, 07:56)Karellen Wrote: [ -> ] (2020-10-16, 07:30)amf1 Wrote: [ -> ]What this means is that the scraper has the ability to show a working poster (by falling back from a broken URL to a working one), but it's not doing that.
No, it does not have that ability. What makes you think that Kodi can realise a link is broken and keep trying links to find a working one.
My only reason for thinking it is that I'm a programmer, and if I were coding an add-on, that's what I would make it do. It seems like a bug to only try the first URL, get a 404 (or 502 or whatever), and then give up. Thought it should be fixed, that's all. If this is the desired behavior, that's fine.
Quote:Kodi uses the first (most popular) piece of artwork in the list of artwork URL's. If you are using UMS, then go into settings and disable scraping posters from TMDB. After all, UMS has all these settings, use them.
As I mentioned before (issue 4), I did try disabling TMDB, but this appeared to be ignored, at least some of the time. I was still getting broken TMDB posters in the list and many / most films weren't scanning with posters.
Thanks for the quick fix to the scraper. Looking at the code, I'm surprised to see it's using regex to parse HTML instead of a library like BeautifulSoup. Is it faster or more reliable that way?
(2020-10-16, 09:36)amf1 Wrote: [ -> ]and if I were coding an add-on, that's what I would make it do
Sure, I do understand that and I understand why people will think "well there's all the errors in the log, so Kodi knows about it, why not try the next link", but it doesn't work that way as it was never coded that way.
The scraper supplies the artwork URL's only. It does nothing else with artwork. It is the thumbloader in Kodi core that then uses the link to download artwork. So there is a separation between what downloads the links, and what actually uses those links.
(2020-10-16, 09:36)amf1 Wrote: [ -> ]I did try disabling TMDB, but this appeared to be ignored, at least some of the time. I was still getting broken TMDB posters in the list and many / most films weren't scanning with posters.
Right, sorry I missed that. You can imagine how many posts I have read and responded to over 24 hours so forget some of the details. If that is the case, if you can replicate that problem and capture it in a
Debug Log, we can look at where the problem may be.
(2020-10-16, 09:36)amf1 Wrote: [ -> ]I'm surprised to see it's using regex to parse HTML instead of a library like BeautifulSoup. Is it faster or more reliable that way?
Faster or more reliable? No, just what has been in use over the last decade or more. The second generation of Python scrapers have been released, but the uptake is slow. There won't be a UMS Python replacement though.
https://forum.kodi.tv/showthread.php?tid=351546
Everything is fine until a few days ago. I am unable to match any of my new movies if I set the search engine to themoviedb.org. I have to change the search engine to imdb in order for it to work. I have updated the add-on to the latest version but it still doesn't work.
I attach the bebug log for your info:
https://paste.kodi.tv/ijidovixac.kodi
P.S. The Kodi installed on Windows is working even if I set the search engine to themoviedb.org. The problem only occurs to Kodi on my QNAP, which is Ubuntu based.
Rotten tomatoes ratings ain't showing up anymore when adding/updating movie :/
(2020-10-17, 15:28)Sevenuno Wrote: [ -> ]With libcURL logging enabled: https://paste.kodi.tv/eyuleguyeg.kodi
Thanks. I wanted your log as I had spotted something slightly different, but the extended log shows it is still part of the same issue.
If you are in any position to, maybe you could build and test this...
https://github.com/xbmc/xbmc/pull/18582 I notice you are on an older build of v18, so you will need to update anyway. Any feedback about testing, please add it to the PR conversation
Regarding the -recurring from time to time-requests that Universal Movie scraper picks up adult movies in IMDB, might I suggest the following simple hack:
a) Locate the file named "kodi-webinterface.js". In my installation it resides in "C:\Program Files\Kodi\addons\webinterface.default\js\"
b) Open it as a plain text file, using an editor such as notepad or notepad++ If you're running recent-ish MS-Windows, make sure you edit it as an administrator. Open -for example- a command window as administrator and run from there notepad.
c) Find the following block
externalSearchUrls: {
google: 'https://www.google.com/webhp?#q=[QUERY]',
imdb: 'http://www.imdb.com/find?s=all&q=[QUERY]',
tmdb: 'https://www.themoviedb.org/search?query=[QUERY]',
tvdb: 'http://thetvdb.com/?searchseriesid=&tab=listseries&function=Search&string=[QUERY]',
soundcloud: 'https://soundcloud.com/search?q=[QUERY]',
youtube: 'https://www.youtube.com/results?search_query=[QUERY]'
},
d) change
imdb: 'http://www.imdb.com/find?s=all&q=[QUERY]',
to
imdb: 'http://www.imdb.com/find?s=all&adult=include&q=[QUERY]',
e) save. Should you be prompted that you may not save/replace the file, make sure that you have opened the file as an administrator.
f) scan again your movie folders using Universal Movie scraper/IMDB data.
Kind regards,
MP