Image Rating is fixed in version 2.2.8 which is in my repo
I hope I haven't been too lazy by reading just the last few pages of this thread, but I noticed that some of my pictures were missing / not scanned into the database. This appears to be the case with pictures that have capital "JPG" as an extension. I'm using version 2.2.0, realizing there's a newer one out there, so it may have been fixed already? It's not possible to change this in the "Files" tab of MyPicsDB settings, since capitals are already used there in the 'Picture extensions".
I own a CentOS server with a NFS export.
I tested this export as a picture source for XBMC with 2 pictures:
- TEST.JPG
- test.jpg
Both were scanned and included into MyPics database.
Hi,
I am using your great add-on version 2.2.8 via MySQL. I found that name of table 'files' used with both small & large capital which causing problems due to MySQL being case sensitive, ie. some of your queries fail obviously.
Also i'm wondering why not using mmap module to read files as extracting EXIF info requires lots of byte positioning/reading? Some limited tests i have done show significant speed improvement. The additional memory requirement i guess would be under control as anyhow one file is check at any time. [unless you plan some parallel processing in future releases :-)]
Thanks
ps. would recommend if you don't mind to add scan.iscanceled() check into _scanpath._addpath() after the main loop as well where you clear db and more importantly where try to go recursive.
(2013-05-15, 12:14)grrr Wrote: [ -> ]I am using your great add-on version 2.2.8 via MySQL. I found that name of table 'files' used with both small & large capital which causing problems due to MySQL being case sensitive, ie. some of your queries fail obviously.
That's the reason why it is still a development release.
But with Windows 7 and MySql 5.5 it works! My MySql is not case sensitive and all tables are create with lower case characters.
What OS do you use?
(2013-05-15, 12:14)grrr Wrote: [ -> ]Also i'm wondering why not using mmap module to read files as extracting EXIF info requires lots of byte positioning/reading? Some limited tests i have done show significant speed improvement. The additional memory requirement i guess would be under control as anyhow one file is check at any time. [unless you plan some parallel processing in future releases :-)]
Because improving the usabiltiy has higher priority.
thanks for you reply.
first all i did not mean my words as criticism but report of issue(s) found and quick and very easy improvement idea (*).
now, i think only MySQL version matters which is 5.6 and btw running on FreeBSD.
(*) i think from this
Code:
file=open(filename, 'rb')
file.read()
Code:
f=open(filename, 'rb')
file = mmap.mmap(f.fileno(), 0)
file.read()
I didn't see any negative criticism in your bug report
All ideas to improve MyPicsDB are really welcome wether it's usabilty, performance or whatever.
But I've a problem:
The time which I can spend on this project
Your MySql issue with Linux.
There is a new 2.2.10 version which I tested with my CentOS fileserver.
The create database statement uses a different collation!
It works but of course I cannot guarantee that everything will work.
There are thousands of errors like these, which I've just determined are caused by the Slideshow Screensaver v1.4. Ronnie just sent me update to test.
http://pastebin.com/embed_js.php?i=U3P9Af1A
Here is everything that preceded the above errors.
http://pastebin.com/embed_js.php?i=xBXvANNv
It appears there is another issue however pointed out by Kibje. At quick glance it seems to be an issue with the mypicsdb addon.
It is trying to handle a urlencoded location
Code:
image://smb://SERVER2/video2/Movies Anime Sets/Ice Age Scrat Collection/Ice Age 3 - Dawn of the Dinosaurs (2009)/fanart.jpg/
I wonder both about the image:// at the start and the slash at the end.
1) Slideshow Screensaver : Wrong thread
2) MyPicsDB: Please upload a complete log file.
In MyPicsDB settings you've to enable debug mode.
(2013-05-30, 09:31)Xycl Wrote: [ -> ]1) Slideshow Screensaver : Wrong thread
2) MyPicsDB: Please upload a complete log file.
In MyPicsDB settings you've to enable debug mode.
Thank you responding. Here is the log.
http://pastebin.com/embed_js.php?i=iMayFGMb
Code:
19:08:01 T:3920 ERROR: [plugin.image.mypicsdb] line 1078 in MypicsDB.py object RequestWithBinds >> The request failed :
19:08:01 T:3920 ERROR: [plugin.image.mypicsdb] line 1079 in MypicsDB.py object RequestWithBinds >> <type \'exceptions.Exception\'> - no such table: files
19:08:01 T:3920 ERROR: [plugin.image.mypicsdb] line 1080 in MypicsDB.py object RequestWithBinds >> SQL RequestWithBinds > SELECT COUNT(*) FROM files WHERE ImageDateTime IS NOT NULL
The database is corrupted or was never properly initialized.
Delete the MyPictures.db file in userdata/Database directory and start MyPicsDB add-on in XBMC. Afterwards the db should be initialized.
(2013-05-31, 09:06)Xycl Wrote: [ -> ]Code:
19:08:01 T:3920 ERROR: [plugin.image.mypicsdb] line 1078 in MypicsDB.py object RequestWithBinds >> The request failed :
19:08:01 T:3920 ERROR: [plugin.image.mypicsdb] line 1079 in MypicsDB.py object RequestWithBinds >> <type \'exceptions.Exception\'> - no such table: files
19:08:01 T:3920 ERROR: [plugin.image.mypicsdb] line 1080 in MypicsDB.py object RequestWithBinds >> SQL RequestWithBinds > SELECT COUNT(*) FROM files WHERE ImageDateTime IS NOT NULL
The database is corrupted or was never properly initialized.
Delete the MyPictures.db file in userdata/Database directory and start MyPicsDB add-on in XBMC. Afterwards the db should be initialized.
Thank you.
I did as you suggested but I was still getting a visual error the that database had failed or something to that effect each time I open XBMC. Once I added a path I no longer get the error when opening xbmc.
Still getting some errors in log.
http://pastebin.com/embed_js.php?i=0aExUPiv
I don't think that the messages
Code:
07:36:48 T:1752 ERROR: Keymapping error: no such action \'\' defined
07:38:44 T:1912 NOTICE: Thread Background Loader start, auto delete: false
07:38:44 T:1912 ERROR: XFILE::CDirectory::GetDirectory - Error getting add
come from MyPicsDB.
(2013-06-01, 11:48)Xycl Wrote: [ -> ]I don't think that the messages
Code:
07:36:48 T:1752 ERROR: Keymapping error: no such action \'\' defined
07:38:44 T:1912 NOTICE: Thread Background Loader start, auto delete: false
07:38:44 T:1912 ERROR: XFILE::CDirectory::GetDirectory - Error getting add
Thx again for looking.
I know this isn't your issue, but how would I figure out what the offending program is?
(2013-05-17, 16:29)grrr Wrote: [ -> ]Code:
f=open(filename, 'rb')
file = mmap.mmap(f.fileno(), 0)
file.read()
This does not work on Windows!
I figured out that it has to be
Code:
f=open(filename, 'r+b')
file = mmap.mmap(f.fileno(), 0)
file.read()
Don't know if it works on Android.